b7bdf1996f
This patch implements a new clang driver flag -fsafe-buffer-usage-suggestions which allows turning the smart suggestion machine on and off (defaults to off). This is valuable for stability reasons, as the machine is being rapidly improved\ and we don't want accidental breakages to ruin the build for innocent users. It is also arguably useful in general because it enables separation of concerns between project contributors: some users will actively update the code to conform to the programming model, while others simply want to make sure that they aren't regressing it. Finally, there could be other valid reasons to opt out of suggestions entirely on some codebases (while continuing to enforce -Wunsafe-buffer-usage warnings), such as lack of access to hardened libc++ (or even to the C++ standard library in general) on the target platform. When the flag is disabled, the unsafe buffer usage analysis is reduced to an extremely minimal mode of operation that contains virtually no smarts: not only it doesn't offer automatic fixits, but also textual suggestions such as "change the type of this variable to std::span to preserve bounds information" are not displayed, and in fact the machine doesn't even try to blame specific variables in the first place, it simply warns on the operations and leaves everything else to the user. So this flag turns off a lot more of our complex machinery than what we already turn off in presence of say -fno-diagnostic-fixit-info. The flag is discoverable: when it's off, the warnings are accompanied by a note: telling the user that there's a flag they can use. Differential Revision: https://reviews.llvm.org/D146669
88 lines
2.1 KiB
C++
88 lines
2.1 KiB
C++
// RUN: %clang_cc1 -std=c++20 -Wunsafe-buffer-usage \
|
|
// RUN: -fsafe-buffer-usage-suggestions -verify %s
|
|
|
|
[[clang::unsafe_buffer_usage]]
|
|
void deprecatedFunction3();
|
|
|
|
void deprecatedFunction4(int z);
|
|
|
|
void someFunction();
|
|
|
|
[[clang::unsafe_buffer_usage]]
|
|
void overloading(int* x);
|
|
|
|
void overloading(char c[]);
|
|
|
|
void overloading(int* x, int size);
|
|
|
|
[[clang::unsafe_buffer_usage]]
|
|
void deprecatedFunction4(int z);
|
|
|
|
void caller(int z, int* x, int size, char c[]) {
|
|
deprecatedFunction3(); // expected-warning{{function introduces unsafe buffer manipulation}}
|
|
deprecatedFunction4(z); // expected-warning{{function introduces unsafe buffer manipulation}}
|
|
someFunction();
|
|
|
|
overloading(x); // expected-warning{{function introduces unsafe buffer manipulation}}
|
|
overloading(x, size);
|
|
overloading(c);
|
|
}
|
|
|
|
[[clang::unsafe_buffer_usage]]
|
|
void overloading(char c[]);
|
|
|
|
// Test variadics
|
|
[[clang::unsafe_buffer_usage]]
|
|
void testVariadics(int *ptr, ...);
|
|
|
|
template<typename T, typename... Args>
|
|
[[clang::unsafe_buffer_usage]]
|
|
T adder(T first, Args... args);
|
|
|
|
template <typename T>
|
|
void foo(T t) {}
|
|
|
|
template<>
|
|
[[clang::unsafe_buffer_usage]]
|
|
void foo<int *>(int *t) {}
|
|
|
|
void caller1(int *p, int *q) {
|
|
testVariadics(p, q); // expected-warning{{function introduces unsafe buffer manipulation}}
|
|
adder(p, q); // expected-warning{{function introduces unsafe buffer manipulation}}
|
|
|
|
int x;
|
|
foo(x);
|
|
foo(&x); // expected-warning{{function introduces unsafe buffer manipulation}}
|
|
}
|
|
|
|
// Test virtual functions
|
|
class BaseClass {
|
|
public:
|
|
[[clang::unsafe_buffer_usage]]
|
|
virtual void func() {}
|
|
|
|
virtual void func1() {}
|
|
};
|
|
|
|
class DerivedClass : public BaseClass {
|
|
public:
|
|
void func() {}
|
|
|
|
[[clang::unsafe_buffer_usage]]
|
|
void func1() {}
|
|
};
|
|
|
|
void testInheritance() {
|
|
DerivedClass DC;
|
|
DC.func();
|
|
DC.func1(); // expected-warning{{function introduces unsafe buffer manipulation}}
|
|
|
|
BaseClass *BC;
|
|
BC->func(); // expected-warning{{function introduces unsafe buffer manipulation}}
|
|
BC->func1();
|
|
|
|
BC = &DC;
|
|
BC->func(); // expected-warning{{function introduces unsafe buffer manipulation}}
|
|
BC->func1();
|
|
}
|