73d01a80ce
According to https://sourceware.org/binutils/docs/ld/Input-Section-Basics.html#Input-Section-Basics for `*(.a .b)`, the order should match the input order: * for `ld 1.o 2.o`, sections from 1.o precede sections from 2.o * within a file, `.a` and `.b` appear in the section header table order This patch implements the behavior. The interaction with `SORT*` and --sort-section is: Matched sections are ordered by radix sort with the keys being `(SORT*, --sort-section, input order)`, where `SORT*` (if present) is most significant. > Note, multiple `SORT*` within an input section description has undocumented and > confusing behaviors in GNU ld: > https://sourceware.org/pipermail/binutils/2020-November/114083.html > Therefore multiple `SORT*` is not the focus for this patch but > this patch still strives to have an explainable behavior. As an example, we partition `SORT(a.*) b.* c.* SORT(d.*)`, into `SORT(a.*) | b.* c.* | SORT(d.*)` and perform sorting within groups. Sections matched by patterns between two `SORT*` are sorted by input order. If --sort-alignment is given, they are sorted by --sort-alignment, breaking tie by input order. This patch also allows a section to be matched by multiple patterns, previously duplicated sections could occupy more space in the output and had erroneous zero bytes. The patch is in preparation for support for `*(SORT_BY_INIT_PRIORITY(.init_array.* .ctors.*)) *(.init_array .ctors)`, which will allow LLD to mix .ctors*/.init_array* like GNU ld (gold's --ctors-in-init-array) PR44698 and PR48096 Reviewed By: grimar, psmith Differential Revision: https://reviews.llvm.org/D91127
41 lines
1.7 KiB
ArmAsm
41 lines
1.7 KiB
ArmAsm
# REQUIRES: x86
|
|
# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %tfile1.o
|
|
# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %p/Inputs/exclude-multiple1.s -o %tfile2.o
|
|
# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %p/Inputs/exclude-multiple2.s -o %tfile3.o
|
|
# RUN: echo "SECTIONS { \
|
|
# RUN: .foo : { *(.foo.1 EXCLUDE_FILE (*file1.o) .foo.2 EXCLUDE_FILE (*file2.o) .foo.3) } \
|
|
# RUN: }" > %t1.script
|
|
# RUN: ld.lld -script %t1.script %tfile1.o %tfile2.o %tfile3.o -o %t1.o
|
|
# RUN: llvm-objdump -s %t1.o | FileCheck %s
|
|
|
|
## Sections from %tfile1 precede sections from %tfile2 and %tfile3.
|
|
## In each file, the sections are added in the original order.
|
|
# CHECK: Contents of section .foo:
|
|
# CHECK-NEXT: 03000000 00000000 01000000 00000000
|
|
# CHECK-NEXT: 04000000 00000000 05000000 00000000
|
|
# CHECK-NEXT: 07000000 00000000 08000000 00000000
|
|
# CHECK-NEXT: 09000000 00000000
|
|
# CHECK-NEXT: Contents of section .foo.2:
|
|
# CHECK-NEXT: 02000000 00000000
|
|
# CHECK-NEXT: Contents of section .foo.3:
|
|
# CHECK-NEXT: 06000000 00000000
|
|
|
|
# RUN: echo "SECTIONS { .foo : { *(EXCLUDE_FILE (*file1.o) EXCLUDE_FILE (*file2.o) .foo.3) } }" > %t2.script
|
|
# RUN: not ld.lld -script %t2.script %tfile1.o %tfile2.o %tfile3.o -o /dev/null 2>&1 | \
|
|
# RUN: FileCheck %s --check-prefix=ERR
|
|
# ERR: section pattern is expected
|
|
|
|
# RUN: echo "SECTIONS { .foo : { *(EXCLUDE_FILE (*file1.o)) } }" > %t3.script
|
|
# RUN: not ld.lld -script %t3.script %tfile1.o %tfile2.o %tfile3.o -o /dev/null 2>&1 | \
|
|
# RUN: FileCheck %s --check-prefix=ERR
|
|
|
|
.section .foo.2,"a"
|
|
.quad 2
|
|
|
|
## %tfile1.o(.foo.3) precedes %tfile.o(.foo.1) in the output section.
|
|
.section .foo.3,"a"
|
|
.quad 3
|
|
|
|
.section .foo.1,"a"
|
|
.quad 1
|