bb62ef9943
codesign/libstuff checks that the `__LLVM` segment is directly before `__LINKEDIT` by checking that `fileOff + fileSize == next segment fileOff`. Previously, there would be gaps between the segments due to the fact that their fileOffs are page-aligned but their fileSizes aren't. In order to satisfy codesign, we page-align fileOff *before* calculating fileSize. (I don't think codesign checks for the relative ordering of other segments, so in theory we could do this just for `__LLVM`, but ld64 seems to do it for all segments.) Note that we *don't* round up the fileSize of the `__LINKEDIT` segment. Since it's the last segment, it doesn't need to worry about contiguity; in addition, codesign checks that the last (hidden) section in `__LINKEDIT` covers the last byte of the segment, so if we rounded up `__LINKEDIT`'s size we would have to do the same for its last section, which is a bother. While at it, I also addressed a FIXME in the linkedit-contiguity.s test to cover more `__LINKEDIT` sections. Reviewed By: #lld-macho, thakis, alexshap Differential Revision: https://reviews.llvm.org/D100848
57 lines
1.2 KiB
ArmAsm
57 lines
1.2 KiB
ArmAsm
# REQUIRES: x86
|
|
# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %s -o %t.o
|
|
# RUN: %lld -o %t %t.o
|
|
# RUN: llvm-readobj --section-headers --macho-segment %t | FileCheck %s
|
|
|
|
# CHECK: Name: __text
|
|
# CHECK-NEXT: Segment: __TEXT
|
|
# CHECK-NOT: }
|
|
# CHECK: Alignment: 1
|
|
# CHECK-NOT: }
|
|
# CHECK: Type: Regular (0x0)
|
|
# CHECK-NEXT: Attributes [ (0x800004)
|
|
# CHECK-NEXT: PureInstructions (0x800000)
|
|
# CHECK-NEXT: SomeInstructions (0x4)
|
|
# CHECK-NEXT: ]
|
|
|
|
# CHECK: Name: __cstring
|
|
# CHECK-NEXT: Segment: __TEXT
|
|
# CHECK-NOT: }
|
|
# CHECK: Alignment: 2
|
|
# CHECK-NOT: }
|
|
# CHECK: Type: CStringLiterals (0x2)
|
|
# CHECK-NEXT: Attributes [ (0x0)
|
|
# CHECK-NEXT: ]
|
|
|
|
# CHECK: Name: maxlen_16ch_name
|
|
# CHECK-NEXT: Segment: __TEXT
|
|
# CHECK-NEXT: Address:
|
|
# CHECK-NEXT: Size:
|
|
# CHECK-NEXT: Offset:
|
|
# CHECK-NEXT: Alignment: 3
|
|
# CHECK-NOT: }
|
|
# CHECK: Type: Regular (0x0)
|
|
|
|
# CHECK-LABEL: Segment {
|
|
# CHECK: Name: __TEXT
|
|
# CHECK-NEXT: Size:
|
|
# CHECK-NEXT: vmaddr:
|
|
# CHECK-NEXT: vmsize:
|
|
# CHECK-NEXT: fileoff: 0
|
|
# CHECK-NEXT: filesize: 4096
|
|
|
|
.text
|
|
.align 1
|
|
.global _main
|
|
_main:
|
|
mov $0, %rax
|
|
ret
|
|
|
|
.section __TEXT,__cstring
|
|
.align 2
|
|
str:
|
|
.asciz "Hello world!\n"
|
|
|
|
.section __TEXT,maxlen_16ch_name
|
|
.align 3
|