1eeeab82c6
Any time we see the pattern `assertEqual(value, bool)`, we can replace
that with `assert<bool>(value)`. Likewise for `assertNotEqual`.
Technically this relaxes the test a bit, as we may want to make sure
`value` is either `True` or `False`, and not something that implicitly
converts to a bool. For example, `assertEqual("foo", True)` will fail,
but `assertTrue("foo")` will not. In most cases, this distinction is not
important.
There are two such places that this patch does **not** transform, since
it seems intentional that we want the result to be a bool:
*
5daf2001a1/lldb/test/API/python_api/sbstructureddata/TestStructuredDataAPI.py (L90)
*
5daf2001a1/lldb/test/API/commands/settings/TestSettings.py (L940)
Followup to 9c2468821e. I patched `teyit`
with a `visit_assertEqual` node handler to generate this.
48 lines
1.7 KiB
Python
48 lines
1.7 KiB
Python
"""
|
|
Test that breakpoints set on a bad address say they are bad.
|
|
"""
|
|
|
|
|
|
import lldb
|
|
import lldbsuite.test.lldbutil as lldbutil
|
|
from lldbsuite.test.lldbtest import *
|
|
|
|
|
|
class BadAddressBreakpointTestCase(TestBase):
|
|
NO_DEBUG_INFO_TESTCASE = True
|
|
|
|
def test_bad_address_breakpoints(self):
|
|
"""Test that breakpoints set on a bad address say they are bad."""
|
|
self.build()
|
|
self.address_breakpoints()
|
|
|
|
def address_breakpoints(self):
|
|
"""Test that breakpoints set on a bad address say they are bad."""
|
|
target, process, thread, bkpt = lldbutil.run_to_source_breakpoint(
|
|
self, "Set a breakpoint here", lldb.SBFileSpec("main.c")
|
|
)
|
|
|
|
# illegal_address will hold (optionally) an address that, if
|
|
# used as a breakpoint, will generate an unresolved breakpoint.
|
|
illegal_address = None
|
|
|
|
# Walk through all the memory regions in the process and
|
|
# find an address that is invalid.
|
|
regions = process.GetMemoryRegions()
|
|
for region_idx in range(regions.GetSize()):
|
|
region = lldb.SBMemoryRegionInfo()
|
|
regions.GetMemoryRegionAtIndex(region_idx, region)
|
|
if illegal_address == None or region.GetRegionEnd() > illegal_address:
|
|
illegal_address = region.GetRegionEnd()
|
|
|
|
if illegal_address is not None:
|
|
# Now, set a breakpoint at the address we know is illegal.
|
|
bkpt = target.BreakpointCreateByAddress(illegal_address)
|
|
# Verify that breakpoint is not resolved.
|
|
for bp_loc in bkpt:
|
|
self.assertFalse(bp_loc.IsResolved())
|
|
else:
|
|
self.fail(
|
|
"Could not find an illegal address at which to set a bad breakpoint."
|
|
)
|