Summary:
Around a third of our test sources have LLVM license headers. This patch removes those headers from all test
sources and also fixes any tests that depended on the length of the license header.
The reasons for this are:
* A few tests verify line numbers and will start failing if the number of lines in the LLVM license header changes. Once I landed my patch for valid SourceLocations in debug info we will probably have even more tests that verify line numbers.
* No other LLVM project is putting license headers in its test files to my knowledge.
* They make the test sources much more verbose than they have to be. Several tests have longer license headers than the actual test source.
For the record, the following tests had their line numbers changed to pass with the removal of the license header:
lldb-api :: functionalities/breakpoint/breakpoint_by_line_and_column/TestBreakpointByLineAndColumn.py
lldb-shell :: Reproducer/TestGDBRemoteRepro.test
lldb-shell :: Reproducer/TestMultipleTargets.test
lldb-shell :: Reproducer/TestReuseDirectory.test
lldb-shell :: ExecControl/StopHook/stop-hook-threads.test
lldb-shell :: ExecControl/StopHook/stop-hook.test
lldb-api :: lang/objc/exceptions/TestObjCExceptions.py
Reviewers: #lldb, espindola, JDevlieghere
Reviewed By: #lldb, JDevlieghere
Subscribers: emaste, aprantl, arphaman, JDevlieghere, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D74839
65 lines
1.5 KiB
Objective-C
65 lines
1.5 KiB
Objective-C
// This file is for testing running "print object" in a case where another thread
|
|
// blocks the print object from making progress. Set a breakpoint on the line in
|
|
// my_pthread_routine as indicated. Then switch threads to the main thread, and
|
|
// do print the lock_me object. Since that will try to get the lock already gotten
|
|
// by my_pthread_routime thread, it will have to switch to running all threads, and
|
|
// that should then succeed.
|
|
//
|
|
|
|
#include <Foundation/Foundation.h>
|
|
#include <pthread.h>
|
|
|
|
static pthread_mutex_t test_mutex;
|
|
|
|
static void Mutex_Init (void)
|
|
{
|
|
pthread_mutexattr_t tmp_mutex_attr;
|
|
pthread_mutexattr_init(&tmp_mutex_attr);
|
|
pthread_mutex_init(&test_mutex, &tmp_mutex_attr);
|
|
}
|
|
|
|
@interface LockMe :NSObject
|
|
{
|
|
|
|
}
|
|
- (NSString *) description;
|
|
@end
|
|
|
|
@implementation LockMe
|
|
- (NSString *) description
|
|
{
|
|
printf ("LockMe trying to get the lock.\n");
|
|
pthread_mutex_lock(&test_mutex);
|
|
printf ("LockMe got the lock.\n");
|
|
pthread_mutex_unlock(&test_mutex);
|
|
return @"I am pretty special.\n";
|
|
}
|
|
@end
|
|
|
|
void *
|
|
my_pthread_routine (void *data)
|
|
{
|
|
printf ("my_pthread_routine about to enter.\n");
|
|
pthread_mutex_lock(&test_mutex);
|
|
printf ("Releasing Lock.\n"); // Set a breakpoint here.
|
|
pthread_mutex_unlock(&test_mutex);
|
|
return NULL;
|
|
}
|
|
|
|
int
|
|
main ()
|
|
{
|
|
pthread_attr_t tmp_attr;
|
|
pthread_attr_init (&tmp_attr);
|
|
pthread_t my_pthread;
|
|
|
|
Mutex_Init ();
|
|
|
|
LockMe *lock_me = [[LockMe alloc] init];
|
|
pthread_create (&my_pthread, &tmp_attr, my_pthread_routine, NULL);
|
|
|
|
pthread_join (my_pthread, NULL);
|
|
|
|
return 0;
|
|
}
|