5be7f2a943
Assemblers change certain relocations referencing a local symbol to
reference the section symbol instead. This conversion is disabled for
many conditions (`shouldRelocateWithSymbol`), e.g. TLS symbol, for most
targets (including AArch32, x86, PowerPC, and RISC-V) GOT-generating
relocations.
However, AArch64 encodes the GOT-generating intent in MCValue::RefKind
instead of MCSymbolRef::Kind (see commit
0999cbd0b9 (2014)), therefore not affected
by the code `case MCSymbolRefExpr::VK_GOT:`. As GNU ld and ld.lld
create GOT entries based on the symbol, ignoring addend, the two ldr
instructions will share the same GOT entry, which is not expected:
```
ldr x1, [x1, :got_lo12:x] // converted to .data+0
ldr x1, [x1, :got_lo12:y] // converted to .data+4
.data
// .globl x, y would suppress STT_SECTION conversion
x:
.zero 4
y:
.long 42
```
This patch changes AArch64 to suppress local symbol to STT_SECTION
conversion for GOT relocations, matching most other targets. x and y
will use different GOT entries, which IMO is the most sensable behavior.
With this change, the ABI decision on https://github.com/ARM-software/abi-aa/issues/217
will only affect relocations explicitly referencing STT_SECTION symbols, e.g.
```
ldr x1, [x1, :got_lo12:(.data+0)]
ldr x1, [x1, :got_lo12:(.data+4)]
// I consider this unreasonable uses
```
IMO all reasonable use cases are unaffected.
Link: https://github.com/llvm/llvm-project/issues/63418
GNU assembler PR: https://sourceware.org/bugzilla/show_bug.cgi?id=30788
Reviewed By: peter.smith
Differential Revision: https://reviews.llvm.org/D158577
68 lines
2.2 KiB
C++
68 lines
2.2 KiB
C++
//===-- XtensaMCObjectWriter.cpp - Xtensa ELF writer ----------------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "MCTargetDesc/XtensaMCTargetDesc.h"
|
|
#include "llvm/ADT/STLExtras.h"
|
|
#include "llvm/BinaryFormat/ELF.h"
|
|
#include "llvm/MC/MCELFObjectWriter.h"
|
|
#include "llvm/MC/MCExpr.h"
|
|
#include "llvm/MC/MCFixup.h"
|
|
#include "llvm/MC/MCObjectWriter.h"
|
|
#include "llvm/MC/MCValue.h"
|
|
#include "llvm/Support/ErrorHandling.h"
|
|
#include <cassert>
|
|
#include <cstdint>
|
|
|
|
using namespace llvm;
|
|
|
|
namespace {
|
|
class XtensaObjectWriter : public MCELFObjectTargetWriter {
|
|
public:
|
|
XtensaObjectWriter(uint8_t OSABI);
|
|
|
|
virtual ~XtensaObjectWriter();
|
|
|
|
protected:
|
|
unsigned getRelocType(MCContext &Ctx, const MCValue &Target,
|
|
const MCFixup &Fixup, bool IsPCRel) const override;
|
|
bool needsRelocateWithSymbol(const MCValue &Val, const MCSymbol &Sym,
|
|
unsigned Type) const override;
|
|
};
|
|
} // namespace
|
|
|
|
XtensaObjectWriter::XtensaObjectWriter(uint8_t OSABI)
|
|
: MCELFObjectTargetWriter(false, OSABI, ELF::EM_XTENSA,
|
|
/*HasRelocationAddend=*/true) {}
|
|
|
|
XtensaObjectWriter::~XtensaObjectWriter() {}
|
|
|
|
unsigned XtensaObjectWriter::getRelocType(MCContext &Ctx, const MCValue &Target,
|
|
const MCFixup &Fixup,
|
|
bool IsPCRel) const {
|
|
|
|
switch ((unsigned)Fixup.getKind()) {
|
|
case FK_Data_4:
|
|
return ELF::R_XTENSA_32;
|
|
default:
|
|
return ELF::R_XTENSA_SLOT0_OP;
|
|
}
|
|
}
|
|
|
|
std::unique_ptr<MCObjectTargetWriter>
|
|
llvm::createXtensaObjectWriter(uint8_t OSABI, bool IsLittleEndian) {
|
|
return std::make_unique<XtensaObjectWriter>(OSABI);
|
|
}
|
|
|
|
bool XtensaObjectWriter::needsRelocateWithSymbol(const MCValue &,
|
|
const MCSymbol &,
|
|
unsigned Type) const {
|
|
return false;
|
|
}
|