fb1be9b33c
This PR introduces a step after instruction selection where instructions can be traversed from the perspective of their validity from the specification point of view. The PR adds also a way to correct load/store when there is a type mismatch contradicting the specification -- an additional bitcast is inserted to keep types consistent. Correspondent test cases are added and existing test cases are corrected. This PR helps to successfully validate with the `spirv-val` tool (https://github.com/KhronosGroup/SPIRV-Tools) some output that previously led to validation errors and crashes of back translation from SPIRV to LLVM IR from the side of SPIRV Translator project (https://github.com/KhronosGroup/SPIRV-LLVM-Translator). The added step of bringing instructions to required by the specification type correspondence can be (should be and will be) extended beyond load/store instructions to ensure validity rules of other SPIRV instructions related to type inference.
40 lines
1.4 KiB
LLVM
40 lines
1.4 KiB
LLVM
; RUN: llc -O0 -mtriple=spirv32-unknown-unknown %s -o - | FileCheck %s
|
|
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv64-unknown-unknown %s -o - -filetype=obj | spirv-val %}
|
|
|
|
@global = addrspace(1) constant i32 1 ; OpenCL global memory
|
|
@constant = addrspace(2) constant i32 2 ; OpenCL constant memory
|
|
@local = addrspace(3) constant i32 3 ; OpenCL local memory
|
|
|
|
define i32 @getGlobal1() {
|
|
%g = load i32, i32 addrspace(1)* @global
|
|
ret i32 %g
|
|
}
|
|
|
|
define i32 @getGlobal2() {
|
|
%g = load i32, i32 addrspace(2)* @constant
|
|
ret i32 %g
|
|
}
|
|
|
|
define i32 @getGlobal3() {
|
|
%g = load i32, i32 addrspace(3)* @local
|
|
ret i32 %g
|
|
}
|
|
|
|
; CHECK: [[INT:%.+]] = OpTypeInt 32
|
|
|
|
; CHECK-DAG: [[PTR_TO_INT_AS1:%.+]] = OpTypePointer CrossWorkgroup [[INT]]
|
|
; CHECK-DAG: [[PTR_TO_INT_AS2:%.+]] = OpTypePointer UniformConstant [[INT]]
|
|
; CHECK-DAG: [[PTR_TO_INT_AS3:%.+]] = OpTypePointer Workgroup [[INT]]
|
|
|
|
; CHECK-DAG: [[CST_AS1:%.+]] = OpConstant [[INT]] 1
|
|
; CHECK-DAG: [[CST_AS2:%.+]] = OpConstant [[INT]] 2
|
|
; CHECK-DAG: [[CST_AS3:%.+]] = OpConstant [[INT]] 3
|
|
|
|
; CHECK-DAG: [[GV1:%.+]] = OpVariable [[PTR_TO_INT_AS1]] CrossWorkgroup [[CST_AS1]]
|
|
; CHECK-DAG: [[GV2:%.+]] = OpVariable [[PTR_TO_INT_AS2]] UniformConstant [[CST_AS2]]
|
|
; CHECK-DAG: [[GV3:%.+]] = OpVariable [[PTR_TO_INT_AS3]] Workgroup [[CST_AS3]]
|
|
|
|
; CHECK: OpLoad [[INT]] [[GV1]]
|
|
; CHECK: OpLoad [[INT]] [[GV2]]
|
|
; CHECK: OpLoad [[INT]] [[GV3]]
|