This pull request aims to remove any dependency on OpenCL/SPIR-V type information in LLVM IR metadata. While, using metadata might simplify and prettify the resulting SPIR-V output (and restore some of the information missed in the transformation to opaque pointers), the overall methodology for resolving kernel parameter types is highly inefficient. The high-level strategy is to assign kernel parameter types in this order: 1. Resolving the types using builtin function calls as mangled names must contain type information or by looking up builtin definition in SPIRVBuiltins.td. Then: - Assigning the type temporarily using an intrinsic and later setting the right SPIR-V type in SPIRVGlobalRegistry after IRTranslation - Inserting a bitcast 2. Defaulting to LLVM IR types (in case of pointers the generic i8* type or types from byval/byref attributes) In case of type incompatibility (e.g. parameter defined initially as sampler_t and later used as image_t) the error will be found early on before IRTranslation (in the SPIRVEmitIntrinsics pass).
25 lines
982 B
LLVM
25 lines
982 B
LLVM
; RUN: llc -O0 -mtriple=spirv64-unknown-unknown %s -o - | FileCheck %s
|
|
|
|
; CHECK-DAG: %[[#int_32:]] = OpTypeInt 32 0
|
|
; CHECK-DAG: %[[#float:]] = OpTypeFloat 32
|
|
; CHECK-DAG: %[[#bool:]] = OpTypeBool
|
|
; CHECK-DAG: %[[#zero:]] = OpConstant %[[#int_32]] 0
|
|
; CHECK-DAG: %[[#one:]] = OpConstant %[[#int_32]] 1
|
|
; CHECK-DAG: %[[#ptr:]] = OpTypePointer CrossWorkgroup %[[#float]]
|
|
|
|
; CHECK: OpFunction
|
|
; CHECK: %[[#A:]] = OpFunctionParameter %[[#ptr]]
|
|
; CHECK: %[[#B:]] = OpFunctionParameter %[[#]]
|
|
; CHECK: %[[#cmp_res:]] = OpSGreaterThan %[[#bool]] %[[#B]] %[[#zero]]
|
|
; CHECK: %[[#select_res:]] = OpSelect %[[#int_32]] %[[#cmp_res]] %[[#one]] %[[#zero]]
|
|
; CHECK: %[[#stof_res:]] = OpConvertSToF %[[#]] %[[#select_res]]
|
|
; CHECK: OpStore %[[#A]] %[[#stof_res]]
|
|
|
|
define dso_local spir_kernel void @K(ptr addrspace(1) nocapture %A, i32 %B) local_unnamed_addr {
|
|
entry:
|
|
%cmp = icmp sgt i32 %B, 0
|
|
%conv = sitofp i1 %cmp to float
|
|
store float %conv, float addrspace(1)* %A, align 4
|
|
ret void
|
|
}
|