fb1be9b33c
This PR introduces a step after instruction selection where instructions can be traversed from the perspective of their validity from the specification point of view. The PR adds also a way to correct load/store when there is a type mismatch contradicting the specification -- an additional bitcast is inserted to keep types consistent. Correspondent test cases are added and existing test cases are corrected. This PR helps to successfully validate with the `spirv-val` tool (https://github.com/KhronosGroup/SPIRV-Tools) some output that previously led to validation errors and crashes of back translation from SPIRV to LLVM IR from the side of SPIRV Translator project (https://github.com/KhronosGroup/SPIRV-LLVM-Translator). The added step of bringing instructions to required by the specification type correspondence can be (should be and will be) extended beyond load/store instructions to ensure validity rules of other SPIRV instructions related to type inference.
22 lines
1.1 KiB
LLVM
22 lines
1.1 KiB
LLVM
; RUN: llc -O0 -mtriple=spirv64-unknown-unknown %s -o - | FileCheck %s
|
|
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv64-unknown-unknown %s -o - -filetype=obj | spirv-val %}
|
|
;; Translate SPIR-V friendly OpLoad and OpStore calls
|
|
|
|
; CHECK-DAG: %[[#TYLONG:]] = OpTypeInt 32 0
|
|
; CHECK-DAG: %[[#TYFLOAT:]] = OpTypeFloat 64
|
|
; CHECK-DAG: %[[#TYFLOATPTR:]] = OpTypePointer CrossWorkgroup %[[#TYFLOAT]]
|
|
; CHECK-DAG: %[[#CONST:]] = OpConstant %[[#TYLONG]] 42
|
|
; CHECK: OpStore %[[#PTRTOLONG:]] %[[#CONST]] Volatile|Aligned 4
|
|
; CHECK: %[[#PTRTOFLOAT:]] = OpBitcast %[[#TYFLOATPTR]] %[[#PTRTOLONG]]
|
|
; CHECK: OpLoad %[[#TYFLOAT]] %[[#PTRTOFLOAT]]
|
|
|
|
define weak_odr dso_local spir_kernel void @foo(i32 addrspace(1)* %var) {
|
|
entry:
|
|
tail call spir_func void @_Z13__spirv_StorePiiii(i32 addrspace(1)* %var, i32 42, i32 3, i32 4)
|
|
%value = tail call spir_func double @_Z12__spirv_LoadPi(i32 addrspace(1)* %var)
|
|
ret void
|
|
}
|
|
|
|
declare dso_local spir_func double @_Z12__spirv_LoadPi(i32 addrspace(1)*) local_unnamed_addr
|
|
declare dso_local spir_func void @_Z13__spirv_StorePiiii(i32 addrspace(1)*, i32, i32, i32) local_unnamed_addr
|