401f768061
`instrprof` currently does not set `__llvm_prf_vnds`'s alignment after creating it. The consequence is that the alignment is set to 16 later (c0f3ac1d00/llvm/lib/IR/DataLayout.cpp (L1019)). This can lead to undefined behaviour when we calculate `NumVNodes` in `lprofGetLoadModuleSignature` (c0f3ac1d00/compiler-rt/lib/profile/InstrProfilingMerge.c (L32)). The reason is that when the `__llvm_prf_vnds` array is 16 byte aligned, `__llvm_profile_end_vnodes() - __llvm_profile_begin_vnodes()` may not be a multiple of the size of ValueProfNode (which is 24, 20 on 32 bit targets). This patch sets `__llvm_prf_vnds`'s alignment to its ABI alignment, which always divides its size. Then `__llvm_profile_end_vnodes() - __llvm_profile_begin_vnodes()` will be a multiple of `sizeof(ValueProfNode)`. Reviewed By: w2yehia, MaskRay Differential Revision: https://reviews.llvm.org/D144302
39 lines
1.3 KiB
LLVM
39 lines
1.3 KiB
LLVM
;; Check that the prf_vnodes variable has the correct alignment
|
|
;; when pointers are 4 byte long.
|
|
; RUN: opt %s -passes=instrprof -S | FileCheck %s --check-prefix=ALIGN32
|
|
|
|
target datalayout = "e-m:e-p:32:32-p270:32:32-p271:32:32-p272:64:64-f64:32:64-f80:32-n8:16:32-S128"
|
|
target triple = "i386-unknown-linux-gnu"
|
|
|
|
@__profn_foo = private constant [3 x i8] c"foo"
|
|
@__profn_bar = private constant [3 x i8] c"bar"
|
|
|
|
define i32 @foo(ptr ) {
|
|
call void @llvm.instrprof.increment(ptr @__profn_foo, i64 12884901887, i32 1, i32 0)
|
|
%2 = ptrtoint ptr %0 to i64
|
|
call void @llvm.instrprof.value.profile(ptr @__profn_foo, i64 12884901887, i64 %2, i32 0, i32 0)
|
|
%3 = tail call i32 %0()
|
|
ret i32 %3
|
|
}
|
|
|
|
$bar = comdat any
|
|
|
|
define i32 @bar(ptr ) comdat {
|
|
entry:
|
|
call void @llvm.instrprof.increment(ptr @__profn_bar, i64 12884901887, i32 1, i32 0)
|
|
%1 = ptrtoint ptr %0 to i64
|
|
call void @llvm.instrprof.value.profile(ptr @__profn_bar, i64 12884901887, i64 %1, i32 0, i32 0)
|
|
%2 = tail call i32 %0()
|
|
ret i32 %2
|
|
}
|
|
|
|
; Function Attrs: nounwind
|
|
declare void @llvm.instrprof.increment(ptr, i64, i32, i32) #0
|
|
|
|
; Function Attrs: nounwind
|
|
declare void @llvm.instrprof.value.profile(ptr, i64, i64, i32, i32) #0
|
|
|
|
attributes #0 = { nounwind }
|
|
|
|
; ALIGN32: @__llvm_prf_vnodes = private global {{.*}} section "__llvm_prf_vnds", align 4
|