Files
clang-p2996/llvm/test/tools/llvm-objcopy/ELF/remove-section-in-segment.test
Georgii Rymar a7a447be0f [yaml2obj] - ProgramHeaders: introduce FirstSec/LastSec instead of Sections list.
Imagine we have a YAML declaration of few sections: `foo1`, `<unnamed 2>`, `foo3`, `foo4`.

To put them into segment we can do (1*):

```
Sections:
 - Section: foo1
 - Section: foo4
```

or we can use (2*):

```
Sections:
 - Section: foo1
 - Section: foo3
 - Section: foo4
```

or (3*) :

```
Sections:
 - Section: foo1
## "(index 2)" here is a name that we automatically created for a unnamed section.
 - Section: (index 2)
 - Section: foo3
 - Section: foo4
```

It looks really confusing that we don't have to list all of sections.

At first I've tried to make this rule stricter and report an error when there is a gap
(i.e. when a section is included into segment, but not listed explicitly).
This did not work perfect, because such approach conflicts with unnamed sections/fills (see (3*)).

This patch drops "Sections" key and introduces 2 keys instead: `FirstSec` and `LastSec`.
Both are optional.

Differential revision: https://reviews.llvm.org/D90458
2020-11-09 13:00:50 +03:00

47 lines
1.5 KiB
Plaintext

# Show that --remove-section removes sections in segments.
# RUN: yaml2obj %s -o %t
# Validate the offsets for the later parts of the test.
# RUN: llvm-objcopy %t %t.copy
# Skip to the start of the sections, which should be immediately after the
# program header table (i.e. sizeof(Elf64_Ehdr) + sizeof(Elf64_Phdr) == 120).
# RUN: od -t x1 -N 16 -j 120 %t.copy | FileCheck %s --check-prefix=COPY
# COPY: 11 22 33 44 55 66 77 88
# RUN: llvm-objcopy --remove-section non_alloc %t %t.nonalloc
# RUN: llvm-readelf --sections %t.nonalloc | FileCheck %s --check-prefix=NONALLOC-SHDRS
# RUN: od -t x1 -N 16 -j 120 %t.nonalloc | FileCheck %s --check-prefix=NONALLOC-BYTES
# NONALLOC-SHDRS-NOT: non_alloc
# NONALLOC-BYTES: 11 22 33 44 00 00 00 00
# RUN: llvm-objcopy --remove-section shf_alloc %t %t.alloc
# RUN: llvm-readelf --sections %t.alloc | FileCheck %s --check-prefix=ALLOC-SHDRS
# RUN: od -t x1 -N 16 -j 120 %t.alloc | FileCheck %s --check-prefix=ALLOC-BYTES
# ALLOC-SHDRS-NOT: shf_alloc
# ALLOC-BYTES: 00 00 00 00 55 66 77 88
--- !ELF
FileHeader:
Class: ELFCLASS64
Data: ELFDATA2LSB
Type: ET_EXEC
Machine: EM_X86_64
Sections:
- Name: shf_alloc
Type: SHT_PROGBITS
Flags: [SHF_ALLOC]
Content: '11223344'
- Name: non_alloc
Type: SHT_PROGBITS
Flags: []
Content: '55667788'
ProgramHeaders:
# Use an arbitrary segment type to show that the segment type is unimportant.
- Type: 0x61234567
FirstSec: shf_alloc
LastSec: non_alloc