91be3586b5
Part of https://discourse.llvm.org/t/rfc-switching-the-llvm-dialect-and-dialect-lowerings-to-opaque-pointers/68179 This patch adds the new pass option 'use-opaque-pointers' to `-launch-func-to-vulkan` instructing the pass to emit LLVM opaque pointers instead of typed pointers. Note that the pass as it was previously implemented relied on the fact LLVM pointers carried an element type. The passed used this information to deduce both the rank of a "lowered-to-llvm" MemRef as well as the element type. Since the element type when using LLVM opaque pointers is completely erased it is not possible to deduce the element type. I therefore added a new attribute that is attached to the `vulkanLaunch` call alongside the binary blob and entry point name by the `-convert-gpu-launch-to-vulkan-launch` pass. It simply attaches a type array specifying the element types of each memref. This way the `-launch-func-to-vulkan` can simply read out the element type from the attribute. The rank can still be deduced from the auto-generated C interface from `FinalizeMemRefToLLVM`. This is admittedly a bit fragile but I was not sure whether it was worth the effort to also add a rank array attribute. As a last step, the use of opaque-pointers in `mlir-vulkan-runners` codegen pipeline was also enabled, since all covnersion passes used fully support it. Differential Revision: https://reviews.llvm.org/D144460
36 lines
1.6 KiB
MLIR
36 lines
1.6 KiB
MLIR
// RUN: mlir-opt %s -convert-gpu-launch-to-vulkan-launch | FileCheck %s
|
|
|
|
// CHECK: %[[resource:.*]] = memref.alloc() : memref<12xf32>
|
|
// CHECK: %[[index:.*]] = arith.constant 1 : index
|
|
// CHECK: call @vulkanLaunch(%[[index]], %[[index]], %[[index]], %[[resource]]) {spirv_blob = "{{.*}}", spirv_element_types = [f32], spirv_entry_point = "kernel"}
|
|
|
|
module attributes {gpu.container_module} {
|
|
spirv.module Logical GLSL450 requires #spirv.vce<v1.0, [Shader], [SPV_KHR_storage_buffer_storage_class]> {
|
|
spirv.GlobalVariable @kernel_arg_0 bind(0, 0) : !spirv.ptr<!spirv.struct<(!spirv.array<12 x f32, stride=4> [0])>, StorageBuffer>
|
|
spirv.func @kernel() "None" attributes {workgroup_attributions = 0 : i64} {
|
|
%0 = spirv.mlir.addressof @kernel_arg_0 : !spirv.ptr<!spirv.struct<(!spirv.array<12 x f32, stride=4> [0])>, StorageBuffer>
|
|
%2 = spirv.Constant 0 : i32
|
|
%3 = spirv.mlir.addressof @kernel_arg_0 : !spirv.ptr<!spirv.struct<(!spirv.array<12 x f32, stride=4> [0])>, StorageBuffer>
|
|
%4 = spirv.AccessChain %0[%2, %2] : !spirv.ptr<!spirv.struct<(!spirv.array<12 x f32, stride=4> [0])>, StorageBuffer>, i32, i32
|
|
%5 = spirv.Load "StorageBuffer" %4 : f32
|
|
spirv.Return
|
|
}
|
|
spirv.EntryPoint "GLCompute" @kernel
|
|
spirv.ExecutionMode @kernel "LocalSize", 1, 1, 1
|
|
}
|
|
gpu.module @kernels {
|
|
gpu.func @kernel(%arg0: memref<12xf32>) kernel {
|
|
gpu.return
|
|
}
|
|
}
|
|
func.func @foo() {
|
|
%0 = memref.alloc() : memref<12xf32>
|
|
%c1 = arith.constant 1 : index
|
|
gpu.launch_func @kernels::@kernel
|
|
blocks in(%c1, %c1, %c1)
|
|
threads in(%c1, %c1, %c1)
|
|
args(%0 : memref<12xf32>)
|
|
return
|
|
}
|
|
}
|