Files
clang-p2996/flang/lib/Semantics/check-return.cpp
Emil Kieri 1dd8da2d7c [flang] Fix semantics check for RETURN statement
The RETURN statement is allowed in functions and subroutines, but not
in main programs. It is however a common extension, which we also
implement, to allow RETURN from main programs -- we only issue a
portability warning when -pedantic or -std=f2018 are set.

This patch fixes false positives for this portability warning, where it
was triggered also when RETURN was present in functions or subroutines.

Fixexs #55080

Reviewed By: PeteSteinfeld

Differential Revision: https://reviews.llvm.org/D124732
2022-05-02 22:04:58 +02:00

47 lines
1.8 KiB
C++

//===-- lib/Semantics/check-return.cpp ------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "check-return.h"
#include "flang/Common/Fortran-features.h"
#include "flang/Parser/message.h"
#include "flang/Parser/parse-tree.h"
#include "flang/Semantics/semantics.h"
#include "flang/Semantics/tools.h"
namespace Fortran::semantics {
static const Scope *FindContainingSubprogram(const Scope &start) {
const Scope &scope{GetProgramUnitContaining(start)};
return scope.kind() == Scope::Kind::MainProgram ||
scope.kind() == Scope::Kind::Subprogram
? &scope
: nullptr;
}
void ReturnStmtChecker::Leave(const parser::ReturnStmt &returnStmt) {
// R1542 Expression analysis validates the scalar-int-expr
// C1574 The return-stmt shall be in the inclusive scope of a function or
// subroutine subprogram.
// C1575 The scalar-int-expr is allowed only in the inclusive scope of a
// subroutine subprogram.
const auto &scope{context_.FindScope(context_.location().value())};
if (const auto *subprogramScope{FindContainingSubprogram(scope)}) {
if (returnStmt.v &&
(subprogramScope->kind() == Scope::Kind::MainProgram ||
IsFunction(*subprogramScope->GetSymbol()))) {
context_.Say(
"RETURN with expression is only allowed in SUBROUTINE subprogram"_err_en_US);
} else if (subprogramScope->kind() == Scope::Kind::MainProgram &&
context_.ShouldWarn(common::LanguageFeature::ProgramReturn)) {
context_.Say("RETURN should not appear in a main program"_port_en_US);
}
}
}
} // namespace Fortran::semantics