Files
clang-p2996/lldb/source/API/SBInstructionList.cpp
Lawrence D'Anna e7a9115680 remove FILE* bindings from SBInstruction.
Summary:
This patch replaces the FILE* python bindings for SBInstruction and
SBInstructionList and replaces them with the new, safe SBFile and FileSP
bindings.

I also re-enable `Test_Disassemble_VST1_64`, because now we can use
the file bindings as an additional test of the disassembler, and we
can use the disassembler test as a test of the file bindings.

The bugs referred to in the comments appear to have been fixed.   The
radar is closed now and the bugzilla bug does not reproduce with the
instructions given.

Reviewers: JDevlieghere, jasonmolenda, labath

Reviewed By: labath

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D68890

llvm-svn: 374820
2019-10-14 20:59:57 +00:00

235 lines
7.6 KiB
C++

//===-- SBInstructionList.cpp -----------------------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "lldb/API/SBInstructionList.h"
#include "SBReproducerPrivate.h"
#include "lldb/API/SBAddress.h"
#include "lldb/API/SBInstruction.h"
#include "lldb/API/SBStream.h"
#include "lldb/API/SBFile.h"
#include "lldb/Core/Disassembler.h"
#include "lldb/Core/Module.h"
#include "lldb/Core/StreamFile.h"
#include "lldb/Symbol/SymbolContext.h"
#include "lldb/Utility/Stream.h"
using namespace lldb;
using namespace lldb_private;
SBInstructionList::SBInstructionList() : m_opaque_sp() {
LLDB_RECORD_CONSTRUCTOR_NO_ARGS(SBInstructionList);
}
SBInstructionList::SBInstructionList(const SBInstructionList &rhs)
: m_opaque_sp(rhs.m_opaque_sp) {
LLDB_RECORD_CONSTRUCTOR(SBInstructionList, (const lldb::SBInstructionList &),
rhs);
}
const SBInstructionList &SBInstructionList::
operator=(const SBInstructionList &rhs) {
LLDB_RECORD_METHOD(
const lldb::SBInstructionList &,
SBInstructionList, operator=,(const lldb::SBInstructionList &), rhs);
if (this != &rhs)
m_opaque_sp = rhs.m_opaque_sp;
return LLDB_RECORD_RESULT(*this);
}
SBInstructionList::~SBInstructionList() {}
bool SBInstructionList::IsValid() const {
LLDB_RECORD_METHOD_CONST_NO_ARGS(bool, SBInstructionList, IsValid);
return this->operator bool();
}
SBInstructionList::operator bool() const {
LLDB_RECORD_METHOD_CONST_NO_ARGS(bool, SBInstructionList, operator bool);
return m_opaque_sp.get() != nullptr;
}
size_t SBInstructionList::GetSize() {
LLDB_RECORD_METHOD_NO_ARGS(size_t, SBInstructionList, GetSize);
if (m_opaque_sp)
return m_opaque_sp->GetInstructionList().GetSize();
return 0;
}
SBInstruction SBInstructionList::GetInstructionAtIndex(uint32_t idx) {
LLDB_RECORD_METHOD(lldb::SBInstruction, SBInstructionList,
GetInstructionAtIndex, (uint32_t), idx);
SBInstruction inst;
if (m_opaque_sp && idx < m_opaque_sp->GetInstructionList().GetSize())
inst.SetOpaque(
m_opaque_sp,
m_opaque_sp->GetInstructionList().GetInstructionAtIndex(idx));
return LLDB_RECORD_RESULT(inst);
}
size_t SBInstructionList::GetInstructionsCount(const SBAddress &start,
const SBAddress &end,
bool canSetBreakpoint) {
LLDB_RECORD_METHOD(size_t, SBInstructionList, GetInstructionsCount,
(const lldb::SBAddress &, const lldb::SBAddress &, bool),
start, end, canSetBreakpoint);
size_t num_instructions = GetSize();
size_t i = 0;
SBAddress addr;
size_t lower_index = 0;
size_t upper_index = 0;
size_t instructions_to_skip = 0;
for (i = 0; i < num_instructions; ++i) {
addr = GetInstructionAtIndex(i).GetAddress();
if (start == addr)
lower_index = i;
if (end == addr)
upper_index = i;
}
if (canSetBreakpoint)
for (i = lower_index; i <= upper_index; ++i) {
SBInstruction insn = GetInstructionAtIndex(i);
if (!insn.CanSetBreakpoint())
++instructions_to_skip;
}
return upper_index - lower_index - instructions_to_skip;
}
void SBInstructionList::Clear() {
LLDB_RECORD_METHOD_NO_ARGS(void, SBInstructionList, Clear);
m_opaque_sp.reset();
}
void SBInstructionList::AppendInstruction(SBInstruction insn) {
LLDB_RECORD_METHOD(void, SBInstructionList, AppendInstruction,
(lldb::SBInstruction), insn);
}
void SBInstructionList::SetDisassembler(const lldb::DisassemblerSP &opaque_sp) {
m_opaque_sp = opaque_sp;
}
void SBInstructionList::Print(FILE *out) {
LLDB_RECORD_METHOD(void, SBInstructionList, Print, (FILE *), out);
if (out == nullptr)
return;
StreamFile stream(out, false);
GetDescription(stream);
}
void SBInstructionList::Print(SBFile out) {
LLDB_RECORD_METHOD(void, SBInstructionList, Print, (SBFile), out);
if (!out.IsValid())
return;
StreamFile stream(out.GetFile());
GetDescription(stream);
}
void SBInstructionList::Print(FileSP out_sp) {
LLDB_RECORD_METHOD(void, SBInstructionList, Print, (FileSP), out_sp);
if (!out_sp || !out_sp->IsValid())
return;
StreamFile stream(out_sp);
GetDescription(stream);
}
bool SBInstructionList::GetDescription(lldb::SBStream &stream) {
LLDB_RECORD_METHOD(bool, SBInstructionList, GetDescription,
(lldb::SBStream &), stream);
return GetDescription(stream.ref());
}
bool SBInstructionList::GetDescription(Stream &sref) {
if (m_opaque_sp) {
size_t num_instructions = GetSize();
if (num_instructions) {
// Call the ref() to make sure a stream is created if one deesn't exist
// already inside description...
const uint32_t max_opcode_byte_size =
m_opaque_sp->GetInstructionList().GetMaxOpcocdeByteSize();
FormatEntity::Entry format;
FormatEntity::Parse("${addr}: ", format);
SymbolContext sc;
SymbolContext prev_sc;
for (size_t i = 0; i < num_instructions; ++i) {
Instruction *inst =
m_opaque_sp->GetInstructionList().GetInstructionAtIndex(i).get();
if (inst == nullptr)
break;
const Address &addr = inst->GetAddress();
prev_sc = sc;
ModuleSP module_sp(addr.GetModule());
if (module_sp) {
module_sp->ResolveSymbolContextForAddress(
addr, eSymbolContextEverything, sc);
}
inst->Dump(&sref, max_opcode_byte_size, true, false, nullptr, &sc,
&prev_sc, &format, 0);
sref.EOL();
}
return true;
}
}
return false;
}
bool SBInstructionList::DumpEmulationForAllInstructions(const char *triple) {
LLDB_RECORD_METHOD(bool, SBInstructionList, DumpEmulationForAllInstructions,
(const char *), triple);
if (m_opaque_sp) {
size_t len = GetSize();
for (size_t i = 0; i < len; ++i) {
if (!GetInstructionAtIndex((uint32_t)i).DumpEmulation(triple))
return false;
}
}
return true;
}
namespace lldb_private {
namespace repro {
template <>
void RegisterMethods<SBInstructionList>(Registry &R) {
LLDB_REGISTER_CONSTRUCTOR(SBInstructionList, ());
LLDB_REGISTER_CONSTRUCTOR(SBInstructionList,
(const lldb::SBInstructionList &));
LLDB_REGISTER_METHOD(
const lldb::SBInstructionList &,
SBInstructionList, operator=,(const lldb::SBInstructionList &));
LLDB_REGISTER_METHOD_CONST(bool, SBInstructionList, IsValid, ());
LLDB_REGISTER_METHOD_CONST(bool, SBInstructionList, operator bool, ());
LLDB_REGISTER_METHOD(size_t, SBInstructionList, GetSize, ());
LLDB_REGISTER_METHOD(lldb::SBInstruction, SBInstructionList,
GetInstructionAtIndex, (uint32_t));
LLDB_REGISTER_METHOD(
size_t, SBInstructionList, GetInstructionsCount,
(const lldb::SBAddress &, const lldb::SBAddress &, bool));
LLDB_REGISTER_METHOD(void, SBInstructionList, Clear, ());
LLDB_REGISTER_METHOD(void, SBInstructionList, AppendInstruction,
(lldb::SBInstruction));
LLDB_REGISTER_METHOD(void, SBInstructionList, Print, (FILE *));
LLDB_REGISTER_METHOD(void, SBInstructionList, Print, (SBFile));
LLDB_REGISTER_METHOD(void, SBInstructionList, Print, (FileSP));
LLDB_REGISTER_METHOD(bool, SBInstructionList, GetDescription,
(lldb::SBStream &));
LLDB_REGISTER_METHOD(bool, SBInstructionList,
DumpEmulationForAllInstructions, (const char *));
}
}
}