In a nutshell, this moves our libomptarget code to populate the offload subproject. With this commit, users need to enable the new LLVM/Offload subproject as a runtime in their cmake configuration. No further changes are expected for downstream code. Tests and other components still depend on OpenMP and have also not been renamed. The results below are for a build in which OpenMP and Offload are enabled runtimes. In addition to the pure `git mv`, we needed to adjust some CMake files. Nothing is intended to change semantics. ``` ninja check-offload ``` Works with the X86 and AMDGPU offload tests ``` ninja check-openmp ``` Still works but doesn't build offload tests anymore. ``` ls install/lib ``` Shows all expected libraries, incl. - `libomptarget.devicertl.a` - `libomptarget-nvptx-sm_90.bc` - `libomptarget.rtl.amdgpu.so` -> `libomptarget.rtl.amdgpu.so.18git` - `libomptarget.so` -> `libomptarget.so.18git` Fixes: https://github.com/llvm/llvm-project/issues/75124 --------- Co-authored-by: Saiyedul Islam <Saiyedul.Islam@amd.com>
112 lines
2.7 KiB
C
112 lines
2.7 KiB
C
// RUN: %libomptarget-compile-generic
|
|
// RUN: env HSA_XNACK=1 \
|
|
// RUN: %libomptarget-run-generic | %fcheck-generic
|
|
|
|
// REQUIRES: unified_shared_memory
|
|
// UNSUPPORTED: clang-6, clang-7, clang-8, clang-9
|
|
|
|
// Fails on nvptx with error: an illegal memory access was encountered
|
|
// XFAIL: nvptx64-nvidia-cuda
|
|
// XFAIL: nvptx64-nvidia-cuda-LTO
|
|
|
|
#include <omp.h>
|
|
#include <stdio.h>
|
|
|
|
#pragma omp requires unified_shared_memory
|
|
|
|
#define N 1024
|
|
|
|
int main(int argc, char *argv[]) {
|
|
int fails;
|
|
void *host_alloc = 0, *device_alloc = 0;
|
|
int *a = (int *)malloc(N * sizeof(int));
|
|
int dev = omp_get_default_device();
|
|
|
|
// Init
|
|
for (int i = 0; i < N; ++i) {
|
|
a[i] = 10;
|
|
}
|
|
host_alloc = &a[0];
|
|
|
|
//
|
|
// map + target no close
|
|
//
|
|
#pragma omp target data map(tofrom : a[ : N]) map(tofrom : device_alloc)
|
|
{
|
|
#pragma omp target map(tofrom : device_alloc)
|
|
{ device_alloc = &a[0]; }
|
|
}
|
|
|
|
// CHECK: a used from unified memory.
|
|
if (device_alloc == host_alloc)
|
|
printf("a used from unified memory.\n");
|
|
|
|
//
|
|
// map + target with close
|
|
//
|
|
device_alloc = 0;
|
|
#pragma omp target data map(close, tofrom : a[ : N]) map(tofrom : device_alloc)
|
|
{
|
|
#pragma omp target map(tofrom : device_alloc)
|
|
{ device_alloc = &a[0]; }
|
|
}
|
|
// CHECK: a copied to device.
|
|
if (device_alloc != host_alloc)
|
|
printf("a copied to device.\n");
|
|
|
|
//
|
|
// map + use_device_ptr no close
|
|
//
|
|
device_alloc = 0;
|
|
#pragma omp target data map(tofrom : a[ : N]) use_device_ptr(a)
|
|
{ device_alloc = &a[0]; }
|
|
|
|
// CHECK: a used from unified memory with use_device_ptr.
|
|
if (device_alloc == host_alloc)
|
|
printf("a used from unified memory with use_device_ptr.\n");
|
|
|
|
//
|
|
// map + use_device_ptr close
|
|
//
|
|
device_alloc = 0;
|
|
#pragma omp target data map(close, tofrom : a[ : N]) use_device_ptr(a)
|
|
{ device_alloc = &a[0]; }
|
|
|
|
// CHECK: a used from device memory with use_device_ptr.
|
|
if (device_alloc != host_alloc)
|
|
printf("a used from device memory with use_device_ptr.\n");
|
|
|
|
//
|
|
// map enter/exit + close
|
|
//
|
|
device_alloc = 0;
|
|
#pragma omp target enter data map(close, to : a[ : N])
|
|
|
|
#pragma omp target map(from : device_alloc)
|
|
{
|
|
device_alloc = &a[0];
|
|
a[0] = 99;
|
|
}
|
|
|
|
// 'close' is missing, so the runtime must check whether s is actually in
|
|
// shared memory in order to determine whether to transfer data and delete the
|
|
// allocation.
|
|
#pragma omp target exit data map(from : a[ : N])
|
|
|
|
// CHECK: a has been mapped to the device.
|
|
if (device_alloc != host_alloc)
|
|
printf("a has been mapped to the device.\n");
|
|
|
|
// CHECK: a[0]=99
|
|
// CHECK: a is present: 0
|
|
printf("a[0]=%d\n", a[0]);
|
|
printf("a is present: %d\n", omp_target_is_present(a, dev));
|
|
|
|
free(a);
|
|
|
|
// CHECK: Done!
|
|
printf("Done!\n");
|
|
|
|
return 0;
|
|
}
|