For
```
SECTIONS {
text.0 : {}
text.1 : {}
text.2 : {}
} INSERT AFTER .data;
```
the current order is `.data text.2 text.1 text.0`. It makes more sense to
preserve the specified order and thus improve compatibility with GNU ld.
For
```
SECTIONS { text.0 : {} } INSERT AFTER .data;
SECTIONS { text.3 : {} } INSERT AFTER .data;
```
GNU ld somehow collects sections with `INSERT AFTER .data` together (IMO
inconsistent) but I think it makes more sense to execute the commands in order
and get `.data text.3 text.0` instead.
Reviewed By: peter.smith
Differential Revision: https://reviews.llvm.org/D105158
54 lines
1.0 KiB
Plaintext
54 lines
1.0 KiB
Plaintext
# REQUIRES: x86
|
|
## Sections in an INSERT command are in a unit. Their order is preserved.
|
|
|
|
# RUN: split-file %s %t
|
|
# RUN: llvm-mc -filetype=obj -triple=x86_64 %t/a.s -o %t/a.o
|
|
# RUN: ld.lld -T %t/a.lds %t/a.o -o %t1
|
|
# RUN: llvm-readelf -S -l %t1 | FileCheck %s
|
|
|
|
# CHECK: Name
|
|
# CHECK-NEXT: NULL
|
|
# CHECK-NEXT: text.3
|
|
# CHECK-NEXT: text.4
|
|
# CHECK-NEXT: text.5
|
|
# CHECK-NEXT: .text
|
|
# CHECK-NEXT: .data
|
|
# CHECK-NEXT: text.6
|
|
# CHECK-NEXT: text.7
|
|
# CHECK-NEXT: text.8
|
|
# CHECK-NEXT: text.0
|
|
# CHECK-NEXT: text.1
|
|
# CHECK-NEXT: text.2
|
|
|
|
#--- a.lds
|
|
SECTIONS {
|
|
text.0 : {}
|
|
text.1 : {}
|
|
text.2 : {}
|
|
} INSERT AFTER .data;
|
|
|
|
SECTIONS {
|
|
text.3 : {}
|
|
text.4 : {}
|
|
text.5 : {}
|
|
} INSERT BEFORE .text;
|
|
|
|
SECTIONS {
|
|
text.6 : {}
|
|
text.7 : {}
|
|
text.8 : {}
|
|
} INSERT AFTER .data;
|
|
|
|
#--- a.s
|
|
.text; nop
|
|
.section text.0,"ax"; nop
|
|
.section text.1,"ax"; nop
|
|
.section text.2,"ax"; nop
|
|
.section text.3,"ax"; nop
|
|
.section text.4,"ax"; nop
|
|
.section text.5,"ax"; nop
|
|
.section text.6,"ax"; nop
|
|
.section text.7,"ax"; nop
|
|
.section text.8,"ax"; nop
|
|
.data; .byte 0
|