fc88d927e3
[clang][amdgpu] Use implicit code object version At present, clang always passes amdhsa-code-object-version on to -cc1. That is great for certainty over what object version is being used when debugging. Unfortunately, the command line argument is in AMDGPUBaseInfo.cpp in the amdgpu target. If clang is used with an llvm compiled with DLLVM_TARGETS_TO_BUILD that excludes amdgpu, this will be diagnosed (as discovered via D98658): - Unknown command line argument '--amdhsa-code-object-version=4' This means that clang, built only for X86, can be used to compile the nvptx devicertl for openmp but not the amdgpu one. That would shortly spawn fragile logic in the devicertl cmake to try to guess whether the clang used will work. This change omits the amdhsa-code-object-version parameter when it matches the default that AMDGPUBaseInfo.cpp specifies, with a comment to indicate why. As this is the only part of clang's codegen for amdgpu that depends on the target in the back end it suffices to build the openmp runtime on most (all?) systems. It is a non-functional change, though observable in the updated tests and when compiling with -###. It may cause minor disruption to the amd-stg-open branch. Revision of D98746, builds on refactor in D101077 Reviewed By: yaxunl Differential Revision: https://reviews.llvm.org/D101095
77 lines
3.1 KiB
Plaintext
77 lines
3.1 KiB
Plaintext
// REQUIRES: clang-driver, amdgpu-registered-target
|
|
|
|
// Check bundle ID for code object v2.
|
|
|
|
// RUN: %clang -### -target x86_64-linux-gnu \
|
|
// RUN: -mno-code-object-v3 \
|
|
// RUN: --offload-arch=gfx906 -nogpulib \
|
|
// RUN: %s 2>&1 | FileCheck -check-prefixes=V2,V2-WARN %s
|
|
|
|
// RUN: %clang -### -target x86_64-linux-gnu \
|
|
// RUN: -mcode-object-version=2 \
|
|
// RUN: --offload-arch=gfx906 -nogpulib \
|
|
// RUN: %s 2>&1 | FileCheck -check-prefix=V2 %s
|
|
|
|
// V2-WARN: warning: argument '-mno-code-object-v3' is deprecated, use '-mcode-object-version=2' instead [-Wdeprecated]
|
|
// V2: "-mllvm" "--amdhsa-code-object-version=2"
|
|
// V2: "-targets=host-x86_64-unknown-linux,hip-amdgcn-amd-amdhsa--gfx906"
|
|
|
|
// Check bundle ID for code object v3.
|
|
|
|
// RUN: %clang -### -target x86_64-linux-gnu \
|
|
// RUN: -mcode-object-v3 \
|
|
// RUN: --offload-arch=gfx906 -nogpulib \
|
|
// RUN: %s 2>&1 | FileCheck -check-prefixes=V3,V3-WARN %s
|
|
|
|
// RUN: %clang -### -target x86_64-linux-gnu \
|
|
// RUN: -mcode-object-version=3 \
|
|
// RUN: --offload-arch=gfx906 -nogpulib \
|
|
// RUN: %s 2>&1 | FileCheck -check-prefix=V3 %s
|
|
|
|
// RUN: %clang -### -target x86_64-linux-gnu \
|
|
// RUN: -mcode-object-version=4 -mcode-object-version=3 \
|
|
// RUN: --offload-arch=gfx906 -nogpulib \
|
|
// RUN: %s 2>&1 | FileCheck -check-prefix=V3 %s
|
|
|
|
// V3-WARN: warning: argument '-mcode-object-v3' is deprecated, use '-mcode-object-version=3' instead [-Wdeprecated]
|
|
// V3: "-mllvm" "--amdhsa-code-object-version=3"
|
|
// V3: "-targets=host-x86_64-unknown-linux,hip-amdgcn-amd-amdhsa--gfx906"
|
|
|
|
// Check bundle ID for code object version 4.
|
|
|
|
// RUN: %clang -### -target x86_64-linux-gnu \
|
|
// RUN: -mcode-object-version=4 \
|
|
// RUN: --offload-arch=gfx906 -nogpulib \
|
|
// RUN: %s 2>&1 | FileCheck -check-prefix=V4 %s
|
|
|
|
// V4: "-mllvm" "--amdhsa-code-object-version=4"
|
|
// V4: "-targets=host-x86_64-unknown-linux,hipv4-amdgcn-amd-amdhsa--gfx906"
|
|
|
|
// Check bundle ID for code object version default
|
|
|
|
// RUN: %clang -### -target x86_64-linux-gnu \
|
|
// RUN: --offload-arch=gfx906 -nogpulib \
|
|
// RUN: %s 2>&1 | FileCheck -check-prefix=VD %s
|
|
|
|
// VD: "-targets=host-x86_64-unknown-linux,hipv4-amdgcn-amd-amdhsa--gfx906"
|
|
|
|
// Check invalid code object version option.
|
|
|
|
// RUN: %clang -### -target x86_64-linux-gnu \
|
|
// RUN: -mcode-object-version=1 \
|
|
// RUN: --offload-arch=gfx906 -nogpulib \
|
|
// RUN: %s 2>&1 | FileCheck -check-prefix=INVALID %s
|
|
// INVALID: error: invalid integral value '1' in '-mcode-object-version=1'
|
|
// INVALID-NOT: error: invalid integral value
|
|
|
|
// Check warnings are emitted for legacy options before -mcode-object-version options.
|
|
// Check warnings are emitted only once.
|
|
|
|
// RUN: %clang -### -target x86_64-linux-gnu \
|
|
// RUN: -mno-code-object-v3 -mcode-object-v3 -mcode-object-version=4 \
|
|
// RUN: --offload-arch=gfx906 -nogpulib \
|
|
// RUN: %s 2>&1 | FileCheck -check-prefixes=WARN %s
|
|
// WARN: warning: argument '-mno-code-object-v3' is deprecated, use '-mcode-object-version=2' instead [-Wdeprecated]
|
|
// WARN: warning: argument '-mcode-object-v3' is deprecated, use '-mcode-object-version=3' instead [-Wdeprecated]
|
|
// WARN-NOT: warning: argument {{.*}} is deprecated
|