246398ece7
Summary: The parsing of GNU C extended asm statements was a little brittle and had a few issues: - It was using Parse::ParseTypeQualifierListOpt to parse the `volatile` qualifier. That parser is really meant for TypeQualifiers; an asm statement doesn't really have a type qualifier. This is still maybe nice to have, but not necessary. We now can check for the `volatile` token by properly expanding the grammer, rather than abusing Parse::ParseTypeQualifierListOpt. - The parsing of `goto` was position dependent, so `asm goto volatile` wouldn't parse. The qualifiers should be position independent to one another. Now they are. - We would warn on duplicate `volatile`, but the parse error for duplicate `goto` was a generic parse error and wasn't clear. - We need to add support for the recent GNU C extension `asm inline`. Adding support to the parser with the above issues highlighted the need for this refactoring. Link: https://gcc.gnu.org/onlinedocs/gcc/Extended-Asm.html Reviewers: aaron.ballman Reviewed By: aaron.ballman Subscribers: aheejin, jfb, nathanchance, cfe-commits, echristo, efriedma, rsmith, chandlerc, craig.topper, erichkeane, jyu2, void, srhines Tags: #clang Differential Revision: https://reviews.llvm.org/D75563
41 lines
1.3 KiB
C
41 lines
1.3 KiB
C
// RUN: %clang_cc1 -fsyntax-only -verify %s
|
|
|
|
#if !__has_extension(gnu_asm)
|
|
#error Extension 'gnu_asm' should be available by default
|
|
#endif
|
|
|
|
void f1() {
|
|
// PR7673: Some versions of GCC support an empty clobbers section.
|
|
asm ("ret" : : :);
|
|
}
|
|
|
|
void f2() {
|
|
asm("foo" : "=r" (a)); // expected-error {{use of undeclared identifier 'a'}}
|
|
asm("foo" : : "r" (b)); // expected-error {{use of undeclared identifier 'b'}}
|
|
}
|
|
|
|
void a() __asm__(""); // expected-error {{cannot use an empty string literal in 'asm'}}
|
|
void a() {
|
|
__asm__(""); // ok
|
|
}
|
|
|
|
// rdar://5952468
|
|
__asm ; // expected-error {{expected '(' after 'asm'}}
|
|
|
|
// <rdar://problem/10465079> - Don't crash on wide string literals in 'asm'.
|
|
int foo asm (L"bar"); // expected-error {{cannot use wide string literal in 'asm'}}
|
|
|
|
asm() // expected-error {{expected string literal in 'asm'}}
|
|
// expected-error@-1 {{expected ';' after top-level asm block}}
|
|
|
|
asm(; // expected-error {{expected string literal in 'asm'}}
|
|
|
|
asm("") // expected-error {{expected ';' after top-level asm block}}
|
|
|
|
// Unterminated asm strings at the end of the file were causing us to crash, so
|
|
// this needs to be last. rdar://15624081
|
|
// expected-warning@+3 {{missing terminating '"' character}}
|
|
// expected-error@+2 {{expected string literal in 'asm'}}
|
|
// expected-error@+1 {{expected ';' after top-level asm block}}
|
|
asm("
|