00809c8889
Currently version script patterns are ignored for .symver produced
non-default version (single @) symbols. This makes such symbols
not localizable by `local:`, e.g.
```
.symver foo3_v1,foo3@v1
.globl foo_v1
foo3_v1:
ld.lld --version-script=a.ver -shared a.o
```
This patch adds the support:
* Move `config->versionDefinitions[VER_NDX_LOCAL].patterns` to `config->versionDefinitions[versionId].localPatterns`
* Rename `config->versionDefinitions[versionId].patterns` to `config->versionDefinitions[versionId].nonLocalPatterns`
* Allow `findAllByVersion` to find non-default version symbols when `includeNonDefault` is true. (Note: `symtab` keys do not have `@@`)
* Make each pattern check both the unversioned `pat.name` and the versioned `${pat.name}@${v.name}`
* `localPatterns` can localize `${pat.name}@${v.name}`. `nonLocalPatterns` can prevent localization by assigning `verdefIndex` (before `parseSymbolVersion`).
---
If a user notices new `undefined symbol` errors with a version script containing
`local: *;`, the issue is likely due to a missing `global:` pattern.
Reviewed By: peter.smith
Differential Revision: https://reviews.llvm.org/D107234
30 lines
1.4 KiB
ArmAsm
30 lines
1.4 KiB
ArmAsm
# REQUIRES: x86
|
|
|
|
# RUN: echo "VERSION_1.0 { global: bar; };" > %t.script
|
|
# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
|
|
# RUN: ld.lld --version-script %t.script -shared %t.o -o /dev/null --fatal-warnings
|
|
# RUN: ld.lld --version-script %t.script -shared --undefined-version %t.o -o %t.so
|
|
# RUN: not ld.lld --version-script %t.script -shared --no-undefined-version \
|
|
# RUN: %t.o -o %t.so 2>&1 | FileCheck -check-prefix=ERR1 %s
|
|
# ERR1: version script assignment of 'VERSION_1.0' to symbol 'bar' failed: symbol not defined
|
|
|
|
# RUN: echo "VERSION_1.0 { global: und; };" > %t2.script
|
|
# RUN: not ld.lld --version-script %t2.script -shared --no-undefined-version \
|
|
# RUN: %t.o -o %t.so 2>&1 | FileCheck -check-prefix=ERR2 %s
|
|
# ERR2: version script assignment of 'VERSION_1.0' to symbol 'und' failed: symbol not defined
|
|
|
|
# RUN: echo "VERSION_1.0 { local: und; };" > %t3.script
|
|
# RUN: not ld.lld --version-script %t3.script -shared --no-undefined-version \
|
|
# RUN: %t.o -o %t.so 2>&1 | FileCheck -check-prefix=ERR3 %s
|
|
# ERR3: version script assignment of 'local' to symbol 'und' failed: symbol not defined
|
|
|
|
## Wildcard patterns do not error.
|
|
# RUN: echo "VERSION_1.0 { global: b*; local: u*; };" > %t4.script
|
|
# RUN: ld.lld --version-script %t4.script -shared --no-undefined-version --fatal-warnings %t.o -o /dev/null
|
|
|
|
.text
|
|
.globl foo
|
|
.type foo,@function
|
|
foo:
|
|
callq und@PLT
|