e28a70daf4
We prioritize non-* wildcards overs VER_NDX_LOCAL/VER_NDX_GLOBAL "*".
This patch generalizes the rule to "*" of other versions and thus fixes PR40176.
I don't feel strongly about this GNU linkers' behavior but the
generalization simplifies code.
Delete `config->defaultSymbolVersion` which was used to special case
VER_NDX_LOCAL/VER_NDX_GLOBAL "*".
In `SymbolTable::scanVersionScript`, custom versions are handled the same
way as VER_NDX_LOCAL/VER_NDX_GLOBAL. So merge
`config->versionScript{Locals,Globals}` into `config->versionDefinitions`.
Overall this seems to simplify the code.
In `SymbolTable::assign{Exact,Wildcard}Versions`,
`sym->verdefIndex == config->defaultSymbolVersion` is changed to
`verdefIndex == UINT32_C(-1)`.
This allows us to give duplicate assignment diagnostics for
`{ global: foo; };` `V1 { global: foo; };`
In test/linkerscript/version-script.s:
vs_index of an undefined symbol changes from 0 to 1. This doesn't matter (arguably 1 is better because the binding is STB_GLOBAL) because vs_index of an undefined symbol is ignored.
Reviewed By: ruiu
Differential Revision: https://reviews.llvm.org/D65716
llvm-svn: 367869
41 lines
1.8 KiB
ArmAsm
41 lines
1.8 KiB
ArmAsm
# REQUIRES: x86
|
|
# RUN: llvm-mc -filetype=obj -triple=x86_64 %s -o %t.o
|
|
# RUN: echo '{ global: foo; };' > %tg.ver
|
|
# RUN: echo '{ local: foo; };' > %tl.ver
|
|
# RUN: echo '{ global: foo; local: *; };' > %tgl.ver
|
|
# RUN: echo 'V1 { global: foo; };' > %t1.ver
|
|
# RUN: echo 'V2 { global: foo; };' > %t2.ver
|
|
# RUN: echo 'V2 { global: notexist; local: f*; };' > %t2w.ver
|
|
|
|
## Note, ld.bfd errors on these cases.
|
|
# RUN: ld.lld -shared %t.o --version-script %tl.ver --version-script %t1.ver \
|
|
# RUN: -o %t.so 2>&1 | FileCheck --check-prefix=LOCAL %s
|
|
# RUN: llvm-readelf --dyn-syms %t.so | FileCheck --check-prefix=LOCAL-SYM %s
|
|
# RUN: ld.lld -shared %t.o --version-script %tg.ver --version-script %t1.ver \
|
|
# RUN: -o %t.so 2>&1 | FileCheck --check-prefix=GLOBAL %s
|
|
# RUN: llvm-readelf --dyn-syms %t.so | FileCheck --check-prefix=GLOBAL-SYM %s
|
|
# RUN: ld.lld -shared %t.o --version-script %tgl.ver --version-script %t1.ver \
|
|
# RUN: -o %t.so 2>&1 | FileCheck --check-prefix=GLOBAL %s
|
|
# RUN: llvm-readelf --dyn-syms %t.so | FileCheck --check-prefix=GLOBAL-SYM %s
|
|
|
|
## Note, ld.bfd silently accepts this case.
|
|
# RUN: ld.lld -shared %t.o --version-script %t1.ver --version-script %t2.ver \
|
|
# RUN: -o %t.so 2>&1 | FileCheck --check-prefix=V1-WARN %s
|
|
# RUN: llvm-readelf --dyn-syms %t.so | FileCheck --check-prefix=V1-SYM %s
|
|
|
|
# RUN: ld.lld -shared %t.o --version-script %t1.ver --version-script %t2w.ver \
|
|
# RUN: -o %t.so --fatal-warnings
|
|
# RUN: llvm-readelf --dyn-syms %t.so | FileCheck --check-prefix=V1-SYM %s
|
|
|
|
# LOCAL: warning: attempt to reassign symbol 'foo' of VER_NDX_LOCAL to version 'V1'
|
|
# LOCAL-SYM-NOT: foo
|
|
|
|
# GLOBAL: warning: attempt to reassign symbol 'foo' of VER_NDX_GLOBAL to version 'V1'
|
|
# GLOBAL-SYM: foo{{$}}
|
|
|
|
# V1-WARN: warning: attempt to reassign symbol 'foo' of version 'V1' to version 'V2'
|
|
# V1-SYM: foo@@V1
|
|
|
|
.globl foo
|
|
foo:
|