00809c8889
Currently version script patterns are ignored for .symver produced
non-default version (single @) symbols. This makes such symbols
not localizable by `local:`, e.g.
```
.symver foo3_v1,foo3@v1
.globl foo_v1
foo3_v1:
ld.lld --version-script=a.ver -shared a.o
```
This patch adds the support:
* Move `config->versionDefinitions[VER_NDX_LOCAL].patterns` to `config->versionDefinitions[versionId].localPatterns`
* Rename `config->versionDefinitions[versionId].patterns` to `config->versionDefinitions[versionId].nonLocalPatterns`
* Allow `findAllByVersion` to find non-default version symbols when `includeNonDefault` is true. (Note: `symtab` keys do not have `@@`)
* Make each pattern check both the unversioned `pat.name` and the versioned `${pat.name}@${v.name}`
* `localPatterns` can localize `${pat.name}@${v.name}`. `nonLocalPatterns` can prevent localization by assigning `verdefIndex` (before `parseSymbolVersion`).
---
If a user notices new `undefined symbol` errors with a version script containing
`local: *;`, the issue is likely due to a missing `global:` pattern.
Reviewed By: peter.smith
Differential Revision: https://reviews.llvm.org/D107234
54 lines
1.9 KiB
ArmAsm
54 lines
1.9 KiB
ArmAsm
# REQUIRES: x86
|
|
## Test how .symver interacts with --version-script.
|
|
# RUN: llvm-mc -filetype=obj -triple=x86_64 %s -o %t.o
|
|
# RUN: echo 'call foo3; call foo4' > %tref.s
|
|
# RUN: llvm-mc -filetype=obj -triple=x86_64 %tref.s -o %tref.o
|
|
|
|
# RUN: echo 'v1 { local: foo1; }; v2 { local: foo2; };' > %t1.script
|
|
# RUN: ld.lld --version-script %t1.script -shared %t.o -o %t1.so
|
|
# RUN: llvm-readelf --dyn-syms %t1.so | FileCheck --check-prefix=EXACT %s
|
|
# EXACT: UND
|
|
# EXACT-NEXT: [[#]] foo4@@v2
|
|
# EXACT-NEXT: [[#]] _start{{$}}
|
|
# EXACT-NEXT: [[#]] foo3@v1
|
|
# EXACT-NOT: {{.}}
|
|
|
|
# RUN: echo 'v1 { local: foo*; }; v2 {};' > %t2.script
|
|
# RUN: ld.lld --version-script %t2.script -shared %t.o -o %t2.so
|
|
# RUN: llvm-readelf --dyn-syms %t2.so | FileCheck --check-prefix=WC %s
|
|
# WC: UND
|
|
# WC-NEXT: [[#]] foo4@@v2
|
|
# WC-NEXT: [[#]] _start{{$}}
|
|
# WC-NOT: {{.}}
|
|
|
|
# RUN: echo 'v1 { global: *; local: foo*; }; v2 {};' > %t3.script
|
|
# RUN: ld.lld --version-script %t3.script -shared %t.o -o %t3.so
|
|
# RUN: llvm-readelf --dyn-syms %t3.so | FileCheck --check-prefix=MIX1 %s
|
|
# MIX1: UND
|
|
# MIX1-NEXT: [[#]] foo4@@v2
|
|
# MIX1-NEXT: [[#]] _start@@v1
|
|
# MIX1-NOT: {{.}}
|
|
|
|
# RUN: echo 'v1 { global: foo*; local: *; }; v2 { global: foo4; local: *; };' > %t4.script
|
|
# RUN: ld.lld --version-script %t4.script -shared %t.o -o %t4.so
|
|
# RUN: llvm-readelf --dyn-syms %t4.so | FileCheck --check-prefix=MIX2 %s
|
|
# MIX2: UND
|
|
# MIX2-NEXT: [[#]] foo1@@v1
|
|
# MIX2-NEXT: [[#]] foo2@@v1
|
|
# MIX2-NEXT: [[#]] foo4@@v2
|
|
# MIX2-NEXT: [[#]] foo3@v1
|
|
# MIX2-NOT: {{.}}
|
|
|
|
# RUN: ld.lld --version-script %t4.script -shared %t.o %tref.o -o %t5.so
|
|
# RUN: llvm-readelf -r %t5.so | FileCheck --check-prefix=RELOC %s
|
|
|
|
# RELOC: R_X86_64_JUMP_SLOT {{.*}} foo3@v1 + 0
|
|
# RELOC: R_X86_64_JUMP_SLOT {{.*}} foo4@@v2 + 0
|
|
|
|
.globl foo1; foo1: ret
|
|
.globl foo2; foo2: ret
|
|
.globl foo3; .symver foo3,foo3@v1; foo3: ret
|
|
.globl foo4; .symver foo4,foo4@@v2; foo4: ret
|
|
|
|
.globl _start; _start: ret
|