aaf68cd9ce
Summary: Sometimes users think that setting a function regex for all function that contain the word 'needle' in their name looks like this: `*needle*`. However, LLDB only searches the function name and doesn't fully match it against the regex, so the leading and trailing '*' operators don't do anything and actually just cause the regex engine to reject the regular expression with "repetition-operator operand invalid". This patch makes this a bit more obvious to the user by printing a warning that a leading '*' before this regular expression here doesn't have any purpose (and will cause an error). This doesn't attempt to detect a case where there is only a trailing '*' as that would involve parsing the regex and it seems the most common way to end up in this situation is by doing `rbreak *needle*`. Reviewers: JDevlieghere Reviewed By: JDevlieghere Differential Revision: https://reviews.llvm.org/D78809
31 lines
1.7 KiB
Python
31 lines
1.7 KiB
Python
import lldb
|
|
from lldbsuite.test.decorators import *
|
|
from lldbsuite.test.lldbtest import *
|
|
from lldbsuite.test import lldbutil
|
|
|
|
class TestCase(TestBase):
|
|
|
|
mydir = TestBase.compute_mydir(__file__)
|
|
|
|
@no_debug_info_test
|
|
def test_error(self):
|
|
self.expect("breakpoint set --func-regex (", error=True,
|
|
substrs=["error: Function name regular expression could " +
|
|
"not be compiled: parentheses not balanced"])
|
|
|
|
# Point out if looks like the user provided a globbing expression.
|
|
self.expect("breakpoint set --func-regex *a", error=True,
|
|
substrs=["error: Function name regular expression could " +
|
|
"not be compiled: repetition-operator operand invalid",
|
|
"warning: Function name regex does not accept glob patterns."])
|
|
self.expect("breakpoint set --func-regex ?a", error=True,
|
|
substrs=["error: Function name regular expression could " +
|
|
"not be compiled: repetition-operator operand invalid",
|
|
"warning: Function name regex does not accept glob patterns."])
|
|
# Make sure that warning is only shown for invalid regular expressions
|
|
# that look like a globbing expression (i.e., they have a leading * or ?).
|
|
self.expect("breakpoint set --func-regex a*+", error=True, matching=False,
|
|
substrs=["warning: Function name regex does not accept glob patterns."])
|
|
self.expect("breakpoint set --func-regex a?+", error=True, matching=False,
|
|
substrs=["warning: Function name regex does not accept glob patterns."])
|