54c2687292
At the moment nearly every test calls something similar to
`self.dbg.CreateTarget(self.getBuildArtifact("a.out"))` and them sometimes
checks if the created target is actually valid with something like
`self.assertTrue(target.IsValid(), "some useless text")`.
Beside being really verbose the error messages generated by this pattern are
always just indicating that the target failed to be created but now why.
This patch introduces a helper function `createTestTarget` to our Test class
that creates the target with the much more verbose `CreateTarget` overload that
gives us back an SBError (with a fancy error). If the target couldn't be created
the function prints out the SBError that LLDB returned and asserts for us. It
also defaults to the "a.out" build artifact path that nearly all tests are using
to avoid to hardcode "a.out" in every test.
I converted a bunch of tests to the new function but I'll do the rest of the
test suite as follow ups.
Reviewed By: JDevlieghere
Differential Revision: https://reviews.llvm.org/D102771
54 lines
1.8 KiB
Python
54 lines
1.8 KiB
Python
"""
|
|
Test that expr will time out and allow other threads to run if it blocks.
|
|
"""
|
|
|
|
from __future__ import print_function
|
|
|
|
|
|
import lldb
|
|
from lldbsuite.test.decorators import *
|
|
from lldbsuite.test.lldbtest import *
|
|
from lldbsuite.test import lldbutil
|
|
|
|
|
|
class ExprDoesntDeadlockTestCase(TestBase):
|
|
|
|
mydir = TestBase.compute_mydir(__file__)
|
|
|
|
@add_test_categories(["basic_process"])
|
|
@skipIfReproducer # Timeouts are not currently modeled.
|
|
def test_with_run_command(self):
|
|
"""Test that expr will time out and allow other threads to run if it blocks."""
|
|
self.build()
|
|
target = self.createTestTarget()
|
|
|
|
# Now create a breakpoint at source line before call_me_to_get_lock
|
|
# gets called.
|
|
|
|
main_file_spec = lldb.SBFileSpec("locking.cpp")
|
|
breakpoint = target.BreakpointCreateBySourceRegex(
|
|
'Break here', main_file_spec)
|
|
if self.TraceOn():
|
|
print("breakpoint:", breakpoint)
|
|
self.assertTrue(breakpoint and
|
|
breakpoint.GetNumLocations() == 1,
|
|
VALID_BREAKPOINT)
|
|
|
|
# Now launch the process, and do not stop at entry point.
|
|
process = target.LaunchSimple(
|
|
None, None, self.get_process_working_directory())
|
|
self.assertTrue(process, PROCESS_IS_VALID)
|
|
|
|
# Frame #0 should be on self.line1 and the break condition should hold.
|
|
from lldbsuite.test.lldbutil import get_stopped_thread
|
|
thread = get_stopped_thread(process, lldb.eStopReasonBreakpoint)
|
|
self.assertTrue(
|
|
thread.IsValid(),
|
|
"There should be a thread stopped due to breakpoint condition")
|
|
|
|
frame0 = thread.GetFrameAtIndex(0)
|
|
|
|
var = frame0.EvaluateExpression("call_me_to_get_lock(get_int())")
|
|
self.assertTrue(var.IsValid())
|
|
self.assertEqual(var.GetValueAsSigned(0), 567)
|