db5e078690
In PGO, a C++ external linkage function `foo` has a private counter `__profc_foo` and a private `__profd_foo` in a `comdat nodeduplicate`. A `__attribute__((weak))` function `foo` has a weak hidden counter `__profc_foo` and a private `__profd_foo` in a `comdat nodeduplicate`. In `ld.lld a.o b.o`, say a.o defines an external linkage `foo` and b.o defines a weak `foo`. Currently we treat `comdat nodeduplicate` as `comdat any`, ld.lld will incorrectly consider `b.o:__profc_foo` non-prevailing. In the worst case when `b.o:__profd_foo` is retained and `b.o:__profc_foo` isn't, there will be dangling reference causing an `undefined hidden symbol` error. Add SelectionKind to `Comdat` in IRSymtab and let linkers ignore nodeduplicate comdat. Differential Revision: https://reviews.llvm.org/D106228
76 lines
1.5 KiB
LLVM
76 lines
1.5 KiB
LLVM
; RUN: llvm-as -o %t %s
|
|
; RUN: llvm-lto2 dump-symtab %t | FileCheck %s
|
|
|
|
; CHECK: target triple: i686-pc-windows-msvc18.0.0
|
|
target triple = "i686-pc-windows-msvc18.0.0"
|
|
target datalayout = "e-m:x-p:32:32-i64:64-f80:32-n8:16:32-a:0:32-S32"
|
|
|
|
; CHECK: source filename: src.c
|
|
source_filename = "src.c"
|
|
|
|
; CHECK: linker opts: /include:foo
|
|
!0 = !{!"/include:foo"}
|
|
!llvm.linker.options = !{ !0 }
|
|
|
|
; CHECK: D------X _fun
|
|
define i32 @fun() {
|
|
ret i32 0
|
|
}
|
|
|
|
; CHECK: D------X @fun2@8
|
|
; CHECK-NEXT: comdat any @fun2@8
|
|
$fun2 = comdat any
|
|
define x86_fastcallcc i32 @fun2(i32 inreg %a, i32 inreg %b) comdat {
|
|
entry:
|
|
%add = add nsw i32 %b, %a
|
|
ret i32 %add
|
|
}
|
|
|
|
; CHECK: H------- _g1
|
|
@g1 = hidden global i32 0
|
|
|
|
; CHECK: P------- _g2
|
|
@g2 = protected global i32 0
|
|
|
|
; CHECK: D------- _g3
|
|
@g3 = global i32 0
|
|
|
|
; CHECK: DU------ _g4
|
|
@g4 = external global i32
|
|
|
|
; CHECK: D--W---- _g5
|
|
@g5 = weak global i32 0
|
|
|
|
; CHECK: D--W-O-- _g6
|
|
@g6 = linkonce_odr unnamed_addr global i32 0
|
|
|
|
; CHECK: D-----T- _g7
|
|
@g7 = thread_local global i32 0
|
|
|
|
; CHECK: D-C----- _g8
|
|
; CHECK-NEXT: size 4 align 8
|
|
@g8 = common global i32 0, align 8
|
|
|
|
; CHECK: D------- _g9
|
|
; CHECK-NEXT: comdat any _g9
|
|
$g9 = comdat any
|
|
@g9 = global i32 0, comdat
|
|
|
|
; CHECK-NOT: _g10
|
|
$g10 = comdat any
|
|
@g10 = internal global i32 0, comdat
|
|
|
|
; CHECK: D------- _g11
|
|
; CHECK-NOT: comdat
|
|
@g11 = global i32 0, comdat($g10)
|
|
|
|
; CHECK: D------- _g12
|
|
; CHECK-NEXT: comdat nodeduplicate _g12
|
|
$g12 = comdat nodeduplicate
|
|
@g12 = global i32 0, comdat
|
|
|
|
; CHECK: D--WI--- _a1
|
|
; CHECK-NEXT: comdat any _g9
|
|
; CHECK-NEXT: fallback _g9
|
|
@a1 = weak alias i32, i32* @g9
|