0628bea513
This broke Chromium's PGO build, it seems because hot-cold-splitting got turned
on unintentionally. See comment on the code review for repro etc.
> This patch adds -f[no-]split-cold-code CC1 options to clang. This allows
> the splitting pass to be toggled on/off. The current method of passing
> `-mllvm -hot-cold-split=true` to clang isn't ideal as it may not compose
> correctly (say, with `-O0` or `-Oz`).
>
> To implement the -fsplit-cold-code option, an attribute is applied to
> functions to indicate that they may be considered for splitting. This
> removes some complexity from the old/new PM pipeline builders, and
> behaves as expected when LTO is enabled.
>
> Co-authored by: Saleem Abdulrasool <compnerd@compnerd.org>
> Differential Revision: https://reviews.llvm.org/D57265
> Reviewed By: Aditya Kumar, Vedant Kumar
> Reviewers: Teresa Johnson, Aditya Kumar, Fedor Sergeev, Philip Pfaffe, Vedant Kumar
This reverts commit 273c299d5d.
35 lines
826 B
LLVM
35 lines
826 B
LLVM
; RUN: opt -S -hotcoldsplit -hotcoldsplit-threshold=0 < %s | FileCheck %s
|
|
|
|
target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128"
|
|
target triple = "x86_64-apple-macosx10.14.0"
|
|
|
|
; CHECK-LABEL: define {{.*}}@foo(
|
|
; CHECK: phi i32 [ 0, %entry ], [ %p.ce.reload, %codeRepl ]
|
|
|
|
; CHECK-LABEL: define {{.*}}@foo.cold.1(
|
|
; CHECK: call {{.*}}@sink
|
|
; CHECK: %p.ce = phi i32 [ 1, %coldbb ], [ 3, %coldbb2 ]
|
|
; CHECK-NEXT: store i32 %p.ce, i32* %p.ce.out
|
|
|
|
define void @foo(i32 %cond) {
|
|
entry:
|
|
%tobool = icmp eq i32 %cond, 0
|
|
br i1 %tobool, label %if.end, label %coldbb
|
|
|
|
coldbb:
|
|
call void @sink()
|
|
call void @sideeffect()
|
|
br i1 undef, label %if.end, label %coldbb2
|
|
|
|
coldbb2:
|
|
br label %if.end
|
|
|
|
if.end:
|
|
%p = phi i32 [0, %entry], [1, %coldbb], [3, %coldbb2]
|
|
ret void
|
|
}
|
|
|
|
declare void @sink() cold
|
|
|
|
declare void @sideeffect()
|