7a6c89427c
When sampleFDO is enabled, people may expect they can use -fno-profile-sample-use to opt-out using sample profile for a certain file. That could be either for debugging purpose or for performance tuning purpose. However, when thinlto is enabled, if a function in file A compiled with -fno-profile-sample-use is imported to another file B compiled with -fprofile-sample-use, the inlined copy of the function in file B may still get its profile annotated. The inconsistency may even introduce profile unused warning because if the target is not compiled with explicit debug information flag, the function in file A won't have its debug information enabled (debug information will be enabled implicitly only when -fprofile-sample-use is used). After it is imported into file B which is compiled with -fprofile-sample-use, profile annotation for the outline copy of the function will fail because the function has no debug information, and that will trigger profile unused warning. We add a new attribute use-sample-profile to control whether a function will use its sample profile no matter for its outline or inline copies. That will make the behavior of -fno-profile-sample-use consistent. Differential Revision: https://reviews.llvm.org/D79959
75 lines
2.8 KiB
LLVM
75 lines
2.8 KiB
LLVM
; Make sure Import GUID list for ThinLTO properly maintained while update function's entry count for inlining
|
|
|
|
; RUN: opt < %s -passes='thinlto-pre-link<O2>' -pgo-kind=pgo-sample-use-pipeline -sample-profile-file=%S/Inputs/inline-callee-update.prof -S | FileCheck %s
|
|
|
|
@y = global i32* ()* null, align 8
|
|
@z = global i32* ()* null, align 8
|
|
|
|
; CHECK: define i32* @sample_loader_inlinee() {{.*}} !prof ![[ENTRY:[0-9]+]]
|
|
define i32* @sample_loader_inlinee() #0 !dbg !3 {
|
|
bb:
|
|
%tmp = call i32* @direct_leaf_func(i32* null), !dbg !4
|
|
%cmp = icmp ne i32* %tmp, null
|
|
br i1 %cmp, label %then, label %else
|
|
|
|
then: ; preds = %bb
|
|
%tmp1 = load i32* ()*, i32* ()** @z, align 8, !dbg !5
|
|
%tmp2 = call i32* %tmp1(), !dbg !5
|
|
ret i32* %tmp2
|
|
|
|
else: ; preds = %bb
|
|
ret i32* null
|
|
}
|
|
|
|
; CHECK: define i32* @cgscc_inlinee() {{.*}} !prof ![[ENTRY:[0-9]+]]
|
|
define i32* @cgscc_inlinee() #0 !dbg !6 {
|
|
bb:
|
|
%tmp = call i32* @direct_leaf_func(i32* null), !dbg !7
|
|
%cmp = icmp ne i32* %tmp, null
|
|
br i1 %cmp, label %then, label %else
|
|
|
|
then: ; preds = %bb
|
|
%tmp1 = load i32* ()*, i32* ()** @y, align 8, !dbg !8
|
|
%tmp2 = call i32* %tmp1(), !dbg !8
|
|
ret i32* %tmp2
|
|
|
|
else: ; preds = %bb
|
|
ret i32* null
|
|
}
|
|
|
|
define i32* @test_sample_loader_inline(void ()* %arg) #0 !dbg !9 {
|
|
bb:
|
|
%tmp = call i32* @sample_loader_inlinee(), !dbg !10
|
|
ret i32* %tmp
|
|
}
|
|
|
|
define i32* @test_cgscc_inline(void ()* %arg) #0 !dbg !11 {
|
|
bb:
|
|
%tmp = call i32* @cgscc_inlinee(), !dbg !12
|
|
ret i32* %tmp
|
|
}
|
|
|
|
declare i32* @direct_leaf_func(i32*)
|
|
|
|
attributes #0 = {"use-sample-profile"}
|
|
|
|
!llvm.dbg.cu = !{!0}
|
|
!llvm.module.flags = !{!2}
|
|
|
|
!0 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus, file: !1, isOptimized: false, runtimeVersion: 0, emissionKind: NoDebug)
|
|
!1 = !DIFile(filename: "test.cc", directory: "/")
|
|
!2 = !{i32 2, !"Debug Info Version", i32 3}
|
|
!3 = distinct !DISubprogram(name: "sample_loader_inlinee", scope: !1, file: !1, line: 11, spFlags: DISPFlagDefinition, unit: !0)
|
|
!4 = !DILocation(line: 12, scope: !3)
|
|
!5 = !DILocation(line: 13, scope: !3)
|
|
!6 = distinct !DISubprogram(name: "cgscc_inlinee", scope: !1, file: !1, line: 31, spFlags: DISPFlagDefinition, unit: !0)
|
|
!7 = !DILocation(line: 32, scope: !6)
|
|
!8 = !DILocation(line: 33, scope: !6)
|
|
!9 = distinct !DISubprogram(name: "test_sample_loader_inline", scope: !1, file: !1, line: 3, spFlags: DISPFlagDefinition, unit: !0)
|
|
!10 = !DILocation(line: 4, scope: !9)
|
|
!11 = distinct !DISubprogram(name: "test_cgscc_inline", scope: !1, file: !1, line: 20, spFlags: DISPFlagDefinition, unit: !0)
|
|
!12 = !DILocation(line: 21, scope: !11)
|
|
|
|
; Make sure the ImportGUID stays with entry count metadata for ThinLTO-PreLink
|
|
; CHECK: ![[ENTRY]] = !{!"function_entry_count", i64 1, i64 -9171813444624716006}
|