7a6c89427c
When sampleFDO is enabled, people may expect they can use -fno-profile-sample-use to opt-out using sample profile for a certain file. That could be either for debugging purpose or for performance tuning purpose. However, when thinlto is enabled, if a function in file A compiled with -fno-profile-sample-use is imported to another file B compiled with -fprofile-sample-use, the inlined copy of the function in file B may still get its profile annotated. The inconsistency may even introduce profile unused warning because if the target is not compiled with explicit debug information flag, the function in file A won't have its debug information enabled (debug information will be enabled implicitly only when -fprofile-sample-use is used). After it is imported into file B which is compiled with -fprofile-sample-use, profile annotation for the outline copy of the function will fail because the function has no debug information, and that will trigger profile unused warning. We add a new attribute use-sample-profile to control whether a function will use its sample profile no matter for its outline or inline copies. That will make the behavior of -fno-profile-sample-use consistent. Differential Revision: https://reviews.llvm.org/D79959
33 lines
1.0 KiB
LLVM
33 lines
1.0 KiB
LLVM
; For SamplePGO, if -profile-sample-accurate is specified, cold callsite
|
|
; heuristics should be honored if the caller has no profile.
|
|
|
|
; RUN: opt < %s -sample-profile -sample-profile-file=%S/Inputs/inline.prof -inline -S -inline-cold-callsite-threshold=0 | FileCheck %s
|
|
; RUN: opt < %s -sample-profile -sample-profile-file=%S/Inputs/inline.prof -profile-sample-accurate -inline -S -inline-cold-callsite-threshold=0 | FileCheck %s --check-prefix ACCURATE
|
|
|
|
declare void @extern()
|
|
define void @callee() #1 {
|
|
call void @extern()
|
|
ret void
|
|
}
|
|
|
|
define void @caller(i32 %y1) #1 {
|
|
; CHECK-LABEL: @caller
|
|
; CHECK-NOT: call void @callee
|
|
; ACCURATE-LABEL: @caller
|
|
; ACCURATE: call void @callee
|
|
call void @callee()
|
|
ret void
|
|
}
|
|
|
|
define void @caller_accurate(i32 %y1) #0 {
|
|
; CHECK-LABEL: @caller_accurate
|
|
; CHECK: call void @callee
|
|
; ACCURATE-LABEL: @caller_accurate
|
|
; ACCURATE: call void @callee
|
|
call void @callee()
|
|
ret void
|
|
}
|
|
|
|
attributes #0 = { "profile-sample-accurate" "use-sample-profile" }
|
|
attributes #1 = { "use-sample-profile" }
|