caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
f3a47b9e25e7aca0dc2cd2dec30cedd9aeffaecf
clang-p2996/lldb/test/API/commands/statistics/basic/TestStats.py
royitaqi f65a52ab0e In statistics dump --summary, add back the targets section (#97004) 
# Change

https://github.com/llvm/llvm-project/pull/95075 accidentally removed the
`targets` section from `statistics dump --summary`. Adding it back, by
setting the default value to `true` in
`StatisticsOptions::GetIncludeTargets()`.

Updated the description for the options.
Updated tests.


# Verification

Manually verified the fix by running `statist dump --summary` and
comparing three versions of LLDB (in commit order):
1. Before https://github.com/llvm/llvm-project/pull/95075
2. After https://github.com/llvm/llvm-project/pull/95075
3. After this fix

The expected result is that 1 and 3 give the same sections, while 2 is
missing the `targets` section when in summary mode. The output (see
Appendix) matches the expectation.


# Appendix: Manual Test Output

## `statistics dump --summary` of 1

```
(lldb) statistics dump --summary
{
  "memory": {
    "strings": {
      "bytesTotal": 724992,
      "bytesUnused": 714547,
      "bytesUsed": 10445
    }
  },
  "targets": [
    {
      "sourceMapDeduceCount": 0,
      "totalSharedLibraryEventHitCount": 0
    }
  ],
  "totalDebugInfoByteSize": 597,
  "totalDebugInfoEnabled": 1,
  "totalDebugInfoIndexLoadedFromCache": 0,
  "totalDebugInfoIndexSavedToCache": 0,
  "totalDebugInfoIndexTime": 0.00070699999999999995,
  "totalDebugInfoParseTime": 2.5999999999999998e-05,
  "totalModuleCount": 1,
  "totalModuleCountHasDebugInfo": 1,
  "totalModuleCountWithIncompleteTypes": 0,
  "totalModuleCountWithVariableErrors": 0,
  "totalSymbolTableIndexTime": 0.000223,
  "totalSymbolTableParseTime": 0.00025799999999999998,
  "totalSymbolTableStripped": 0,
  "totalSymbolTablesLoadedFromCache": 0,
  "totalSymbolTablesSavedToCache": 0
}
(lldb)
```

## `statistics dump --summary` of 3

Should be the same as above.

```
(lldb) statistics dump --summary
{
  "memory": {
    "strings": {
      "bytesTotal": 516096,
      "bytesUnused": 510353,
      "bytesUsed": 5743
    }
  },
  "targets": [
    {
      "sourceMapDeduceCount": 0,
      "totalSharedLibraryEventHitCount": 0
    }
  ],
  "totalDebugInfoByteSize": 597,
  "totalDebugInfoEnabled": 1,
  "totalDebugInfoIndexLoadedFromCache": 0,
  "totalDebugInfoIndexSavedToCache": 0,
  "totalDebugInfoIndexTime": 0.0022139999999999998,
  "totalDebugInfoParseTime": 0.00031700000000000001,
  "totalModuleCount": 1,
  "totalModuleCountHasDebugInfo": 1,
  "totalModuleCountWithIncompleteTypes": 0,
  "totalModuleCountWithVariableErrors": 0,
  "totalSymbolTableIndexTime": 0.0014499999999999999,
  "totalSymbolTableParseTime": 0.001848,
  "totalSymbolTableStripped": 0,
  "totalSymbolTablesLoadedFromCache": 0,
  "totalSymbolTablesSavedToCache": 0
}
(lldb)
```

## `statistics dump --summary` of 2

Should be missing the `targets` section.

```
(lldb) statistics dump --summary
{
  "memory": {
    "strings": {
      "bytesTotal": 716800,
      "bytesUnused": 705887,
      "bytesUsed": 10913
    }
  },
  "totalDebugInfoByteSize": 597,
  "totalDebugInfoEnabled": 1,
  "totalDebugInfoIndexLoadedFromCache": 0,
  "totalDebugInfoIndexSavedToCache": 0,
  "totalDebugInfoIndexTime": 0.001374,
  "totalDebugInfoParseTime": 0.000174,
  "totalModuleCount": 1,
  "totalModuleCountHasDebugInfo": 1,
  "totalModuleCountWithIncompleteTypes": 0,
  "totalModuleCountWithVariableErrors": 0,
  "totalSymbolTableIndexTime": 0.00068300000000000001,
  "totalSymbolTableParseTime": 0.0010139999999999999,
  "totalSymbolTableStripped": 0,
  "totalSymbolTablesLoadedFromCache": 0,
  "totalSymbolTablesSavedToCache": 0
}
(lldb)
```

Co-authored-by: royshi <royshi@meta.com>
2024-06-28 12:13:13 -04:00

921 lines
36 KiB
Python
Raw Blame History

import lldb
import json
import os
import re
from lldbsuite.test.decorators import *
from lldbsuite.test.lldbtest import *
from lldbsuite.test import lldbutil
class TestCase(TestBase):
NO_DEBUG_INFO_TESTCASE = True
def test_enable_disable(self):
"""
Test "statistics disable" and "statistics enable". These don't do
anything anymore for cheap to gather statistics. In the future if
statistics are expensive to gather, we can enable the feature inside
of LLDB and test that enabling and disabling stops expesive information
from being gathered.
"""
self.build()
target = self.createTestTarget()
self.expect(
"statistics disable",
substrs=["need to enable statistics before disabling"],
error=True,
)
self.expect("statistics enable")
self.expect("statistics enable", substrs=["already enabled"], error=True)
self.expect("statistics disable")
self.expect(
"statistics disable",
substrs=["need to enable statistics before disabling"],
error=True,
)
def verify_key_in_dict(self, key, d, description):
self.assertIn(
key, d, 'make sure key "%s" is in dictionary %s' % (key, description)
)
def verify_key_not_in_dict(self, key, d, description):
self.assertNotIn(
key, d, 'make sure key "%s" is in dictionary %s' % (key, description)
)
def verify_keys(self, dict, description, keys_exist, keys_missing=None):
"""
Verify that all keys in "keys_exist" list are top level items in
"dict", and that all keys in "keys_missing" do not exist as top
level items in "dict".
"""
if keys_exist:
for key in keys_exist:
self.verify_key_in_dict(key, dict, description)
if keys_missing:
for key in keys_missing:
self.verify_key_not_in_dict(key, dict, description)
def verify_success_fail_count(self, stats, key, num_successes, num_fails):
self.verify_key_in_dict(key, stats, 'stats["%s"]' % (key))
success_fail_dict = stats[key]
self.assertEqual(
success_fail_dict["successes"], num_successes, "make sure success count"
)
self.assertEqual(
success_fail_dict["failures"], num_fails, "make sure success count"
)
def get_target_stats(self, debug_stats):
if "targets" in debug_stats:
return debug_stats["targets"][0]
return None
def get_command_stats(self, debug_stats):
if "commands" in debug_stats:
return debug_stats["commands"]
return None
def test_expressions_frame_var_counts(self):
self.build()
lldbutil.run_to_source_breakpoint(
self, "// break here", lldb.SBFileSpec("main.c")
)
self.expect("expr patatino", substrs=["27"])
stats = self.get_target_stats(self.get_stats())
self.verify_success_fail_count(stats, "expressionEvaluation", 1, 0)
self.expect(
"expr doesnt_exist",
error=True,
substrs=["undeclared identifier 'doesnt_exist'"],
)
# Doesn't successfully execute.
self.expect("expr int *i = nullptr; *i", error=True)
# Interpret an integer as an array with 3 elements is a failure for
# the "expr" command, but the expression evaluation will succeed and
# be counted as a success even though the "expr" options will for the
# command to fail. It is more important to track expression evaluation
# from all sources instead of just through the command, so this was
# changed. If we want to track command success and fails, we can do
# so using another metric.
self.expect(
"expr -Z 3 -- 1",
error=True,
substrs=["expression cannot be used with --element-count"],
)
# We should have gotten 3 new failures and the previous success.
stats = self.get_target_stats(self.get_stats())
self.verify_success_fail_count(stats, "expressionEvaluation", 2, 2)
self.expect("statistics enable")
# 'frame var' with enabled statistics will change stats.
self.expect("frame var", substrs=["27"])
stats = self.get_target_stats(self.get_stats())
self.verify_success_fail_count(stats, "frameVariable", 1, 0)
# Test that "stopCount" is available when the process has run
self.assertIn("stopCount", stats, 'ensure "stopCount" is in target JSON')
self.assertGreater(
stats["stopCount"], 0, 'make sure "stopCount" is greater than zero'
)
def test_default_no_run(self):
"""Test "statistics dump" without running the target.
When we don't run the target, we expect to not see any 'firstStopTime'
or 'launchOrAttachTime' top level keys that measure the launch or
attach of the target.
Output expected to be something like:
(lldb) statistics dump
{
"memory" : {...},
"modules" : [...],
"targets" : [
{
"targetCreateTime": 0.26566899599999999,
"expressionEvaluation": {
"failures": 0,
"successes": 0
},
"frameVariable": {
"failures": 0,
"successes": 0
},
"moduleIdentifiers": [...],
}
],
"totalDebugInfoByteSize": 182522234,
"totalDebugInfoIndexTime": 2.33343,
"totalDebugInfoParseTime": 8.2121400240000071,
"totalSymbolTableParseTime": 0.123,
"totalSymbolTableIndexTime": 0.234,
}
"""
self.build()
target = self.createTestTarget()
debug_stats = self.get_stats()
debug_stat_keys = [
"memory",
"modules",
"targets",
"totalSymbolTableParseTime",
"totalSymbolTableIndexTime",
"totalSymbolTablesLoadedFromCache",
"totalSymbolTablesSavedToCache",
"totalDebugInfoByteSize",
"totalDebugInfoIndexTime",
"totalDebugInfoIndexLoadedFromCache",
"totalDebugInfoIndexSavedToCache",
"totalDebugInfoParseTime",
]
self.verify_keys(debug_stats, '"debug_stats"', debug_stat_keys, None)
stats = debug_stats["targets"][0]
keys_exist = [
"expressionEvaluation",
"frameVariable",
"moduleIdentifiers",
"targetCreateTime",
]
keys_missing = ["firstStopTime", "launchOrAttachTime"]
self.verify_keys(stats, '"stats"', keys_exist, keys_missing)
self.assertGreater(stats["targetCreateTime"], 0.0)
def test_default_with_run(self):
"""Test "statistics dump" when running the target to a breakpoint.
When we run the target, we expect to see 'launchOrAttachTime' and
'firstStopTime' top level keys.
Output expected to be something like:
(lldb) statistics dump
{
"memory" : {...},
"modules" : [...],
"targets" : [
{
"firstStopTime": 0.34164492800000001,
"launchOrAttachTime": 0.31969605400000001,
"moduleIdentifiers": [...],
"targetCreateTime": 0.0040863039999999998
"expressionEvaluation": {
"failures": 0,
"successes": 0
},
"frameVariable": {
"failures": 0,
"successes": 0
},
}
],
"totalDebugInfoByteSize": 182522234,
"totalDebugInfoIndexTime": 2.33343,
"totalDebugInfoParseTime": 8.2121400240000071,
"totalSymbolTableParseTime": 0.123,
"totalSymbolTableIndexTime": 0.234,
}
"""
self.build()
target = self.createTestTarget()
lldbutil.run_to_source_breakpoint(
self, "// break here", lldb.SBFileSpec("main.c")
)
debug_stats = self.get_stats()
debug_stat_keys = [
"memory",
"modules",
"targets",
"totalSymbolTableParseTime",
"totalSymbolTableIndexTime",
"totalSymbolTablesLoadedFromCache",
"totalSymbolTablesSavedToCache",
"totalDebugInfoByteSize",
"totalDebugInfoIndexTime",
"totalDebugInfoIndexLoadedFromCache",
"totalDebugInfoIndexSavedToCache",
"totalDebugInfoParseTime",
]
self.verify_keys(debug_stats, '"debug_stats"', debug_stat_keys, None)
stats = debug_stats["targets"][0]
keys_exist = [
"expressionEvaluation",
"firstStopTime",
"frameVariable",
"launchOrAttachTime",
"moduleIdentifiers",
"targetCreateTime",
]
self.verify_keys(stats, '"stats"', keys_exist, None)
self.assertGreater(stats["firstStopTime"], 0.0)
self.assertGreater(stats["launchOrAttachTime"], 0.0)
self.assertGreater(stats["targetCreateTime"], 0.0)
def test_memory(self):
"""
Test "statistics dump" and the memory information.
"""
self.build()
exe = self.getBuildArtifact("a.out")
target = self.createTestTarget(file_path=exe)
debug_stats = self.get_stats()
debug_stat_keys = [
"memory",
"modules",
"targets",
"totalSymbolTableParseTime",
"totalSymbolTableIndexTime",
"totalSymbolTablesLoadedFromCache",
"totalSymbolTablesSavedToCache",
"totalDebugInfoParseTime",
"totalDebugInfoIndexTime",
"totalDebugInfoIndexLoadedFromCache",
"totalDebugInfoIndexSavedToCache",
"totalDebugInfoByteSize",
]
self.verify_keys(debug_stats, '"debug_stats"', debug_stat_keys, None)
memory = debug_stats["memory"]
memory_keys = [
"strings",
]
self.verify_keys(memory, '"memory"', memory_keys, None)
strings = memory["strings"]
strings_keys = [
"bytesTotal",
"bytesUsed",
"bytesUnused",
]
self.verify_keys(strings, '"strings"', strings_keys, None)
def find_module_in_metrics(self, path, stats):
modules = stats["modules"]
for module in modules:
if module["path"] == path:
return module
return None
def find_module_by_id_in_metrics(self, id, stats):
modules = stats["modules"]
for module in modules:
if module["identifier"] == id:
return module
return None
def test_modules(self):
"""
Test "statistics dump" and the module information.
"""
self.build()
exe = self.getBuildArtifact("a.out")
target = self.createTestTarget(file_path=exe)
debug_stats = self.get_stats()
debug_stat_keys = [
"memory",
"modules",
"targets",
"totalSymbolTableParseTime",
"totalSymbolTableIndexTime",
"totalSymbolTablesLoadedFromCache",
"totalSymbolTablesSavedToCache",
"totalDebugInfoParseTime",
"totalDebugInfoIndexTime",
"totalDebugInfoIndexLoadedFromCache",
"totalDebugInfoIndexSavedToCache",
"totalDebugInfoByteSize",
]
self.verify_keys(debug_stats, '"debug_stats"', debug_stat_keys, None)
stats = debug_stats["targets"][0]
keys_exist = [
"moduleIdentifiers",
]
self.verify_keys(stats, '"stats"', keys_exist, None)
exe_module = self.find_module_in_metrics(exe, debug_stats)
module_keys = [
"debugInfoByteSize",
"debugInfoIndexLoadedFromCache",
"debugInfoIndexTime",
"debugInfoIndexSavedToCache",
"debugInfoParseTime",
"identifier",
"path",
"symbolTableIndexTime",
"symbolTableLoadedFromCache",
"symbolTableParseTime",
"symbolTableSavedToCache",
"triple",
"uuid",
]
self.assertNotEqual(exe_module, None)
self.verify_keys(exe_module, 'module dict for "%s"' % (exe), module_keys)
def test_commands(self):
"""
Test "statistics dump" and the command information.
"""
self.build()
exe = self.getBuildArtifact("a.out")
target = self.createTestTarget(file_path=exe)
interp = self.dbg.GetCommandInterpreter()
result = lldb.SBCommandReturnObject()
interp.HandleCommand("target list", result)
interp.HandleCommand("target list", result)
debug_stats = self.get_stats()
command_stats = self.get_command_stats(debug_stats)
self.assertNotEqual(command_stats, None)
self.assertEqual(command_stats["target list"], 2)
def test_breakpoints(self):
"""Test "statistics dump"
Output expected to be something like:
{
"memory" : {...},
"modules" : [...],
"targets" : [
{
"firstStopTime": 0.34164492800000001,
"launchOrAttachTime": 0.31969605400000001,
"moduleIdentifiers": [...],
"targetCreateTime": 0.0040863039999999998
"expressionEvaluation": {
"failures": 0,
"successes": 0
},
"frameVariable": {
"failures": 0,
"successes": 0
},
"breakpoints": [
{
"details": {...},
"id": 1,
"resolveTime": 2.65438675
},
{
"details": {...},
"id": 2,
"resolveTime": 4.3632581669999997
}
]
}
],
"totalDebugInfoByteSize": 182522234,
"totalDebugInfoIndexTime": 2.33343,
"totalDebugInfoParseTime": 8.2121400240000071,
"totalSymbolTableParseTime": 0.123,
"totalSymbolTableIndexTime": 0.234,
"totalBreakpointResolveTime": 7.0176449170000001
}
"""
self.build()
target = self.createTestTarget()
self.runCmd("b main.cpp:7")
self.runCmd("b a_function")
debug_stats = self.get_stats()
debug_stat_keys = [
"memory",
"modules",
"targets",
"totalSymbolTableParseTime",
"totalSymbolTableIndexTime",
"totalSymbolTablesLoadedFromCache",
"totalSymbolTablesSavedToCache",
"totalDebugInfoParseTime",
"totalDebugInfoIndexTime",
"totalDebugInfoIndexLoadedFromCache",
"totalDebugInfoIndexSavedToCache",
"totalDebugInfoByteSize",
]
self.verify_keys(debug_stats, '"debug_stats"', debug_stat_keys, None)
target_stats = debug_stats["targets"][0]
keys_exist = [
"breakpoints",
"expressionEvaluation",
"frameVariable",
"targetCreateTime",
"moduleIdentifiers",
"totalBreakpointResolveTime",
]
self.verify_keys(target_stats, '"stats"', keys_exist, None)
self.assertGreater(target_stats["totalBreakpointResolveTime"], 0.0)
breakpoints = target_stats["breakpoints"]
bp_keys_exist = [
"details",
"id",
"internal",
"numLocations",
"numResolvedLocations",
"resolveTime",
]
for breakpoint in breakpoints:
self.verify_keys(
breakpoint, 'target_stats["breakpoints"]', bp_keys_exist, None
)
@skipUnlessDarwin
@no_debug_info_test
def test_dsym_binary_has_symfile_in_stats(self):
"""
Test that if our executable has a stand alone dSYM file containing
debug information, that the dSYM file path is listed as a key/value
pair in the "a.out" binaries module stats. Also verify the the main
executable's module statistics has a debug info size that is greater
than zero as the dSYM contains debug info.
"""
self.build(debug_info="dsym")
exe_name = "a.out"
exe = self.getBuildArtifact(exe_name)
dsym = self.getBuildArtifact(exe_name + ".dSYM")
# Make sure the executable file exists after building.
self.assertTrue(os.path.exists(exe))
# Make sure the dSYM file exists after building.
self.assertTrue(os.path.isdir(dsym))
# Create the target
target = self.createTestTarget(file_path=exe)
debug_stats = self.get_stats()
exe_stats = self.find_module_in_metrics(exe, debug_stats)
# If we have a dSYM file, there should be a key/value pair in the module
# statistics and the path should match the dSYM file path in the build
# artifacts.
self.assertIn("symbolFilePath", exe_stats)
stats_dsym = exe_stats["symbolFilePath"]
# Make sure main executable's module info has debug info size that is
# greater than zero as the dSYM file and main executable work together
# in the lldb.SBModule class to provide the data.
self.assertGreater(exe_stats["debugInfoByteSize"], 0)
# The "dsym" variable contains the bundle directory for the dSYM, while
# the "stats_dsym" will have the
self.assertIn(dsym, stats_dsym)
# Since we have a dSYM file, we should not be loading DWARF from the .o
# files and the .o file module identifiers should NOT be in the module
# statistics.
self.assertNotIn("symbolFileModuleIdentifiers", exe_stats)
@skipUnlessDarwin
@no_debug_info_test
def test_no_dsym_binary_has_symfile_identifiers_in_stats(self):
"""
Test that if our executable loads debug info from the .o files,
that the module statistics contains a 'symbolFileModuleIdentifiers'
key which is a list of module identifiers, and verify that the
module identifier can be used to find the .o file's module stats.
Also verify the the main executable's module statistics has a debug
info size that is zero, as the main executable itself has no debug
info, but verify that the .o files have debug info size that is
greater than zero. This test ensures that we don't double count
debug info.
"""
self.build(debug_info="dwarf")
exe_name = "a.out"
exe = self.getBuildArtifact(exe_name)
dsym = self.getBuildArtifact(exe_name + ".dSYM")
# Make sure the executable file exists after building.
self.assertTrue(os.path.exists(exe))
# Make sure the dSYM file doesn't exist after building.
self.assertFalse(os.path.isdir(dsym))
# Create the target
target = self.createTestTarget(file_path=exe)
# Force the 'main.o' .o file's DWARF to be loaded so it will show up
# in the stats.
self.runCmd("b main.cpp:7")
debug_stats = self.get_stats()
exe_stats = self.find_module_in_metrics(exe, debug_stats)
# If we don't have a dSYM file, there should not be a key/value pair in
# the module statistics.
self.assertNotIn("symbolFilePath", exe_stats)
# Make sure main executable's module info has debug info size that is
# zero as there is no debug info in the main executable, only in the
# .o files. The .o files will also only be loaded if something causes
# them to be loaded, so we set a breakpoint to force the .o file debug
# info to be loaded.
self.assertEqual(exe_stats["debugInfoByteSize"], 0)
# When we don't have a dSYM file, the SymbolFileDWARFDebugMap class
# should create modules for each .o file that contains DWARF that the
# symbol file creates, so we need to verify that we have a valid module
# identifier for main.o that is we should not be loading DWARF from the .o
# files and the .o file module identifiers should NOT be in the module
# statistics.
self.assertIn("symbolFileModuleIdentifiers", exe_stats)
symfileIDs = exe_stats["symbolFileModuleIdentifiers"]
for symfileID in symfileIDs:
o_module = self.find_module_by_id_in_metrics(symfileID, debug_stats)
self.assertNotEqual(o_module, None)
# Make sure each .o file has some debug info bytes.
self.assertGreater(o_module["debugInfoByteSize"], 0)
@skipUnlessDarwin
@no_debug_info_test
def test_had_frame_variable_errors(self):
"""
Test that if we have frame variable errors that we see this in the
statistics for the module that had issues.
"""
self.build(debug_info="dwarf")
exe_name = "a.out"
exe = self.getBuildArtifact(exe_name)
dsym = self.getBuildArtifact(exe_name + ".dSYM")
main_obj = self.getBuildArtifact("main.o")
# Make sure the executable file exists after building.
self.assertTrue(os.path.exists(exe))
# Make sure the dSYM file doesn't exist after building.
self.assertFalse(os.path.isdir(dsym))
# Make sure the main.o object file exists after building.
self.assertTrue(os.path.exists(main_obj))
# Delete the main.o file that contains the debug info so we force an
# error when we run to main and try to get variables
os.unlink(main_obj)
(target, process, thread, bkpt) = lldbutil.run_to_name_breakpoint(self, "main")
# Get stats and verify we had errors.
stats = self.get_stats()
exe_stats = self.find_module_in_metrics(exe, stats)
self.assertIsNotNone(exe_stats)
# Make sure we have "debugInfoHadVariableErrors" variable that is set to
# false before failing to get local variables due to missing .o file.
self.assertFalse(exe_stats["debugInfoHadVariableErrors"])
# Verify that the top level statistic that aggregates the number of
# modules with debugInfoHadVariableErrors is zero
self.assertEqual(stats["totalModuleCountWithVariableErrors"], 0)
# Try and fail to get variables
vars = thread.GetFrameAtIndex(0).GetVariables(True, True, False, True)
# Make sure we got an error back that indicates that variables were not
# available
self.assertTrue(vars.GetError().Fail())
# Get stats and verify we had errors.
stats = self.get_stats()
exe_stats = self.find_module_in_metrics(exe, stats)
self.assertIsNotNone(exe_stats)
# Make sure we have "hadFrameVariableErrors" variable that is set to
# true after failing to get local variables due to missing .o file.
self.assertTrue(exe_stats["debugInfoHadVariableErrors"])
# Verify that the top level statistic that aggregates the number of
# modules with debugInfoHadVariableErrors is greater than zero
self.assertGreater(stats["totalModuleCountWithVariableErrors"], 0)
def test_transcript_happy_path(self):
"""
Test "statistics dump" and the transcript information.
"""
self.build()
exe = self.getBuildArtifact("a.out")
target = self.createTestTarget(file_path=exe)
self.runCmd("settings set interpreter.save-transcript true")
self.runCmd("version")
# Verify the output of a first "statistics dump"
debug_stats = self.get_stats("--transcript true")
self.assertIn("transcript", debug_stats)
transcript = debug_stats["transcript"]
self.assertEqual(len(transcript), 2)
self.assertEqual(transcript[0]["commandName"], "version")
self.assertEqual(transcript[1]["commandName"], "statistics dump")
# The first "statistics dump" in the transcript should have no output
self.assertNotIn("output", transcript[1])
# Verify the output of a second "statistics dump"
debug_stats = self.get_stats("--transcript true")
self.assertIn("transcript", debug_stats)
transcript = debug_stats["transcript"]
self.assertEqual(len(transcript), 3)
self.assertEqual(transcript[0]["commandName"], "version")
self.assertEqual(transcript[1]["commandName"], "statistics dump")
# The first "statistics dump" in the transcript should have output now
self.assertIn("output", transcript[1])
self.assertEqual(transcript[2]["commandName"], "statistics dump")
# The second "statistics dump" in the transcript should have no output
self.assertNotIn("output", transcript[2])
def verify_stats(self, stats, expectation, options):
for field_name in expectation:
idx = field_name.find(".")
if idx == -1:
# `field_name` is a top-level field
exists = field_name in stats
should_exist = expectation[field_name]
should_exist_string = "" if should_exist else "not "
self.assertEqual(
exists,
should_exist,
f"'{field_name}' should {should_exist_string}exist for 'statistics dump{options}'",
)
else:
# `field_name` is a string of "<top-level field>.<second-level field>"
top_level_field_name = field_name[0:idx]
second_level_field_name = field_name[idx + 1 :]
for top_level_field in (
stats[top_level_field_name] if top_level_field_name in stats else {}
):
exists = second_level_field_name in top_level_field
should_exist = expectation[field_name]
should_exist_string = "" if should_exist else "not "
self.assertEqual(
exists,
should_exist,
f"'{field_name}' should {should_exist_string}exist for 'statistics dump{options}'",
)
def get_test_cases_for_sections_existence(self):
should_always_exist_or_not = {
"totalDebugInfoEnabled": True,
"memory": True,
}
test_cases = [
{ # Everything mode
"command_options": "",
"api_options": {},
"expect": {
"commands": True,
"targets": True,
"targets.moduleIdentifiers": True,
"targets.breakpoints": True,
"targets.expressionEvaluation": True,
"targets.frameVariable": True,
"targets.totalSharedLibraryEventHitCount": True,
"modules": True,
"transcript": True,
},
},
{ # Summary mode
"command_options": " --summary",
"api_options": {
"SetSummaryOnly": True,
},
"expect": {
"commands": False,
"targets": True,
"targets.moduleIdentifiers": False,
"targets.breakpoints": False,
"targets.expressionEvaluation": False,
"targets.frameVariable": False,
"targets.totalSharedLibraryEventHitCount": True,
"modules": False,
"transcript": False,
},
},
{ # Summary mode with targets
"command_options": " --summary --targets=true",
"api_options": {
"SetSummaryOnly": True,
"SetIncludeTargets": True,
},
"expect": {
"commands": False,
"targets": True,
"targets.moduleIdentifiers": False,
"targets.breakpoints": False,
"targets.expressionEvaluation": False,
"targets.frameVariable": False,
"targets.totalSharedLibraryEventHitCount": True,
"modules": False,
"transcript": False,
},
},
{ # Summary mode without targets
"command_options": " --summary --targets=false",
"api_options": {
"SetSummaryOnly": True,
"SetIncludeTargets": False,
},
"expect": {
"commands": False,
"targets": False,
"modules": False,
"transcript": False,
},
},
{ # Summary mode with modules
"command_options": " --summary --modules=true",
"api_options": {
"SetSummaryOnly": True,
"SetIncludeModules": True,
},
"expect": {
"commands": False,
"targets": True,
"targets.moduleIdentifiers": False,
"targets.breakpoints": False,
"targets.expressionEvaluation": False,
"targets.frameVariable": False,
"targets.totalSharedLibraryEventHitCount": True,
"modules": True,
"transcript": False,
},
},
{ # Default mode without modules and transcript
"command_options": " --modules=false --transcript=false",
"api_options": {
"SetIncludeModules": False,
"SetIncludeTranscript": False,
},
"expect": {
"commands": True,
"targets": True,
"targets.moduleIdentifiers": False,
"targets.breakpoints": True,
"targets.expressionEvaluation": True,
"targets.frameVariable": True,
"targets.totalSharedLibraryEventHitCount": True,
"modules": False,
"transcript": False,
},
},
{ # Default mode without modules
"command_options": " --modules=false",
"api_options": {
"SetIncludeModules": False,
},
"expect": {
"commands": True,
"targets": True,
"targets.moduleIdentifiers": False,
"targets.breakpoints": True,
"targets.expressionEvaluation": True,
"targets.frameVariable": True,
"targets.totalSharedLibraryEventHitCount": True,
"modules": False,
"transcript": True,
},
},
]
return (should_always_exist_or_not, test_cases)
def test_sections_existence_through_command(self):
"""
Test "statistics dump" and the existence of sections when different
options are given through the command line (CLI or HandleCommand).
"""
self.build()
exe = self.getBuildArtifact("a.out")
target = self.createTestTarget(file_path=exe)
# Create some transcript so that it can be tested.
self.runCmd("settings set interpreter.save-transcript true")
self.runCmd("version")
self.runCmd("b main")
# Then disable transcript so that it won't change during verification
self.runCmd("settings set interpreter.save-transcript false")
# Expectation
(
should_always_exist_or_not,
test_cases,
) = self.get_test_cases_for_sections_existence()
# Verification
for test_case in test_cases:
options = test_case["command_options"]
# Get statistics dump result
stats = self.get_stats(options)
# Verify that each field should exist (or not)
expectation = {**should_always_exist_or_not, **test_case["expect"]}
self.verify_stats(stats, expectation, options)
def test_sections_existence_through_api(self):
"""
Test "statistics dump" and the existence of sections when different
options are given through the public API.
"""
self.build()
exe = self.getBuildArtifact("a.out")
target = self.createTestTarget(file_path=exe)
# Create some transcript so that it can be tested.
self.runCmd("settings set interpreter.save-transcript true")
self.runCmd("version")
self.runCmd("b main")
# But disable transcript so that it won't change during verification
self.runCmd("settings set interpreter.save-transcript false")
# Expectation
(
should_always_exist_or_not,
test_cases,
) = self.get_test_cases_for_sections_existence()
# Verification
for test_case in test_cases:
# Create options
options = test_case["api_options"]
sb_options = lldb.SBStatisticsOptions()
for method_name, param_value in options.items():
getattr(sb_options, method_name)(param_value)
# Get statistics dump result
stream = lldb.SBStream()
target.GetStatistics(sb_options).GetAsJSON(stream)
stats = json.loads(stream.GetData())
# Verify that each field should exist (or not)
expectation = {**should_always_exist_or_not, **test_case["expect"]}
self.verify_stats(stats, expectation, options)
def test_order_of_options_do_not_matter(self):
"""
Test "statistics dump" and the order of options.
"""
self.build()
exe = self.getBuildArtifact("a.out")
target = self.createTestTarget(file_path=exe)
# Create some transcript so that it can be tested.
self.runCmd("settings set interpreter.save-transcript true")
self.runCmd("version")
self.runCmd("b main")
# Then disable transcript so that it won't change during verification
self.runCmd("settings set interpreter.save-transcript false")
# The order of the following options shouldn't matter
test_cases = [
(" --summary", " --targets=true"),
(" --summary", " --targets=false"),
(" --summary", " --modules=true"),
(" --summary", " --modules=false"),
(" --summary", " --transcript=true"),
(" --summary", " --transcript=false"),
]
# Verification
for options in test_cases:
debug_stats_0 = self.get_stats(options[0] + options[1])
debug_stats_1 = self.get_stats(options[1] + options[0])
# Redact all numbers
debug_stats_0 = re.sub(r"\d+", "0", json.dumps(debug_stats_0))
debug_stats_1 = re.sub(r"\d+", "0", json.dumps(debug_stats_1))
# Verify that the two output are the same
self.assertEqual(
debug_stats_0,
debug_stats_1,
f"The order of options '{options[0]}' and '{options[1]}' should not matter",
)
Reference in New Issue View Git Blame Copy Permalink