1eeeab82c6
Any time we see the pattern `assertEqual(value, bool)`, we can replace
that with `assert<bool>(value)`. Likewise for `assertNotEqual`.
Technically this relaxes the test a bit, as we may want to make sure
`value` is either `True` or `False`, and not something that implicitly
converts to a bool. For example, `assertEqual("foo", True)` will fail,
but `assertTrue("foo")` will not. In most cases, this distinction is not
important.
There are two such places that this patch does **not** transform, since
it seems intentional that we want the result to be a bool:
*
5daf2001a1/lldb/test/API/python_api/sbstructureddata/TestStructuredDataAPI.py (L90)
*
5daf2001a1/lldb/test/API/commands/settings/TestSettings.py (L940)
Followup to 9c2468821e. I patched `teyit`
with a `visit_assertEqual` node handler to generate this.
28 lines
942 B
Python
28 lines
942 B
Python
"""
|
|
Test that the target.process.thread.max-backtrace-depth setting works.
|
|
"""
|
|
|
|
import lldb
|
|
from lldbsuite.test.decorators import *
|
|
from lldbsuite.test.lldbtest import *
|
|
from lldbsuite.test import lldbutil
|
|
|
|
|
|
class BacktraceLimitSettingTest(TestBase):
|
|
NO_DEBUG_INFO_TESTCASE = True
|
|
|
|
def test_backtrace_depth(self):
|
|
"""Test that the max-backtrace-depth setting limits backtraces."""
|
|
self.build()
|
|
self.main_source_file = lldb.SBFileSpec("main.cpp")
|
|
(target, process, thread, bkpt) = lldbutil.run_to_source_breakpoint(
|
|
self, "Set a breakpoint here", self.main_source_file
|
|
)
|
|
interp = self.dbg.GetCommandInterpreter()
|
|
result = lldb.SBCommandReturnObject()
|
|
interp.HandleCommand(
|
|
"settings set target.process.thread.max-backtrace-depth 30", result
|
|
)
|
|
self.assertTrue(result.Succeeded())
|
|
self.assertEqual(30, thread.GetNumFrames())
|