Summary:
Around a third of our test sources have LLVM license headers. This patch removes those headers from all test
sources and also fixes any tests that depended on the length of the license header.
The reasons for this are:
* A few tests verify line numbers and will start failing if the number of lines in the LLVM license header changes. Once I landed my patch for valid SourceLocations in debug info we will probably have even more tests that verify line numbers.
* No other LLVM project is putting license headers in its test files to my knowledge.
* They make the test sources much more verbose than they have to be. Several tests have longer license headers than the actual test source.
For the record, the following tests had their line numbers changed to pass with the removal of the license header:
lldb-api :: functionalities/breakpoint/breakpoint_by_line_and_column/TestBreakpointByLineAndColumn.py
lldb-shell :: Reproducer/TestGDBRemoteRepro.test
lldb-shell :: Reproducer/TestMultipleTargets.test
lldb-shell :: Reproducer/TestReuseDirectory.test
lldb-shell :: ExecControl/StopHook/stop-hook-threads.test
lldb-shell :: ExecControl/StopHook/stop-hook.test
lldb-api :: lang/objc/exceptions/TestObjCExceptions.py
Reviewers: #lldb, espindola, JDevlieghere
Reviewed By: #lldb, JDevlieghere
Subscribers: emaste, aprantl, arphaman, JDevlieghere, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D74839
41 lines
919 B
C++
41 lines
919 B
C++
// This test is intended to create a situation in which a breakpoint will be
|
|
// hit in two threads at nearly the same moment. The expected result is that
|
|
// the breakpoint in the second thread will be hit while the breakpoint handler
|
|
// in the first thread is trying to stop all threads.
|
|
|
|
#include "pseudo_barrier.h"
|
|
#include <thread>
|
|
|
|
pseudo_barrier_t g_barrier;
|
|
|
|
volatile int g_test = 0;
|
|
|
|
void *
|
|
thread_func ()
|
|
{
|
|
// Wait until both threads are running
|
|
pseudo_barrier_wait(g_barrier);
|
|
|
|
// Do something
|
|
g_test++; // Set breakpoint here
|
|
|
|
// Return
|
|
return NULL;
|
|
}
|
|
|
|
int main ()
|
|
{
|
|
// Don't let either thread do anything until they're both ready.
|
|
pseudo_barrier_init(g_barrier, 2);
|
|
|
|
// Create two threads
|
|
std::thread thread_1(thread_func);
|
|
std::thread thread_2(thread_func);
|
|
|
|
// Wait for the threads to finish
|
|
thread_1.join();
|
|
thread_2.join();
|
|
|
|
return 0;
|
|
}
|