Before, we create the set of abstract attributes initially and then dealt with the fact hat a lookup could fail, e.g., return a nullptr. This patch will ensure we always return a valid object from a lookup, allowing us not only to remove the nullptr checks but also to grow the set of abstract attributes "in-flight" on-demand. One can now start from those that have the best chance of improving performance without the need to specify all they might depend on. While this introduces some boilerplate, the usage of attributes is much easier and cleaner now. Reviewers: uenoku, sstefan1 Subscribers: hiraditya, bollu, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D66276 llvm-svn: 369331
53 lines
2.1 KiB
LLVM
53 lines
2.1 KiB
LLVM
; RUN: opt -attributor --attributor-disable=false -S < %s | FileCheck %s --check-prefixes=ATTRIBUTOR
|
|
|
|
|
|
; TEST 1
|
|
; take mininimum of return values
|
|
;
|
|
define i32* @test1(i32* dereferenceable(4) %0, double* dereferenceable(8) %1, i1 zeroext %2) local_unnamed_addr {
|
|
; ATTRIBUTOR: define nonnull dereferenceable(4) i32* @test1(i32* nonnull dereferenceable(4) %0, double* nonnull dereferenceable(8) %1, i1 zeroext %2)
|
|
%4 = bitcast double* %1 to i32*
|
|
%5 = select i1 %2, i32* %0, i32* %4
|
|
ret i32* %5
|
|
}
|
|
|
|
; TEST 2
|
|
define i32* @test2(i32* dereferenceable_or_null(4) %0, double* dereferenceable(8) %1, i1 zeroext %2) local_unnamed_addr {
|
|
; ATTRIBUTOR: define dereferenceable_or_null(4) i32* @test2(i32* dereferenceable_or_null(4) %0, double* nonnull dereferenceable(8) %1, i1 zeroext %2)
|
|
%4 = bitcast double* %1 to i32*
|
|
%5 = select i1 %2, i32* %0, i32* %4
|
|
ret i32* %5
|
|
}
|
|
|
|
; TEST 3
|
|
; GEP inbounds
|
|
define i32* @test3_1(i32* dereferenceable(8) %0) local_unnamed_addr {
|
|
; ATTRIBUTOR: define nonnull dereferenceable(4) i32* @test3_1(i32* nonnull dereferenceable(8) %0)
|
|
%ret = getelementptr inbounds i32, i32* %0, i64 1
|
|
ret i32* %ret
|
|
}
|
|
|
|
define i32* @test3_2(i32* dereferenceable_or_null(32) %0) local_unnamed_addr {
|
|
; FIXME: Argument should be mark dereferenceable because of GEP `inbounds`.
|
|
; ATTRIBUTOR: define nonnull dereferenceable(16) i32* @test3_2(i32* dereferenceable_or_null(32) %0)
|
|
%ret = getelementptr inbounds i32, i32* %0, i64 4
|
|
ret i32* %ret
|
|
}
|
|
|
|
define i32* @test3_3(i32* dereferenceable(8) %0, i32* dereferenceable(16) %1, i1 %2) local_unnamed_addr {
|
|
; ATTRIBUTOR: define nonnull dereferenceable(4) i32* @test3_3(i32* nonnull dereferenceable(8) %0, i32* nonnull dereferenceable(16) %1, i1 %2) local_unnamed_addr
|
|
%ret1 = getelementptr inbounds i32, i32* %0, i64 1
|
|
%ret2 = getelementptr inbounds i32, i32* %1, i64 2
|
|
%ret = select i1 %2, i32* %ret1, i32* %ret2
|
|
ret i32* %ret
|
|
}
|
|
|
|
; TEST 4
|
|
; Better than known in IR.
|
|
|
|
define dereferenceable(4) i32* @test4(i32* dereferenceable(8) %0) local_unnamed_addr {
|
|
; ATTRIBUTOR: define nonnull dereferenceable(8) i32* @test4(i32* nonnull returned dereferenceable(8) %0)
|
|
ret i32* %0
|
|
}
|
|
|