1756630dfa
Summary:
According to [C128] "Virtual functions should specify exactly one
of `virtual`, `override`, or `final`", I've added override where a
virtual function is overriden but the explicit `override` keyword
was missing. Whenever both `virtual` and `override` were specified,
I removed `virtual`. As C.128 puts it:
> [...] writing more than one of these three is both redundant and
> a potential source of errors.
I anticipate a discussion about whether or not to add `override` to
destructors but I went for it because of an example in [ISOCPP1000].
Let me repeat the comment for you here:
Consider this code:
```
struct Base {
virtual ~Base(){}
};
struct SubClass : Base {
~SubClass() {
std::cout << "It works!\n";
}
};
int main() {
std::unique_ptr<Base> ptr = std::make_unique<SubClass>();
}
```
If for some odd reason somebody removes the `virtual` keyword from the
`Base` struct, the code will no longer print `It works!`. So adding
`override` to destructors actively protects us from accidentally
breaking our code at runtime.
[C128]: https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#c128-virtual-functions-should-specify-exactly-one-of-virtual-override-or-final
[ISOCPP1000]: https://github.com/isocpp/CppCoreGuidelines/issues/1000#issuecomment-476951555
Reviewers: teemperor, JDevlieghere, davide, shafik
Reviewed By: teemperor
Subscribers: kwk, arphaman, kadircet, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D61440
llvm-svn: 359868
53 lines
1.8 KiB
C++
53 lines
1.8 KiB
C++
//===-- RenderScriptExpressionOpts.h ----------------------------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef LLDB_RENDERSCRIPT_EXPROPTS_H
|
|
#define LLDB_RENDERSCRIPT_EXPROPTS_H
|
|
|
|
#include "llvm/IR/Module.h"
|
|
#include "llvm/Support/TargetRegistry.h"
|
|
#include "llvm/Target/TargetMachine.h"
|
|
#include "llvm/Target/TargetOptions.h"
|
|
|
|
#include "lldb/Target/LanguageRuntime.h"
|
|
#include "lldb/Target/Process.h"
|
|
#include "lldb/lldb-private.h"
|
|
|
|
#include "RenderScriptRuntime.h"
|
|
#include "RenderScriptx86ABIFixups.h"
|
|
|
|
// RenderScriptRuntimeModulePass is a simple llvm::ModulesPass that is used
|
|
// during expression evaluation to apply RenderScript-specific fixes for
|
|
// expression evaluation. In particular this is used to make expression IR
|
|
// conformant with the ABI generated by the slang frontend. This ModulePass is
|
|
// executed in ClangExpressionParser::PrepareForExecution whenever an
|
|
// expression's DWARF language is eLanguageTypeExtRenderscript
|
|
|
|
class RenderScriptRuntimeModulePass : public llvm::ModulePass {
|
|
public:
|
|
static char ID;
|
|
RenderScriptRuntimeModulePass(const lldb_private::Process *process)
|
|
: ModulePass(ID), m_process_ptr(process) {}
|
|
|
|
bool runOnModule(llvm::Module &module) override;
|
|
|
|
private:
|
|
const lldb_private::Process *m_process_ptr;
|
|
};
|
|
|
|
namespace lldb_private {
|
|
namespace lldb_renderscript {
|
|
struct RSIRPasses : public lldb_private::LLVMUserExpression::IRPasses {
|
|
RSIRPasses(lldb_private::Process *process);
|
|
|
|
~RSIRPasses();
|
|
};
|
|
} // namespace lldb_renderscript
|
|
} // namespace lldb_private
|
|
#endif
|