826997c462
In a new Range class was introduced to simplify and the Disassembler API
and reduce duplication. It unintentionally broke the
SBFrame::Disassemble functionality because it unconditionally converts
the number of instructions to a Range{Limit::Instructions,
num_instructions}. This is subtly different from the previous behavior,
where now we're passing a Range and assume it's valid in the callee, the
original code would propagate num_instructions and the callee would
compare the value and decided between disassembling instructions or
bytes.
Unfortunately the existing tests was not particularly strict:
disassembly = frame.Disassemble()
self.assertNotEqual(len(disassembly), 0, "Disassembly was empty.")
This would pass because without this patch we'd disassemble zero
instructions, resulting in an error:
(lldb) script print(lldb.frame.Disassemble())
error: error reading data from section __text
Differential revision: https://reviews.llvm.org/D89925
63 lines
2.1 KiB
Python
63 lines
2.1 KiB
Python
"""
|
|
Test to ensure SBFrame::Disassemble produces SOME output
|
|
"""
|
|
|
|
|
|
|
|
import lldb
|
|
import lldbsuite.test.lldbutil as lldbutil
|
|
from lldbsuite.test.lldbtest import *
|
|
|
|
|
|
class FrameDisassembleTestCase(TestBase):
|
|
|
|
mydir = TestBase.compute_mydir(__file__)
|
|
|
|
NO_DEBUG_INFO_TESTCASE = True
|
|
|
|
def test_frame_disassemble(self):
|
|
"""Sample test to ensure SBFrame::Disassemble produces SOME output."""
|
|
self.build()
|
|
self.frame_disassemble_test()
|
|
|
|
def frame_disassemble_test(self):
|
|
"""Sample test to ensure SBFrame::Disassemble produces SOME output"""
|
|
exe = self.getBuildArtifact("a.out")
|
|
|
|
# Create a target by the debugger.
|
|
target = self.dbg.CreateTarget(exe)
|
|
self.assertTrue(target, VALID_TARGET)
|
|
|
|
# Now create a breakpoint in main.c at the source matching
|
|
# "Set a breakpoint here"
|
|
breakpoint = target.BreakpointCreateBySourceRegex(
|
|
"Set a breakpoint here", lldb.SBFileSpec("main.cpp"))
|
|
self.assertTrue(breakpoint and
|
|
breakpoint.GetNumLocations() >= 1,
|
|
VALID_BREAKPOINT)
|
|
|
|
error = lldb.SBError()
|
|
# This is the launch info. If you want to launch with arguments or
|
|
# environment variables, add them using SetArguments or
|
|
# SetEnvironmentEntries
|
|
|
|
launch_info = target.GetLaunchInfo()
|
|
process = target.Launch(launch_info, error)
|
|
self.assertTrue(process, PROCESS_IS_VALID)
|
|
|
|
# Did we hit our breakpoint?
|
|
from lldbsuite.test.lldbutil import get_threads_stopped_at_breakpoint
|
|
threads = get_threads_stopped_at_breakpoint(process, breakpoint)
|
|
self.assertTrue(
|
|
len(threads) == 1,
|
|
"There should be a thread stopped at our breakpoint")
|
|
|
|
# The hit count for the breakpoint should be 1.
|
|
self.assertEquals(breakpoint.GetHitCount(), 1)
|
|
|
|
frame = threads[0].GetFrameAtIndex(0)
|
|
disassembly = frame.Disassemble()
|
|
self.assertNotEqual(disassembly, "")
|
|
self.assertNotIn("error", disassembly)
|
|
self.assertIn(": nop", disassembly)
|