b3a0c4d7dc
Summary:
The error message from the construct `assertTrue(a == b, "msg") ` are nearly always completely useless for actually debugging the issue.
This patch is just replacing this construct (and similar ones like `assertTrue(a != b, ...)` with the proper call to assertEqual or assertNotEquals.
This patch was mostly written by a shell script with some manual verification afterwards:
```
lang=python
import sys
def sanitize_line(line):
if line.strip().startswith("self.assertTrue(") and " == " in line:
line = line.replace("self.assertTrue(", "self.assertEquals(")
line = line.replace(" == ", ", ", 1)
if line.strip().startswith("self.assertTrue(") and " != " in line:
line = line.replace("self.assertTrue(", "self.assertNotEqual(")
line = line.replace(" != ", ", ", 1)
return line
for a in sys.argv[1:]:
with open(a, "r") as f:
lines = f.readlines()
with open(a, "w") as f:
for line in lines:
f.write(sanitize_line(line))
```
Reviewers: labath, JDevlieghere
Reviewed By: labath
Subscribers: abidh, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D74475
53 lines
1.6 KiB
Python
53 lines
1.6 KiB
Python
"""
|
|
Test that LLDB can emit JIT objects when the appropriate setting is enabled
|
|
"""
|
|
|
|
|
|
import os
|
|
import lldb
|
|
from lldbsuite.test.decorators import *
|
|
from lldbsuite.test.lldbtest import *
|
|
from lldbsuite.test import lldbutil
|
|
|
|
class SaveJITObjectsTestCase(TestBase):
|
|
mydir = TestBase.compute_mydir(__file__)
|
|
|
|
def enumerateJITFiles(self):
|
|
return [f for f in os.listdir(self.getBuildDir()) if f.startswith("jit")]
|
|
|
|
def countJITFiles(self):
|
|
return len(self.enumerateJITFiles())
|
|
|
|
def cleanJITFiles(self):
|
|
for j in self.enumerateJITFiles():
|
|
os.remove(j)
|
|
return
|
|
|
|
@expectedFailureAll(oslist=["windows"])
|
|
@expectedFailureNetBSD
|
|
def test_save_jit_objects(self):
|
|
self.build()
|
|
os.chdir(self.getBuildDir())
|
|
src_file = "main.c"
|
|
src_file_spec = lldb.SBFileSpec(src_file)
|
|
|
|
(target, process, thread, bkpt) = lldbutil.run_to_source_breakpoint(
|
|
self, "break", src_file_spec)
|
|
|
|
frame = thread.frames[0]
|
|
|
|
self.cleanJITFiles()
|
|
frame.EvaluateExpression("(void*)malloc(0x1)")
|
|
self.assertEquals(self.countJITFiles(), 0,
|
|
"No files emitted with save-jit-objects=false")
|
|
|
|
self.runCmd("settings set target.save-jit-objects true")
|
|
frame.EvaluateExpression("(void*)malloc(0x1)")
|
|
jit_files_count = self.countJITFiles()
|
|
self.cleanJITFiles()
|
|
self.assertNotEqual(jit_files_count, 0,
|
|
"At least one file emitted with save-jit-objects=true")
|
|
|
|
process.Kill()
|
|
os.chdir(self.getSourceDir())
|