Paul Chaignon reported a bpf verifier failure ([1]) due to using
non-ABI register R11. For the test case, llvm11 is okay while
llvm12 and later generates verifier unfriendly code.
The failure is related to variable length array size.
The following mimics the variable length array definition
in the test case:
struct t { char a[20]; };
void foo(void *);
int test() {
const int a = 8;
char tmp[AA + sizeof(struct t) + a];
foo(tmp);
...
}
Paul helped bisect that the following llvm commit is
responsible:
552c6c2328 ("PR44406: Follow behavior of array bound constant
folding in more recent versions of GCC.")
Basically, before the above commit, clang frontend did constant
folding for array size "AA + sizeof(struct t) + a" to be 68,
so used alloca for stack allocation. After the above commit,
clang frontend didn't do constant folding for array size
any more, which results in a VLA and llvm.stacksave/llvm.stackrestore
is generated.
BPF architecture API does not support stack pointer (sp) register.
The LLVM internally used R11 to indicate sp register but it should
not be in the final code. Otherwise, kernel verifier will reject it.
The early patch ([2]) tried to fix the issue in clang frontend.
But the upstream discussion considered frontend fix is really a
hack and the backend should properly undo llvm.stacksave/llvm.stackrestore.
This patch implemented a bpf IR phase to remove these intrinsics
unconditionally. If eventually the alloca can be resolved with
constant size, r11 will not be generated. If alloca cannot be
resolved with constant size, SelectionDag will complain, the same
as without this patch.
[1] https://lore.kernel.org/bpf/20210809151202.GB1012999@Mem/
[2] https://reviews.llvm.org/D107882
Differential Revision: https://reviews.llvm.org/D111897
185 lines
6.4 KiB
C++
185 lines
6.4 KiB
C++
//===-- BPFTargetMachine.cpp - Define TargetMachine for BPF ---------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Implements the info about BPF target spec.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "BPFTargetMachine.h"
|
|
#include "BPF.h"
|
|
#include "BPFTargetTransformInfo.h"
|
|
#include "MCTargetDesc/BPFMCAsmInfo.h"
|
|
#include "TargetInfo/BPFTargetInfo.h"
|
|
#include "llvm/CodeGen/Passes.h"
|
|
#include "llvm/CodeGen/TargetLoweringObjectFileImpl.h"
|
|
#include "llvm/CodeGen/TargetPassConfig.h"
|
|
#include "llvm/IR/LegacyPassManager.h"
|
|
#include "llvm/IR/PassManager.h"
|
|
#include "llvm/MC/TargetRegistry.h"
|
|
#include "llvm/Passes/PassBuilder.h"
|
|
#include "llvm/Support/FormattedStream.h"
|
|
#include "llvm/Target/TargetOptions.h"
|
|
#include "llvm/Transforms/IPO/PassManagerBuilder.h"
|
|
#include "llvm/Transforms/Scalar.h"
|
|
#include "llvm/Transforms/Scalar/SimplifyCFG.h"
|
|
#include "llvm/Transforms/Utils/SimplifyCFGOptions.h"
|
|
using namespace llvm;
|
|
|
|
static cl::
|
|
opt<bool> DisableMIPeephole("disable-bpf-peephole", cl::Hidden,
|
|
cl::desc("Disable machine peepholes for BPF"));
|
|
|
|
extern "C" LLVM_EXTERNAL_VISIBILITY void LLVMInitializeBPFTarget() {
|
|
// Register the target.
|
|
RegisterTargetMachine<BPFTargetMachine> X(getTheBPFleTarget());
|
|
RegisterTargetMachine<BPFTargetMachine> Y(getTheBPFbeTarget());
|
|
RegisterTargetMachine<BPFTargetMachine> Z(getTheBPFTarget());
|
|
|
|
PassRegistry &PR = *PassRegistry::getPassRegistry();
|
|
initializeBPFAbstractMemberAccessLegacyPassPass(PR);
|
|
initializeBPFPreserveDITypePass(PR);
|
|
initializeBPFIRPeepholePass(PR);
|
|
initializeBPFAdjustOptPass(PR);
|
|
initializeBPFCheckAndAdjustIRPass(PR);
|
|
initializeBPFMIPeepholePass(PR);
|
|
initializeBPFMIPeepholeTruncElimPass(PR);
|
|
}
|
|
|
|
// DataLayout: little or big endian
|
|
static std::string computeDataLayout(const Triple &TT) {
|
|
if (TT.getArch() == Triple::bpfeb)
|
|
return "E-m:e-p:64:64-i64:64-i128:128-n32:64-S128";
|
|
else
|
|
return "e-m:e-p:64:64-i64:64-i128:128-n32:64-S128";
|
|
}
|
|
|
|
static Reloc::Model getEffectiveRelocModel(Optional<Reloc::Model> RM) {
|
|
return RM.getValueOr(Reloc::PIC_);
|
|
}
|
|
|
|
BPFTargetMachine::BPFTargetMachine(const Target &T, const Triple &TT,
|
|
StringRef CPU, StringRef FS,
|
|
const TargetOptions &Options,
|
|
Optional<Reloc::Model> RM,
|
|
Optional<CodeModel::Model> CM,
|
|
CodeGenOpt::Level OL, bool JIT)
|
|
: LLVMTargetMachine(T, computeDataLayout(TT), TT, CPU, FS, Options,
|
|
getEffectiveRelocModel(RM),
|
|
getEffectiveCodeModel(CM, CodeModel::Small), OL),
|
|
TLOF(std::make_unique<TargetLoweringObjectFileELF>()),
|
|
Subtarget(TT, std::string(CPU), std::string(FS), *this) {
|
|
initAsmInfo();
|
|
|
|
BPFMCAsmInfo *MAI =
|
|
static_cast<BPFMCAsmInfo *>(const_cast<MCAsmInfo *>(AsmInfo.get()));
|
|
MAI->setDwarfUsesRelocationsAcrossSections(!Subtarget.getUseDwarfRIS());
|
|
}
|
|
|
|
namespace {
|
|
// BPF Code Generator Pass Configuration Options.
|
|
class BPFPassConfig : public TargetPassConfig {
|
|
public:
|
|
BPFPassConfig(BPFTargetMachine &TM, PassManagerBase &PM)
|
|
: TargetPassConfig(TM, PM) {}
|
|
|
|
BPFTargetMachine &getBPFTargetMachine() const {
|
|
return getTM<BPFTargetMachine>();
|
|
}
|
|
|
|
void addIRPasses() override;
|
|
bool addInstSelector() override;
|
|
void addMachineSSAOptimization() override;
|
|
void addPreEmitPass() override;
|
|
};
|
|
}
|
|
|
|
TargetPassConfig *BPFTargetMachine::createPassConfig(PassManagerBase &PM) {
|
|
return new BPFPassConfig(*this, PM);
|
|
}
|
|
|
|
void BPFTargetMachine::adjustPassManager(PassManagerBuilder &Builder) {
|
|
Builder.addExtension(
|
|
PassManagerBuilder::EP_EarlyAsPossible,
|
|
[&](const PassManagerBuilder &, legacy::PassManagerBase &PM) {
|
|
PM.add(createBPFAbstractMemberAccess(this));
|
|
PM.add(createBPFPreserveDIType());
|
|
PM.add(createBPFIRPeephole());
|
|
});
|
|
|
|
Builder.addExtension(
|
|
PassManagerBuilder::EP_Peephole,
|
|
[&](const PassManagerBuilder &, legacy::PassManagerBase &PM) {
|
|
PM.add(createCFGSimplificationPass(
|
|
SimplifyCFGOptions().hoistCommonInsts(true)));
|
|
});
|
|
Builder.addExtension(
|
|
PassManagerBuilder::EP_ModuleOptimizerEarly,
|
|
[&](const PassManagerBuilder &, legacy::PassManagerBase &PM) {
|
|
PM.add(createBPFAdjustOpt());
|
|
});
|
|
}
|
|
|
|
void BPFTargetMachine::registerPassBuilderCallbacks(PassBuilder &PB) {
|
|
PB.registerPipelineStartEPCallback(
|
|
[=](ModulePassManager &MPM, OptimizationLevel) {
|
|
FunctionPassManager FPM;
|
|
FPM.addPass(BPFAbstractMemberAccessPass(this));
|
|
FPM.addPass(BPFPreserveDITypePass());
|
|
FPM.addPass(BPFIRPeepholePass());
|
|
MPM.addPass(createModuleToFunctionPassAdaptor(std::move(FPM)));
|
|
});
|
|
PB.registerPeepholeEPCallback([=](FunctionPassManager &FPM,
|
|
OptimizationLevel Level) {
|
|
FPM.addPass(SimplifyCFGPass(SimplifyCFGOptions().hoistCommonInsts(true)));
|
|
});
|
|
PB.registerPipelineEarlySimplificationEPCallback(
|
|
[=](ModulePassManager &MPM, OptimizationLevel) {
|
|
MPM.addPass(BPFAdjustOptPass());
|
|
});
|
|
}
|
|
|
|
void BPFPassConfig::addIRPasses() {
|
|
addPass(createBPFCheckAndAdjustIR());
|
|
TargetPassConfig::addIRPasses();
|
|
}
|
|
|
|
TargetTransformInfo
|
|
BPFTargetMachine::getTargetTransformInfo(const Function &F) {
|
|
return TargetTransformInfo(BPFTTIImpl(this, F));
|
|
}
|
|
|
|
// Install an instruction selector pass using
|
|
// the ISelDag to gen BPF code.
|
|
bool BPFPassConfig::addInstSelector() {
|
|
addPass(createBPFISelDag(getBPFTargetMachine()));
|
|
|
|
return false;
|
|
}
|
|
|
|
void BPFPassConfig::addMachineSSAOptimization() {
|
|
addPass(createBPFMISimplifyPatchablePass());
|
|
|
|
// The default implementation must be called first as we want eBPF
|
|
// Peephole ran at last.
|
|
TargetPassConfig::addMachineSSAOptimization();
|
|
|
|
const BPFSubtarget *Subtarget = getBPFTargetMachine().getSubtargetImpl();
|
|
if (!DisableMIPeephole) {
|
|
if (Subtarget->getHasAlu32())
|
|
addPass(createBPFMIPeepholePass());
|
|
addPass(createBPFMIPeepholeTruncElimPass());
|
|
}
|
|
}
|
|
|
|
void BPFPassConfig::addPreEmitPass() {
|
|
addPass(createBPFMIPreEmitCheckingPass());
|
|
if (getOptLevel() != CodeGenOpt::None)
|
|
if (!DisableMIPeephole)
|
|
addPass(createBPFMIPreEmitPeepholePass());
|
|
}
|