6d4fb3d3bb
Only with SPV_INTEL_arbitrary_precision_integers SPIR-V Backend creates
arbitrary sized integer types (<= 64 bits). Without such extension and
according to the SPIR-V specification
`SPIRVGlobalRegistry::getOpTypeInt()` rounds integer sizes other than
8,16,32,64 up, to one of defined by the specification sizes. For the
`DuplicateTracker` class this means that several original LLVM types
(e.g., i2, i4) map to the same "OpTypeInt 8" instruction. This breaks
`DuplicateTracker`'s logic and leads to generation of invalid SPIR-V
code eventually.
For example,
```
define spir_func void @foo(i2 %a, i4 %b) {
entry:
%res2 = tail call i2 @llvm.bitreverse.i2(i2 %a)
%res4 = tail call i4 @llvm.bitreverse.i4(i4 %b)
ret void
}
declare i2 @llvm.bitreverse.i2(i2)
declare i4 @llvm.bitreverse.i4(i4)
```
after translation to SPIR-V would fail during validation (`spirv-val`)
due to two `OpTypeInt 8 0` instructions.
This PR fixes the issue by changing source LLVM type according to the
SPIR-V type that will be used in the emitted code.
28 lines
1.3 KiB
LLVM
28 lines
1.3 KiB
LLVM
; The goal of the test case is to ensure valid SPIR-V code emision
|
|
; on translation of integers with bit width less than 8.
|
|
|
|
; RUN: llc -O0 -mtriple=spirv64-unknown-unknown %s --spirv-ext=+SPV_KHR_bit_instructions -o - | FileCheck %s --check-prefix=CHECK-SPIRV
|
|
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv64-unknown-unknown %s --spirv-ext=+SPV_KHR_bit_instructions -o - -filetype=obj | spirv-val %}
|
|
|
|
; RUN: llc -O0 -mtriple=spirv32-unknown-unknown %s --spirv-ext=+SPV_KHR_bit_instructions -o - | FileCheck %s --check-prefix=CHECK-SPIRV
|
|
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv32-unknown-unknown %s --spirv-ext=+SPV_KHR_bit_instructions -o - -filetype=obj | spirv-val %}
|
|
|
|
; CHECK-SPIRV: OpCapability BitInstructions
|
|
; CHECK-SPIRV: OpExtension "SPV_KHR_bit_instructions"
|
|
; CHECK-SPIRV: %[[#CharTy:]] = OpTypeInt 8 0
|
|
; CHECK-SPIRV-NO: %[[#CharTy:]] = OpTypeInt 8 0
|
|
; CHECK-SPIRV-COUNT-2: %[[#]] = OpBitReverse %[[#CharTy]] %[[#]]
|
|
|
|
; TODO: Add a check to ensure that there's no behavior change of bitreverse operation
|
|
; between the LLVM-IR and SPIR-V for i2 and i4
|
|
|
|
define spir_func void @foo(i2 %a, i4 %b) {
|
|
entry:
|
|
%res2 = tail call i2 @llvm.bitreverse.i2(i2 %a)
|
|
%res4 = tail call i4 @llvm.bitreverse.i4(i4 %b)
|
|
ret void
|
|
}
|
|
|
|
declare i2 @llvm.bitreverse.i2(i2)
|
|
declare i4 @llvm.bitreverse.i4(i4)
|