914e607487
Rename listener callback names:
* `notifyOperationRemoved` -> `notifyOperationErased`
* `notifyBlockRemoved` -> `notifyBlockErased`
The current callback names are misnomers. The callbacks are triggered
when an operation/block is erased, not when it is removed (unlinked).
E.g.:
```c++
/// Notify the listener that the specified operation is about to be erased.
/// At this point, the operation has zero uses.
///
/// Note: This notification is not triggered when unlinking an operation.
virtual void notifyOperationErased(Operation *op) {}
```
This change is in preparation of adding listener support to the dialect
conversion. The dialect conversion internally unlinks IR before erasing
it at a later point of time. There is an important difference between
"remove" and "erase". Lister callback names should be accurate to avoid
confusion.
76 lines
2.6 KiB
C++
76 lines
2.6 KiB
C++
//===- TestConstantFold.cpp - Pass to test constant folding ---------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "mlir/Pass/Pass.h"
|
|
#include "mlir/Transforms/FoldUtils.h"
|
|
|
|
using namespace mlir;
|
|
|
|
namespace {
|
|
/// Simple constant folding pass.
|
|
struct TestConstantFold : public PassWrapper<TestConstantFold, OperationPass<>>,
|
|
public RewriterBase::Listener {
|
|
MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID(TestConstantFold)
|
|
|
|
StringRef getArgument() const final { return "test-constant-fold"; }
|
|
StringRef getDescription() const final {
|
|
return "Test operation constant folding";
|
|
}
|
|
// All constants in the operation post folding.
|
|
SmallVector<Operation *> existingConstants;
|
|
|
|
void foldOperation(Operation *op, OperationFolder &helper);
|
|
void runOnOperation() override;
|
|
|
|
void notifyOperationInserted(Operation *op,
|
|
OpBuilder::InsertPoint previous) override {
|
|
existingConstants.push_back(op);
|
|
}
|
|
void notifyOperationErased(Operation *op) override {
|
|
auto *it = llvm::find(existingConstants, op);
|
|
if (it != existingConstants.end())
|
|
existingConstants.erase(it);
|
|
}
|
|
};
|
|
} // namespace
|
|
|
|
void TestConstantFold::foldOperation(Operation *op, OperationFolder &helper) {
|
|
// Attempt to fold the specified operation, including handling unused or
|
|
// duplicated constants.
|
|
(void)helper.tryToFold(op);
|
|
}
|
|
|
|
void TestConstantFold::runOnOperation() {
|
|
existingConstants.clear();
|
|
|
|
// Collect and fold the operations within the operation.
|
|
SmallVector<Operation *, 8> ops;
|
|
getOperation()->walk<mlir::WalkOrder::PreOrder>([&](Operation *op) { ops.push_back(op); });
|
|
|
|
// Fold the constants in reverse so that the last generated constants from
|
|
// folding are at the beginning. This creates somewhat of a linear ordering to
|
|
// the newly generated constants that matches the operation order and improves
|
|
// the readability of test cases.
|
|
OperationFolder helper(&getContext(), /*listener=*/this);
|
|
for (Operation *op : llvm::reverse(ops))
|
|
foldOperation(op, helper);
|
|
|
|
// By the time we are done, we may have simplified a bunch of code, leaving
|
|
// around dead constants. Check for them now and remove them.
|
|
for (auto *cst : existingConstants) {
|
|
if (cst->use_empty())
|
|
cst->erase();
|
|
}
|
|
}
|
|
|
|
namespace mlir {
|
|
namespace test {
|
|
void registerTestConstantFold() { PassRegistration<TestConstantFold>(); }
|
|
} // namespace test
|
|
} // namespace mlir
|