caio/clice
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: simplify CompilationDatabase, extract ArgumentParser, remove pimpl (#371)

Browse Source 
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
ykiko
2026-03-27 13:15:49 +08:00
committed by GitHub
parent 498c975042
commit 46ba1e4db6
19 changed files with 1724 additions and 1824 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/unit/server/stateless_worker_tests.cpp
View File

@@ -94,12 +94,8 @@ TEST_CASE(BuildPCHRequest) {
worker::BuildPCHParams params;
params.file = hdr.path;
params.directory = "/tmp";
params.arguments = {"clang++",
"-resource-dir",
std::string(CompilationDatabase::resource_dir()),
"-x",
"c++-header",
hdr.path};
params.arguments =
{"clang++", "-resource-dir", std::string(resource_dir()), "-x", "c++-header", hdr.path};
params.content = "#pragma once\nint pch_global = 42;\n";
auto result = co_await w.peer->send_request(params);
@@ -157,7 +153,7 @@ TEST_CASE(BuildPCMRequest) {
params.directory = "/tmp";
params.arguments = {"clang++",
"-resource-dir",
std::string(CompilationDatabase::resource_dir()),
std::string(resource_dir()),
"-std=c++20",
"--precompile",
src.path};

11
tests/unit/server/worker_test_helpers.h
View File

@@ -10,6 +10,7 @@
#include <unistd.h>
#endif
#include "command/argument_parser.h"
#include "command/command.h"
#include "eventide/async/async.h"
#include "eventide/ipc/peer.h"
@@ -36,7 +37,7 @@ namespace et = eventide;
/// Resolve path to the clice binary for spawning workers.
inline std::string clice_binary() {
auto res_dir = CompilationDatabase::resource_dir();
auto res_dir = resource_dir();
// res_dir is <build>/lib/clang/...
// clice binary is at <build>/bin/clice
auto build_dir = llvm::sys::path::parent_path(
@@ -74,12 +75,8 @@ struct TempFile {
/// Build compile arguments for a source file, including -resource-dir.
inline std::vector<std::string> make_args(const std::string& file_path,
const std::string& extra = "") {
std::vector<std::string> args = {"clang++",
"-fsyntax-only",
"-resource-dir",
std::string(CompilationDatabase::resource_dir()),
"-c",
file_path};
std::vector<std::string> args =
{"clang++", "-fsyntax-only", "-resource-dir", std::string(resource_dir()), "-c", file_path};
if(!extra.empty()) {
args.insert(args.begin() + 1, extra);
}