066e10c5d4
Replace silent null returns with proper LSP errors (kota::fail) for feature requests on closed documents, failed compilations, invalid positions, and unresolvable hierarchy items. Add client notifications (window/logMessage) for key failures so integration tests can observe errors without reading server logs. Expand logging coverage in compilation pipeline (compile args, compilation phases, worker results). Improve test infrastructure: conditional log dump on failure, yield-based workspace fixture with post-test cleanup, named timing constants replacing hardcoded sleeps, and log message capture/assertion helpers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
71 lines
2.4 KiB
Python
71 lines
2.4 KiB
Python
"""Diagnostic and log message assertion helpers for integration tests."""
|
|
|
|
from lsprotocol.types import Diagnostic, DiagnosticSeverity, MessageType
|
|
|
|
|
|
def get_errors(diagnostics: list[Diagnostic]) -> list[Diagnostic]:
|
|
"""Filter diagnostics to errors only (severity == 1)."""
|
|
return [d for d in diagnostics if d.severity == DiagnosticSeverity.Error]
|
|
|
|
|
|
def assert_no_errors(client, uri: str, msg: str = "") -> None:
|
|
"""Assert that there are no error-level diagnostics for the given URI."""
|
|
diags = client.diagnostics.get(uri, [])
|
|
errors = get_errors(diags)
|
|
if msg:
|
|
assert len(errors) == 0, f"{msg}: {errors}"
|
|
else:
|
|
assert len(errors) == 0, f"Expected no errors, got: {errors}"
|
|
|
|
|
|
def assert_has_errors(client, uri: str, msg: str = "") -> None:
|
|
"""Assert that there is at least one error-level diagnostic for the given URI."""
|
|
diags = client.diagnostics.get(uri, [])
|
|
errors = get_errors(diags)
|
|
if msg:
|
|
assert len(errors) > 0, msg
|
|
else:
|
|
assert len(errors) > 0, "Expected at least one error diagnostic"
|
|
|
|
|
|
def assert_diagnostics_count(
|
|
client,
|
|
uri: str,
|
|
count: int,
|
|
*,
|
|
severity: int | None = None,
|
|
) -> None:
|
|
"""Assert exact number of diagnostics, optionally filtered by severity."""
|
|
diags = client.diagnostics.get(uri, [])
|
|
if severity is not None:
|
|
diags = [d for d in diags if d.severity == severity]
|
|
assert len(diags) == count, (
|
|
f"Expected {count} diagnostics (severity={severity}), got {len(diags)}: {diags}"
|
|
)
|
|
|
|
|
|
def assert_clean_compile(client, uri: str) -> None:
|
|
"""Assert the file compiled without any diagnostics at all."""
|
|
diags = client.diagnostics.get(uri, [])
|
|
assert len(diags) == 0, f"Expected clean compile, got: {diags}"
|
|
|
|
|
|
def has_log_message(
|
|
client, substring: str, *, severity: MessageType | None = None
|
|
) -> bool:
|
|
"""Check if any log message contains the given substring."""
|
|
for msg in client.log_messages:
|
|
if severity is not None and msg.type != severity:
|
|
continue
|
|
if substring in msg.message:
|
|
return True
|
|
return False
|
|
|
|
|
|
def assert_no_log_errors(client) -> None:
|
|
"""Assert that no error-level log messages were received."""
|
|
errors = [m for m in client.log_messages if m.type == MessageType.Error]
|
|
assert len(errors) == 0, (
|
|
f"Expected no log errors, got: {[e.message for e in errors]}"
|
|
)
|