## Summary - **Use `Tester` as fixture base** for all test suites that need compilation, replacing `TesterFixture` and removing redundant `tester.clear()` calls (eventide zest now creates fresh instances per TEST_CASE) - **Remove local `Tester` variables** in `compilation_tests`, `template_resolver_tests`, `selection_tests` — use inherited fixture members directly - **Normalize helper naming**: `expect_xxx` → `EXPECT_XXX`, `go_to_definition` → `GO_TO_DEFINITION` for consistency - **Extract shared `test/cdb_helper.h`**: deduplicate `CDBEntry`, `json_escape`, `build_cdb_json` from `dependency_graph_tests` and `compile_graph_integration_tests` - **Add new test files/cases**: `project_index_tests.cpp`, expanded `tu_index_tests`, `merged_index_tests`, `compilation_tests` ## Test plan - [x] All existing unit tests pass - [x] New index tests (TUIndex, MergedIndex, ProjectIndex) pass - [x] Compilation tests (PCH, PCM, stop) pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Standardized test fixtures and helper naming, moved suites to a shared fixture, and unified in-memory VFS and compile flows. * Added broad new coverage: indexing, project indexing, compilation/PCH, diagnostics, semantic features, and many targeted unit cases. * Introduced a small compile-database helper and improved driver-style test compilation paths. * **Chores** * Consolidated and reorganized test utilities and tester APIs for easier maintenance and reuse. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
191 lines
5.9 KiB
C++
191 lines
5.9 KiB
C++
#include "test/test.h"
|
|
#include "compile/compilation.h"
|
|
#include "compile/diagnostic.h"
|
|
|
|
namespace clice::testing {
|
|
|
|
// see llvm/clang/include/clang/AST/ASTDiagnostic.h
|
|
void dump_arg(clang::DiagnosticsEngine::ArgumentKind kind, std::uint64_t value) {
|
|
switch(kind) {
|
|
case clang::DiagnosticsEngine::ak_identifierinfo: {
|
|
clang::IdentifierInfo* info = reinterpret_cast<clang::IdentifierInfo*>(value);
|
|
llvm::outs() << info->getName();
|
|
break;
|
|
}
|
|
|
|
case clang::DiagnosticsEngine::ak_qual: {
|
|
clang::Qualifiers qual = clang::Qualifiers::fromOpaqueValue(value);
|
|
llvm::outs() << qual.getAsString();
|
|
break;
|
|
}
|
|
|
|
case clang::DiagnosticsEngine::ak_qualtype: {
|
|
clang::QualType type =
|
|
clang::QualType::getFromOpaquePtr(reinterpret_cast<void*>(value));
|
|
llvm::outs() << type.getAsString();
|
|
break;
|
|
}
|
|
|
|
case clang::DiagnosticsEngine::ak_qualtype_pair: {
|
|
clang::TemplateDiffTypes& TDT = *reinterpret_cast<clang::TemplateDiffTypes*>(value);
|
|
clang::QualType type1 =
|
|
clang::QualType::getFromOpaquePtr(reinterpret_cast<void*>(TDT.FromType));
|
|
clang::QualType type2 =
|
|
clang::QualType::getFromOpaquePtr(reinterpret_cast<void*>(TDT.ToType));
|
|
llvm::outs() << type1.getAsString() << " -> " << type2.getAsString();
|
|
break;
|
|
}
|
|
|
|
case clang::DiagnosticsEngine::ak_declarationname: {
|
|
clang::DeclarationName name = clang::DeclarationName::getFromOpaqueInteger(value);
|
|
llvm::outs() << name.getAsString();
|
|
break;
|
|
}
|
|
|
|
case clang::DiagnosticsEngine::ak_nameddecl: {
|
|
clang::NamedDecl* decl = reinterpret_cast<clang::NamedDecl*>(value);
|
|
llvm::outs() << decl->getNameAsString();
|
|
break;
|
|
}
|
|
|
|
case clang::DiagnosticsEngine::ak_nestednamespec: {
|
|
clang::NestedNameSpecifier* spec = reinterpret_cast<clang::NestedNameSpecifier*>(value);
|
|
spec->dump();
|
|
break;
|
|
}
|
|
|
|
case clang::DiagnosticsEngine::ak_declcontext: {
|
|
clang::DeclContext* context = reinterpret_cast<clang::DeclContext*>(value);
|
|
llvm::outs() << context->getDeclKindName();
|
|
break;
|
|
}
|
|
|
|
case clang::DiagnosticsEngine::ak_attr: {
|
|
clang::Attr* attr = reinterpret_cast<clang::Attr*>(value);
|
|
break;
|
|
// attr->dump();
|
|
}
|
|
|
|
default: {
|
|
std::abort();
|
|
}
|
|
}
|
|
|
|
llvm::outs() << "\n";
|
|
}
|
|
|
|
namespace {
|
|
|
|
using namespace clice;
|
|
|
|
TEST_SUITE(Diagnostic) {
|
|
|
|
/// Holds VFS-backed CompilationParams with proper string ownership.
|
|
struct DiagParams {
|
|
llvm::IntrusiveRefCntPtr<TestVFS> vfs;
|
|
std::vector<std::string> owned_args;
|
|
CompilationParams params;
|
|
|
|
DiagParams(llvm::StringRef content, std::initializer_list<const char*> extra_args = {}) {
|
|
vfs = llvm::makeIntrusiveRefCnt<TestVFS>();
|
|
vfs->add("main.cpp", content);
|
|
params.vfs = vfs;
|
|
|
|
owned_args.push_back("clang++");
|
|
owned_args.push_back("-ffreestanding");
|
|
owned_args.push_back("-Xclang");
|
|
owned_args.push_back("-undef");
|
|
for(auto a: extra_args) {
|
|
owned_args.push_back(a);
|
|
}
|
|
owned_args.push_back(TestVFS::path("main.cpp"));
|
|
|
|
for(auto& s: owned_args) {
|
|
params.arguments.push_back(s.c_str());
|
|
}
|
|
}
|
|
};
|
|
|
|
TEST_CASE(TargetError) {
|
|
auto vfs = llvm::makeIntrusiveRefCnt<TestVFS>();
|
|
vfs->add("main.cpp", "");
|
|
|
|
std::string main_path = TestVFS::path("main.cpp");
|
|
CompilationParams params;
|
|
params.vfs = vfs;
|
|
params.arguments = {"clang++", "-target", "aa-bb-cc", main_path.c_str()};
|
|
|
|
auto unit = compile(params);
|
|
ASSERT_TRUE(unit.setup_fail());
|
|
ASSERT_TRUE(unit.diagnostics().size() == 1);
|
|
|
|
auto& diag = unit.diagnostics()[0];
|
|
EXPECT_EQ(diag.id.diagnostic_code(), "err_target_unknown_triple");
|
|
EXPECT_EQ(diag.id.level, DiagnosticLevel::Error);
|
|
EXPECT_EQ(diag.id.source, DiagnosticSource::Clang);
|
|
EXPECT_TRUE(diag.fid.isInvalid());
|
|
EXPECT_TRUE(!diag.range.valid());
|
|
EXPECT_EQ(diag.message, "unknown target triple 'aa-bb-cc'");
|
|
}
|
|
|
|
TEST_CASE(Error) {
|
|
DiagParams dp("int main() { return 0 }");
|
|
|
|
auto unit = compile(dp.params);
|
|
ASSERT_TRUE(unit.completed());
|
|
ASSERT_TRUE(unit.diagnostics().size() == 1);
|
|
|
|
auto& diag = unit.diagnostics()[0];
|
|
EXPECT_EQ(diag.id.diagnostic_code(), "err_expected_semi_after_stmt");
|
|
EXPECT_EQ(diag.id.level, DiagnosticLevel::Error);
|
|
EXPECT_EQ(diag.id.source, DiagnosticSource::Clang);
|
|
EXPECT_EQ(diag.fid, unit.interested_file());
|
|
EXPECT_TRUE(diag.range.valid());
|
|
EXPECT_EQ(diag.message, "expected ';' after return statement");
|
|
};
|
|
|
|
TEST_CASE(Warning) {
|
|
DiagParams dp("int main() { int x; return 0; }", {"-Wall", "-Wunused-variable"});
|
|
|
|
auto unit = compile(dp.params);
|
|
ASSERT_TRUE(unit.completed());
|
|
ASSERT_EQ(unit.diagnostics().size(), 1);
|
|
|
|
auto& diag = unit.diagnostics()[0];
|
|
EXPECT_EQ(diag.id.diagnostic_code(), "warn_unused_variable");
|
|
EXPECT_EQ(diag.id.level, DiagnosticLevel::Warning);
|
|
EXPECT_EQ(diag.id.source, DiagnosticSource::Clang);
|
|
EXPECT_TRUE(diag.range.valid());
|
|
EXPECT_TRUE(diag.message.find("unused variable") != std::string::npos);
|
|
}
|
|
|
|
TEST_CASE(PCHError) {
|
|
/// Any error in compilation will result in failure on generating PCH or PCM.
|
|
DiagParams dp(R"(
|
|
void foo() {}
|
|
void foo() {}
|
|
)");
|
|
dp.params.output_file = "fake.pch";
|
|
|
|
PCHInfo info;
|
|
auto unit = compile(dp.params, info);
|
|
ASSERT_TRUE(unit.fatal_error());
|
|
}
|
|
|
|
TEST_CASE(ASTError) {
|
|
/// Event fatal error may generate incomplete AST, but it is fine.
|
|
DiagParams dp(R"(
|
|
void foo() {}
|
|
void foo() {}
|
|
)");
|
|
|
|
auto unit = compile(dp.params);
|
|
ASSERT_TRUE(unit.completed());
|
|
}
|
|
|
|
}; // TEST_SUITE(Diagnostic)
|
|
|
|
} // namespace
|
|
|
|
} // namespace clice::testing
|