[llvm-cfi-verify] Avoid creating temporary instances of std::string (NFC) (#142524)
symbolizeInlinedCode and symbolizeCode take StringRef as the first parameter. We don't need to create temporary instances of std::string only to be converted back to StringRef.
This commit is contained in:
@@ -278,8 +278,7 @@ Expected<DIInliningInfo>
|
||||
FileAnalysis::symbolizeInlinedCode(object::SectionedAddress Address) {
|
||||
assert(Symbolizer != nullptr && "Symbolizer is invalid.");
|
||||
|
||||
return Symbolizer->symbolizeInlinedCode(std::string(Object->getFileName()),
|
||||
Address);
|
||||
return Symbolizer->symbolizeInlinedCode(Object->getFileName(), Address);
|
||||
}
|
||||
|
||||
CFIProtectionStatus
|
||||
@@ -523,9 +522,8 @@ void FileAnalysis::parseSectionContents(ArrayRef<uint8_t> SectionBytes,
|
||||
|
||||
// Check if this instruction exists in the range of the DWARF metadata.
|
||||
if (!IgnoreDWARFFlag) {
|
||||
auto LineInfo =
|
||||
Symbolizer->symbolizeCode(std::string(Object->getFileName()),
|
||||
{VMAddress, Address.SectionIndex});
|
||||
auto LineInfo = Symbolizer->symbolizeCode(
|
||||
Object->getFileName(), {VMAddress, Address.SectionIndex});
|
||||
if (!LineInfo) {
|
||||
handleAllErrors(LineInfo.takeError(), [](const ErrorInfoBase &E) {
|
||||
errs() << "Symbolizer failed to get line: " << E.message() << "\n";
|
||||
|
||||
Reference in New Issue
Block a user