caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Verifier] Reject dllexport with non-default visibility

Browse Source 
Add a visibility check for dllimport and dllexport. Note: dllimport with a
non-default visibility (implicit dso_local) is already rejected, but with a less
clear dso_local error.

The MC level visibility `MCSA_Exported` (D123951) is mapped from IR level
default visibility when dllexport is specified. The D123951 error is now very
difficult to trigger (needs to disable the IR verifier).

Reviewed By: mstorsjo

Differential Revision: https://reviews.llvm.org/D133267
This commit is contained in:
Fangrui Song
2022-09-05 10:53:41 -07:00
parent 91d8324366
commit 2417618d5c
4 changed files with 28 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
llvm/lib/IR/Verifier.cpp
View File

@@ -663,7 +663,13 @@ void Verifier::visitGlobalValue(const GlobalValue &GV) {
if (GV.isDeclarationForLinker())
Check(!GV.hasComdat(), "Declaration may not be in a Comdat!", &GV);
if (GV.hasDLLExportStorageClass()) {
Check(GV.hasDefaultVisibility(),
"dllexport GlobalValue must have default visibility", &GV);
}
if (GV.hasDLLImportStorageClass()) {
Check(GV.hasDefaultVisibility(),
"dllimport GlobalValue must have default visibility", &GV);
Check(!GV.isDSOLocal(), "GlobalValue with DLLImport Storage is dso_local!",
&GV);

16
llvm/test/CodeGen/PowerPC/aix-xcoff-exported-nondefault.ll
View File

@@ -1,15 +1,5 @@
; RUN: not --crash llc -verify-machineinstrs -mtriple powerpc-ibm-aix-xcoff 2>&1 < %s | \
; RUN: FileCheck %s
; RUN: not --crash llc -verify-machineinstrs -mtriple powerpc64-ibm-aix-xcoff 2>&1 < %s |\
; RUN: FileCheck %s
; RUN: not llc -filetype=null -mtriple powerpc-ibm-aix-xcoff 2>&1 %s | FileCheck %s
; RUN: not llc -filetype=null -mtriple powerpc64-ibm-aix-xcoff 2>&1 %s | FileCheck %s
; RUN: not --crash llc -verify-machineinstrs -mtriple powerpc-ibm-aix-xcoff \
; RUN: -filetype=obj -o %t.o < %s 2>&1 | \
; RUN: FileCheck %s
; RUN: not --crash llc -verify-machineinstrs -mtriple powerpc64-ibm-aix-xcoff \
; RUN: -filetype=obj -o %t.o 2>&1 < %s 2>&1 | \
; RUN: FileCheck %s
; CHECK: LLVM ERROR: Cannot not be both dllexport and non-default visibility
; CHECK: dllexport GlobalValue must have default visibility
@b_e = hidden dllexport global i32 0, align 4

2
llvm/test/Feature/globalvars.ll
View File

@@ -16,5 +16,5 @@ define i32 @foo(i32 %blah) {
ret i32 %blah
}
@1 = hidden dllexport global i32 42
@1 = default dllexport global i32 42
@2 = dllexport global i32 42

18
llvm/test/Verifier/dllstorage.ll Normal file
View File

@@ -0,0 +1,18 @@
; RUN: not opt -verify %s 2>&1 | FileCheck %s
target datalayout = "e-m:w-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-pc-windows-gnu"
; CHECK: dllexport GlobalValue must have default visibility
; CHECK-NEXT: ptr @dllexport_hidden
declare hidden dllexport i32 @dllexport_hidden()
; CHECK: dllexport GlobalValue must have default visibility
; CHECK-NEXT: ptr @dllexport_protected
declare protected dllexport i32 @dllexport_protected()
; CHECK: dllimport GlobalValue must have default visibility
; CHECK-NEXT: ptr @dllimport_hidden
declare hidden dllimport i32 @dllimport_hidden()
; CHECK: dllimport GlobalValue must have default visibility
; CHECK-NEXT: ptr @dllimport_protected
declare protected dllimport i32 @dllimport_protected()