caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[lldb] Remove redundant DemangledNameInfo::operator==

Browse Source 
This wasn't defined correctly and was unused. And it was causing a CI
build failure:
```
/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu-dwarf5/llvm-project/lldb/include/lldb/Core/DemangledNameInfo.h: In function ‘bool lldb_private::operator==(const lldb_private::DemangledNameInfo&, const lldb_private::DemangledNameInfo&)’:
/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu-dwarf5/llvm-project/lldb/include/lldb/Core/DemangledNameInfo.h:60:25: error: ‘const struct lldb_private::DemangledNameInfo’ has no member named ‘QualifiersRange’
   60 |                     lhs.QualifiersRange) ==
      |                         ^~~~~~~~~~~~~~~
/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu-dwarf5/llvm-project/lldb/include/lldb/Core/DemangledNameInfo.h:62:25: error: ‘const struct lldb_private::DemangledNameInfo’ has no member named ‘QualifiersRange’
   62 |                     lhs.QualifiersRange);
      |                         ^~~~~~~~~~~~~~~
111.469 [1284/7/3896] Building CXX object tools/lldb/source/Expression/CMakeFiles/lldbExpression.dir/ObjectFileJIT.cpp.o
111.470 [1284/6/3897] Building CXX object tools/lldb/source/Expression/CMakeFiles/lldbExpression.dir/Materializer.cpp.o
111.492 [1284/5/3898] Building CXX object tools/lldb/source/Expression/CMakeFiles/lldbExpression.dir/REPL.cpp.o
111.496 [1284/4/3899] Building CXX object tools/lldb/source/Expression/CMakeFiles/lldbExpression.dir/UserExpression.cpp.o
111.695 [1284/3/3900] Building CXX object tools/lldb/source/Commands/CMakeFiles/lldbCommands.dir/CommandObjectTarget.cpp.o
112.944 [1284/2/3901] Linking CXX shared library lib/libclang.so.21.0.0git
113.098 [1284/1/3902] Linking CXX shared library lib/libclang-cpp.so.21.0git
```
This commit is contained in:
Michael Buch
2025-04-25 10:17:20 +01:00
parent 3e56f5f418
commit 5a645109c3
1 changed files with 0 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
lldb/include/lldb/Core/DemangledNameInfo.h
View File

@@ -64,19 +64,6 @@ struct DemangledNameInfo {
return BasenameRange.second > BasenameRange.first &&
BasenameRange.second > 0;
}
friend bool operator==(const DemangledNameInfo &lhs,
const DemangledNameInfo &rhs) {
return std::tie(lhs.BasenameRange, lhs.ArgumentsRange, lhs.ScopeRange,
lhs.QualifiersRange) ==
std::tie(rhs.BasenameRange, rhs.ArgumentsRange, rhs.ScopeRange,
lhs.QualifiersRange);
}
friend bool operator!=(const DemangledNameInfo &lhs,
const DemangledNameInfo &rhs) {
return !(lhs == rhs);
}
};
/// An OutputBuffer which keeps a record of where certain parts of a