caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[lldb] Remove "error:" prefix from reverse execute error messages

Browse Source 
Errors will get "error:" prefixes automatically so this is not needed.
This commit is contained in:
David Spickett
2025-04-29 14:00:14 +00:00
parent 2e713af20e
commit 65b0d21eb4
5 changed files with 6 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lldb/include/lldb/Target/Process.h
View File

@@ -1114,10 +1114,9 @@ public:
virtual Status DoResume(lldb::RunDirection direction) {
if (direction == lldb::RunDirection::eRunForward)
return Status::FromErrorStringWithFormatv(
"error: {0} does not support resuming processes", GetPluginName());
"{0} does not support resuming processes", GetPluginName());
return Status::FromErrorStringWithFormatv(
"error: {0} does not support reverse execution of processes",
GetPluginName());
"{0} does not support reverse execution of processes", GetPluginName());
}
/// Called after resuming a process.

2
lldb/source/API/SBProcess.cpp
View File

@@ -590,7 +590,7 @@ SBError SBProcess::ContinueInDirection(RunDirection direction) {
if (direction == RunDirection::eRunReverse &&
!process_sp->SupportsReverseDirection())
return Status::FromErrorStringWithFormatv(
"error: {0} does not support reverse execution of processes",
"{0} does not support reverse execution of processes",
GetPluginName());
process_sp->SetBaseDirection(direction);
}

3
lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
View File

@@ -403,8 +403,7 @@ Status ProcessKDP::DoResume(RunDirection direction) {
if (direction == RunDirection::eRunReverse)
return Status::FromErrorStringWithFormatv(
"error: {0} does not support reverse execution of processes",
GetPluginName());
"{0} does not support reverse execution of processes", GetPluginName());
// Only start the async thread if we try to do any process control
if (!m_async_thread.IsJoinable())

3
lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
View File

@@ -242,8 +242,7 @@ Status ProcessWindows::DoResume(RunDirection direction) {
if (direction == RunDirection::eRunReverse) {
return Status::FromErrorStringWithFormatv(
"error: {0} does not support reverse execution of processes",
GetPluginName());
"{0} does not support reverse execution of processes", GetPluginName());
}
Status error;

3
lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp
View File

@@ -191,8 +191,7 @@ Status ScriptedProcess::DoResume(RunDirection direction) {
return GetInterface().Resume();
// FIXME: Pipe reverse continue through Scripted Processes
return Status::FromErrorStringWithFormatv(
"error: {0} does not support reverse execution of processes",
GetPluginName());
"{0} does not support reverse execution of processes", GetPluginName());
}
Status ScriptedProcess::DoAttach(const ProcessAttachInfo &attach_info) {