caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[DWARF] Fix arity of DW_OP_bra (#114136)

Browse Source 
Found by my proof-of-concept DWARF expression evaluator fuzzer.
This commit is contained in:
Jonas Devlieghere
2024-10-29 16:41:01 -07:00
committed by GitHub
parent 0f8dbb2fac
commit 75b37c3191
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lldb/unittests/Expression/DWARFExpressionTest.cpp
View File

@@ -181,6 +181,9 @@ TEST(DWARFExpression, DW_OP_bra) {
}),
// clang-format on
llvm::HasValue(0x42));
EXPECT_THAT_ERROR(Evaluate({DW_OP_bra, 0x01, 0x00}).takeError(),
llvm::Failed());
}
TEST(DWARFExpression, DW_OP_convert) {

2
llvm/include/llvm/BinaryFormat/Dwarf.def
View File

@@ -728,7 +728,7 @@ HANDLE_DW_OP(0x24, shl, 0, 2, 2, DWARF)
HANDLE_DW_OP(0x25, shr, 0, 2, 2, DWARF)
HANDLE_DW_OP(0x26, shra, 0, 2, 2, DWARF)
HANDLE_DW_OP(0x27, xor, 0, 2, 2, DWARF)
HANDLE_DW_OP(0x28, bra, 1, 0, 2, DWARF)
HANDLE_DW_OP(0x28, bra, 1, 1, 2, DWARF)
HANDLE_DW_OP(0x29, eq, 0, 2, 2, DWARF)
HANDLE_DW_OP(0x2a, ge, 0, 2, 2, DWARF)
HANDLE_DW_OP(0x2b, gt, 0, 2, 2, DWARF)