caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[mlir][cmake] Enable -Wundef. (#84011)

Browse Source 
This is another follow-up of #83004, which fixed a bug due to some
macros not being defined in some situations. By raising warnings on
undefined macros, this kind of bug is less likely to be introduced.
Similar to #83004, the fix is probably adding an include to
`mlir-config.h` (and potentially defining the macro there).
This commit is contained in:
Ingo Müller
2024-03-06 14:15:17 +01:00
committed by GitHub
parent 099045a045
commit 8406f8023d
2 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
mlir/CMakeLists.txt
View File

@@ -70,6 +70,12 @@ endif()
check_c_compiler_flag("-Werror=implicit-function-declaration" C_SUPPORTS_WERROR_IMPLICIT_FUNCTION_DECLARATION)
append_if(C_SUPPORTS_WERROR_IMPLICIT_FUNCTION_DECLARATION "-Werror=implicit-function-declaration" CMAKE_C_FLAGS)
# Warn on undefined macros. This is often an indication that an include to
# `mlir-config.h` or similar is missing.
check_c_compiler_flag("-Wundef" C_SUPPORTS_WUNDEF)
append_if(C_SUPPORTS_WUNDEF "-Wundef" CMAKE_C_FLAGS)
append_if(C_SUPPORTS_WUNDEF "-Wundef" CMAKE_CXX_FLAGS)
# Forbid mismatch between declaration and definition for class vs struct. This is
# harmless on Unix systems, but it'll be a ticking bomb for MSVC/Windows systems
# where it creeps into the ABI.

7
mlir/include/mlir/Config/mlir-config.h.cmake
View File

@@ -8,6 +8,13 @@
/* This file enumerates variables from the MLIR configuration so that they
can be in exported headers and won't override package specific directives.
Defining the variables here is preferable over specifying them in CMake files
via `target_compile_definitions` because it is easier to ensure that they are
defined consistently across all targets: They are guaranteed to be 0/1
variables thanks to #cmakedefine01, so we can test with `#if` and find
missing definitions or includes with `-Wundef`. With `#ifdef`, these mistakes
can go unnoticed.
This is a C header that can be included in the mlir-c headers. */
#ifndef MLIR_CONFIG_H