caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[lldb] Avoid repeated map lookups (NFC) (#112823)

Browse Source
This commit is contained in:
Kazu Hirata
2024-10-18 10:40:13 -07:00
committed by GitHub
parent 9120adea50
commit a01d7df090
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lldb/source/Commands/CommandObjectMultiword.cpp
View File

@@ -102,11 +102,9 @@ llvm::Error CommandObjectMultiword::LoadUserSubcommand(
std::string str_name(name);
auto pos = m_subcommand_dict.find(str_name);
if (pos == m_subcommand_dict.end()) {
m_subcommand_dict[str_name] = cmd_obj_sp;
auto [pos, inserted] = m_subcommand_dict.try_emplace(str_name, cmd_obj_sp);
if (inserted)
return llvm::Error::success();
}
const char *error_str = nullptr;
if (!can_replace)
@@ -117,7 +115,7 @@ llvm::Error CommandObjectMultiword::LoadUserSubcommand(
if (error_str) {
return llvm::createStringError(llvm::inconvertibleErrorCode(), error_str);
}
m_subcommand_dict[str_name] = cmd_obj_sp;
pos->second = cmd_obj_sp;
return llvm::Error::success();
}