[ASTMatchers] Migrate away from ArrayRef(std::nullopt) (NFC) (#145840)
ArrayRef has a constructor that accepts std::nullopt. This
constructor dates back to the days when we still had llvm::Optional.
Since the use of std::nullopt outside the context of std::optional is
kind of abuse and not intuitive to new comers, I would like to move
away from the constructor and eventually remove it.
This patch migrates away from std::nullopt in favor of ArrayRef<T>().
Note that {} would be ambiguous for perfect forwarding to work here.
This commit is contained in:
@@ -1060,7 +1060,7 @@ makeMatcherAutoMarshall(ReturnType (*Func)(), StringRef MatcherName) {
|
||||
BuildReturnTypeVector<ReturnType>::build(RetTypes);
|
||||
return std::make_unique<FixedArgCountMatcherDescriptor>(
|
||||
matcherMarshall0<ReturnType>, reinterpret_cast<void (*)()>(Func),
|
||||
MatcherName, RetTypes, std::nullopt);
|
||||
MatcherName, RetTypes, ArrayRef<ArgKind>());
|
||||
}
|
||||
|
||||
/// 1-arg overload
|
||||
|
||||
Reference in New Issue
Block a user