caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[mlir] Add getAlias for OpAsmTypeInterface (#126364)

Browse Source 
See
https://discourse.llvm.org/t/rfc-introduce-opasm-type-attr-interface-for-pretty-print-in-asmprinter/83792
for detailed introduction.

This PR should be rebased once #124721 is merged.

This PR adds

* Definition of `getAlias` for `OpAsmTypeInterface`
* Integration of `OpAsmTypeInterface` with `AsmPrinter` alias handling
part

This is partly in response to
https://github.com/llvm/llvm-project/pull/124721/files#r1940399862

Cc @River707 for review.
This commit is contained in:
Hongren Zheng
2025-02-19 02:28:49 +08:00
committed by GitHub
parent f796747a17
commit aa16ca3422
5 changed files with 31 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
mlir/include/mlir/IR/OpAsmInterface.td
View File

@@ -127,6 +127,13 @@ def OpAsmTypeInterface : TypeInterface<"OpAsmTypeInterface"> {
"void", "getAsmName",
(ins "::mlir::OpAsmSetNameFn":$setNameFn), "", ";"
>,
InterfaceMethod<[{
Get a name to use when generating an alias for this type.
}],
"::mlir::OpAsmDialectInterface::AliasResult", "getAlias",
(ins "::llvm::raw_ostream&":$os), "",
"return ::mlir::OpAsmDialectInterface::AliasResult::NoAlias;"
>,
];
}

15
mlir/lib/IR/AsmPrinter.cpp
View File

@@ -1163,14 +1163,13 @@ void AliasInitializer::generateAlias(T symbol, InProgressAliasInfo &alias,
OpAsmDialectInterface::AliasResult symbolInterfaceResult =
OpAsmDialectInterface::AliasResult::NoAlias;
if constexpr (std::is_base_of_v<Attribute, T>) {
if (auto symbolInterface = dyn_cast<OpAsmAttrInterface>(symbol)) {
symbolInterfaceResult = symbolInterface.getAlias(aliasOS);
if (symbolInterfaceResult !=
OpAsmDialectInterface::AliasResult::NoAlias) {
nameBuffer = std::move(aliasBuffer);
assert(!nameBuffer.empty() && "expected valid alias name");
}
using InterfaceT = std::conditional_t<std::is_base_of_v<Attribute, T>,
OpAsmAttrInterface, OpAsmTypeInterface>;
if (auto symbolInterface = dyn_cast<InterfaceT>(symbol)) {
symbolInterfaceResult = symbolInterface.getAlias(aliasOS);
if (symbolInterfaceResult != OpAsmDialectInterface::AliasResult::NoAlias) {
nameBuffer = std::move(aliasBuffer);
assert(!nameBuffer.empty() && "expected valid alias name");
}
}

10
mlir/test/IR/op-asm-interface.mlir
View File

@@ -61,6 +61,16 @@ func.func @block_argument_name_from_op_asm_type_interface_asmprinter() {
// -----
// CHECK: !op_asm_type_interface_type =
!type = !test.op_asm_type_interface
func.func @alias_from_op_asm_type_interface() {
%0 = "test.result_name_from_type"() : () -> !type
return
}
// -----
//===----------------------------------------------------------------------===//
// Test OpAsmAttrInterface
//===----------------------------------------------------------------------===//

2
mlir/test/lib/Dialect/Test/TestTypeDefs.td
View File

@@ -399,7 +399,7 @@ def TestTypeVerification : Test_Type<"TestTypeVerification"> {
}
def TestTypeOpAsmTypeInterface : Test_Type<"TestTypeOpAsmTypeInterface",
[DeclareTypeInterfaceMethods<OpAsmTypeInterface, ["getAsmName"]>]> {
[DeclareTypeInterfaceMethods<OpAsmTypeInterface, ["getAsmName", "getAlias"]>]> {
let mnemonic = "op_asm_type_interface";
}

6
mlir/test/lib/Dialect/Test/TestTypes.cpp
View File

@@ -537,3 +537,9 @@ void TestTypeOpAsmTypeInterfaceType::getAsmName(
OpAsmSetNameFn setNameFn) const {
setNameFn("op_asm_type_interface");
}
::mlir::OpAsmDialectInterface::AliasResult
TestTypeOpAsmTypeInterfaceType::getAlias(::llvm::raw_ostream &os) const {
os << "op_asm_type_interface_type";
return ::mlir::OpAsmDialectInterface::AliasResult::FinalAlias;
}