[lldb] Avoid confusing reproducer crashes when initialization failed

During active replay, the ::Initialize call is replayed like any other
SB API call and the return value is ignored. Since we can't intercept
this, we terminate here before the uninitialized debugger inevitably
crashes.

Differential revision: https://reviews.llvm.org/D90987
This commit is contained in:
Jonas Devlieghere
2020-11-09 08:47:08 -08:00
parent fd3cad7a60
commit b31d787949

View File

@@ -15,6 +15,7 @@
#include "lldb/Initialization/SystemInitializerCommon.h"
#include "lldb/Interpreter/CommandInterpreter.h"
#include "lldb/Target/ProcessTrace.h"
#include "lldb/Utility/Reproducer.h"
#include "lldb/Utility/Timer.h"
#include "llvm/Support/TargetSelect.h"
@@ -34,8 +35,16 @@ SystemInitializerFull::SystemInitializerFull() = default;
SystemInitializerFull::~SystemInitializerFull() = default;
llvm::Error SystemInitializerFull::Initialize() {
if (auto e = SystemInitializerCommon::Initialize())
return e;
llvm::Error error = SystemInitializerCommon::Initialize();
if (error) {
// During active replay, the ::Initialize call is replayed like any other
// SB API call and the return value is ignored. Since we can't intercept
// this, we terminate here before the uninitialized debugger inevitably
// crashes.
if (repro::Reproducer::Instance().IsReplaying())
llvm::report_fatal_error("system initialization failed");
return error;
}
// Initialize LLVM and Clang
llvm::InitializeAllTargets();